Re: [Piglit] [PATCH] cl: Add tests for stored fneg

2017-01-26 Thread Jan Vesely
On Thu, 2017-01-26 at 15:09 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > Make sure fneg that can't be folded into a use operand is > executed correctly. > > v2: Merge with other test > v3: Remove other test thanks. Reviewed-by: Jan Vesely I'll push these and the fdiv tests tomorr

Re: [Piglit] [PATCH] cl: Add tests for stored fneg

2017-01-26 Thread Jan Vesely
On Thu, 2017-01-26 at 15:11 -0800, Matt Arsenault wrote: > > On Jan 20, 2017, at 11:56, Jan Vesely wrote: > > nly one config section per test file. > > > > > + > > > +[test] > > > +name: fneg > > > +kernel_name: fneg_f32 > > > +global_size: 15 0 0 > > > + > > > +arg_out: 0 buffer float[15] \ >

Re: [Piglit] [PATCH] cl: Add tests for stored fneg

2017-01-26 Thread Matt Arsenault
> On Jan 20, 2017, at 11:56, Jan Vesely wrote: > nly one config section per test file. > >> + >> +[test] >> +name: fneg >> +kernel_name: fneg_f32 >> +global_size: 15 0 0 >> + >> +arg_out: 0 buffer float[15] \ >> + -0.0 0.0 -0.5 0.5 \ >> + -1.0 1.0 -2.0 2.0 \ >> + -4.0 4.0 -10.0 10

[Piglit] [PATCH] cl: Add tests for stored fneg

2017-01-26 Thread arsenm2
From: Matt Arsenault Make sure fneg that can't be folded into a use operand is executed correctly. v2: Merge with other test v3: Remove other test --- .../cl/program/execute/scalar-arithmetic-double.cl | 36 +++ .../cl/program/execute/scalar-arithmetic-float.cl | 42 ++-

Re: [Piglit] [PATCH 2/5] gen_conversion: explicitly enumerate conversion target types

2017-01-26 Thread Nicolai Hähnle
On 26.01.2017 20:27, Dylan Baker wrote: Quoting Nicolai Hähnle (2017-01-26 10:59:23) From: Nicolai Hähnle Currently only 'd' for double, but will be extended for 64-bit integer types. --- generated_tests/gen_conversion.py | 21 + 1 file changed, 13 insertions(+), 8 deletio

Re: [Piglit] [PATCH 2/5] gen_conversion: explicitly enumerate conversion target types

2017-01-26 Thread Dylan Baker
Quoting Nicolai Hähnle (2017-01-26 10:59:23) > From: Nicolai Hähnle > > Currently only 'd' for double, but will be extended for 64-bit integer > types. > --- > generated_tests/gen_conversion.py | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/gener

[Piglit] [PATCH 5/5] gen_conversion: generate tests for 64-bit integers

2017-01-26 Thread Nicolai Hähnle
From: Nicolai Hähnle --- generated_tests/gen_conversion.py | 302 ++--- generated_tests/templates/gen_conversion/base.mako | 2 +- 2 files changed, 264 insertions(+), 40 deletions(-) diff --git a/generated_tests/gen_conversion.py b/generated_tests/gen_convers

[Piglit] [PATCH 4/5] gen_conversion: refactor templates to allow multiple extensions

2017-01-26 Thread Nicolai Hähnle
From: Nicolai Hähnle This will be needed for the interaction of GL_ARB_gpu_shader_fp64 with GL_ARB_gpu_shader_int64. --- generated_tests/gen_conversion.py| 8 generated_tests/templates/gen_conversion/compiler_base.mako | 8 ++-- generated_tests/templates

[Piglit] [PATCH 3/5] gen_conversion: rename _gen_from/to_double and _double_type

2017-01-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Use generic names to reflect the upcoming dual use for 64-bit int types. --- generated_tests/gen_conversion.py | 44 +++ 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/generated_tests/gen_conversion.py b/generated_tests/g

[Piglit] [PATCH 2/5] gen_conversion: explicitly enumerate conversion target types

2017-01-26 Thread Nicolai Hähnle
From: Nicolai Hähnle Currently only 'd' for double, but will be extended for 64-bit integer types. --- generated_tests/gen_conversion.py | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/generated_tests/gen_conversion.py b/generated_tests/gen_conversion.

[Piglit] [PATCH 1/5] Rename gen_conversion_fp64 to gen_conversion

2017-01-26 Thread Nicolai Hähnle
From: Nicolai Hähnle We will extend it with int64 types. --- generated_tests/CMakeLists.txt | 44 +- generated_tests/gen_conversion.py | 605 + generated_tests/gen_conversion_fp64.py | 605 - generated_test

[Piglit] [PATCH 0/5] Add int64 conversion tests

2017-01-26 Thread Nicolai Hähnle
Hi all, increase the test coverage of GL_ARB_gpu_shader_int64 by testing various conversions. To avoid reinventing the wheel or duplicating code, I've extended the existing fp64 conversion test generation. The first couple of patches simply move code around and rename things. The last patch adds a

Re: [Piglit] [Review Request (master branch)] framework/test/glsl_parser_test.py: fix python script to run glslparsertest on windows

2017-01-26 Thread Dylan Baker
sys is not imported in glsl_parser_test.py, you'll need to do that. Quoting Neha Bhende (2017-01-25 15:19:54) > glslparsertest was not running on windows because python script is looking for > glslparsertest. On windows, piglit creates glslparsertest.exe. With this fix, > all glslparsertest will