Re: [Piglit] [PATCH] glsl-1.10: tests return lowering for a loop nested in an if

2017-04-06 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 04/07/2017 01:03 AM, Timothy Arceri wrote: V2: add bugzilla link to the tests comment, fixed w component of the return value. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- ...-nested-return-in-loop-nested_in_if.shader_test | 33 +++

[Piglit] [PATCH] glsl-1.10: tests return lowering for a loop nested in an if

2017-04-06 Thread Timothy Arceri
V2: add bugzilla link to the tests comment, fixed w component of the return value. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- ...-nested-return-in-loop-nested_in_if.shader_test | 33 ++ 1 file changed, 33 insertions(+) create mode 100644 tests/spec/gl

Re: [Piglit] [PATCH] glsl-1.10: tests return lowering for a loop nested in an if

2017-04-06 Thread Samuel Pitoiset
Can you add "# Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100303"; directly in the test? Except this, this patch is: Reviewed-by: Samuel Pitoiset On 04/07/2017 12:44 AM, Timothy Arceri wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- ...-nested-return-in

[Piglit] [PATCH] glsl-1.10: tests return lowering for a loop nested in an if

2017-04-06 Thread Timothy Arceri
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- ...-nested-return-in-loop-nested_in_if.shader_test | 31 ++ 1 file changed, 31 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/fs-nested-return-in-loop-nested_in_if.shader_test diff --git a/te

Re: [Piglit] [PATCH] glsl-1.50: instance name is not used to match UBO/SSBOs shader interfaces

2017-04-06 Thread Andres Gomez
On Tue, 2017-03-28 at 08:57 +1100, Timothy Arceri wrote: ... > With the remaining tests reworded in a similar way this patch is: > > Acked-by: Timothy Arceri > Thanks a lot for checking this. I've reworded the comments and this patch has already landed. -- Br, Andres ___