[Piglit] [PATCH v4] CMake: define GBM_BO_MAP only when symbol is found

2017-05-15 Thread Daniel Díaz
gbm_bo_map() and _unmap() have been added recently to Mesa, and this update may not have reached all implementations of GBM, such as the one provided by Mali r6, where said definitions can be found in the header file but not in the library itself. This leads to errors like the following when linkin

Re: [Piglit] [PATCH v3] CMake: define GBM_BO_MAP only when symbol is found

2017-05-15 Thread Jan Vesely
On Mon, 2017-05-15 at 18:54 -0500, Daniel Díaz wrote: > gbm_bo_map() and _unmap() have been added recently to Mesa, > and this update may not have reached all implementations of > GBM, such as the one provided by Mali r6, where said > definitions can be found in the header file but not in the > lib

[Piglit] [PATCH v3] CMake: define GBM_BO_MAP only when symbol is found

2017-05-15 Thread Daniel Díaz
gbm_bo_map() and _unmap() have been added recently to Mesa, and this update may not have reached all implementations of GBM, such as the one provided by Mali r6, where said definitions can be found in the header file but not in the library itself. This leads to errors like the following when linkin

[Piglit] [PATCH] texturing: Add decompression test for S3TC DXT1

2017-05-15 Thread Nanley Chery
Cc: Kenneth Graunke Cc: Mark Janes Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100925 Signed-off-by: Nanley Chery --- tests/all.py | 1 + tests/texturing/CMakeLists.gl.txt | 1 + tests/texturing/s3tc-targeted.c | 99 +++ 3

Re: [Piglit] [PATCH v2] CMake: define GBM_BO_MAP only when symbol is found

2017-05-15 Thread Daniel Díaz Rodríguez
Hello! On 15 May 2017 at 15:05, Dylan Baker wrote: > GBM_HEADERS is undefined on my system with mesa 17.0.5. Thanks for giving it a go. It failed to find gbm_bo_map (as expected) on my system, but for the wrong reason (GBM_HEADERS being undefined). I have tried a few variations around CHECK_SY

Re: [Piglit] [PATCH] pbo: delete unmapping the GL_PIXEL_UNPACK_BUFFER before using it and correct the data expected form glGetMapusv

2017-05-15 Thread Józef Kucia
On Fri, May 5, 2017 at 1:45 PM, Sandra Koroniewska wrote: > This fixes tests/spec/gl-2.1/pbo on Windows Intel driver. According to OpenGL > 2.1 spec, page 38 "Unmapping a mapped buffer > object invalidates the pointers to its data store and sets the object’s > BUFFER MAPPED state to FALSE and its

[Piglit] [PATCH v2] CMake: define GBM_BO_MAP only when symbol is found

2017-05-15 Thread Daniel Díaz
gbm_bo_map() and _unmap() have been added recently to Mesa, and this update may not have reached all implementations of GBM, such as the one provided by Mali r6, where said definitions can be found in the header file but not in the library itself. This leads to errors like the following when linkin

Re: [Piglit] [PATCH] CMake: define GBM_BO_MAP only when symbol is found

2017-05-15 Thread Daniel Díaz Rodríguez
Hello! On 11 May 2017 at 14:56, Jan Vesely wrote: > wouldn't it be cleaner to use CheckSymbolExists(gbm_bo_map GBM_HEADERS > PIGLIT_HAS_GBM_BO_MAP) > instead of the autostyle detection? Thanks for the suggestion. That didn't work for me in a previous attempt (with the wrong headers, apparently)

Re: [Piglit] [PATCH] tests: Update integration for khronos CTS runner.

2017-05-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, May 15, 2017 at 5:13 PM, Andres Gomez wrote: > After: > https://github.com/KhronosGroup/VK-GL-CTS/commit/af8c22a343ee2c230488f6de71b36dc3070b2024 > > OpenGL GL*-CTS case lists have been renamed to KHR-GL*. > > Signed-off-by: Andres Gomez > --- > tests/ct

[Piglit] [PATCH] tests: Update integration for khronos CTS runner.

2017-05-15 Thread Andres Gomez
After: https://github.com/KhronosGroup/VK-GL-CTS/commit/af8c22a343ee2c230488f6de71b36dc3070b2024 OpenGL GL*-CTS case lists have been renamed to KHR-GL*. Signed-off-by: Andres Gomez --- tests/cts_gl.py | 20 ++-- tests/cts_gl45.py | 2 +- 2 files changed, 11 insertions(+), 11

Re: [Piglit] [PATCH] pbo: delete unmapping the GL_PIXEL_UNPACK_BUFFER before using it and correct the data expected form glGetMapusv

2017-05-15 Thread sandra koroniewska
Hi, is this patch alright? I'm asking because nobody commented this yet and I don't see the patch pushed to Piglit. Thanks, Sandra On Fri, May 5, 2017 at 1:45 PM, Sandra Koroniewska < sandra.koroniew...@gmail.com> wrote: > This fixes tests/spec/gl-2.1/pbo on Windows Intel driver. According to >

[Piglit] [PATCH v2] genned-names: correct the parameter for glBindBufferRange

2017-05-15 Thread Sandra Koroniewska
This fixes tests/spec/gl-3.1/genned-names on Windows Intel driver. According to OpenGL 4.5 Core Spec section 6.7.1. page 81, offset is restricted to be a multiple of 4 for transform feedback bindings. --- tests/spec/gl-3.1/genned-names.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [Piglit] [PATCH v2] genned-names: correct the parameter for glBindBufferRange

2017-05-15 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin This makes sense to me. TFB's are apparently required to be aligned to 4 bytes, even though in earlier documents there's various talk of "basic machine units", which I can never remember what they are. Either way, 4 makes sense to me. On Fri, May 5, 2017 at 2:55 PM, Sand

Re: [Piglit] [PATCH] drawoverhead: new microbenchmark

2017-05-15 Thread Marek Olšák
On Thu, May 11, 2017 at 9:49 PM, Eric Anholt wrote: > Marek Olšák writes: > >> From: Marek Olšák >> >> Based on a benchmark from mesa/demos, but rewritten and extended. >> It's a benchmark expected to be run separately, not a piglit test. >> So why piglit? Because it's a good framework for writi