This test currently fails to return the correct 64-bit handle value
with Mesa. This is because it ends up by performing the slower
convert-and-copy process instead of just memcpy'ing the value.
Signed-off-by: Samuel Pitoiset
---
tests/spec/arb_bindless_texture/uniform.c | 89
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, July 24, 2017 9:37 PM
To: piglit@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende; Brian Paul
Subject: [PATCH] arb_texture_multisample/sample-mask-execution: check
GL_MAX_SAMPLES
Skip the t
Brian Paul writes:
> Skip the test if GL_MAX_SAMPLES=0. We basically do that test in most
> of the other MSAA tests.
>
> As is, we get a bunch of errors because we cannot create the MSAA FBO and
> then an unexpected GL_INVALID_OPERATION error generates a piglit failure.
You could only have this
If you do what Brian said:
Reviewed-by: Marek Olšák
Marek
On Tue, Jul 25, 2017 at 2:42 AM, Vinson Lee wrote:
> Fix Coverity unchecked return value defect.
>
> CID: 1415101
> Signed-off-by: Vinson Lee
> ---
> tests/glx/glx-multithread-clearbuffer.c | 11 ---
> 1 file changed, 8 insert
Reviewed-by: Ilia Mirkin
On Tue, Jul 25, 2017 at 9:46 AM, Ilia Mirkin wrote:
> Of course ARB_texture_multisample requires GL 3.x, which in turn
> requires GL_MAX_SAMPLES >= 4... I suppose this helps cheating drivers
> get cleaner results. Not a bad goal I guess, but perhaps good to note
> somewh
Of course ARB_texture_multisample requires GL 3.x, which in turn
requires GL_MAX_SAMPLES >= 4... I suppose this helps cheating drivers
get cleaner results. Not a bad goal I guess, but perhaps good to note
somewhere?
On Tue, Jul 25, 2017 at 9:37 AM, Brian Paul wrote:
> Skip the test if GL_MAX_SAMP
Skip the test if GL_MAX_SAMPLES<4 because we need 4x msaa to run this
test.
As is, if 4x MSAA is not supported, we get a bunch of FBO errors and then
an unexpected GL_INVALID_OPERATION error which generates a piglit failure.
v2: check for GL_MAX_SAMPLES >= 4 instead of non-zero.
---
tests/spec/a
