Re: [Piglit] RFC [PATCH] shader: Test to check conditional component access in loops

On 04/08/17 00:15, Gert Wollny wrote: Hi Brian, thanks for the comments. +u.z = 0.0; +} while (a <= n); Does the body of the loop need to be that complicated? The test must achieve two things: On one hand, at least one component of a temporary register must be written

[Piglit] [PATCH 2/2] ext_memory_object: add some basic api error checks

This only tests for errors when is 0, but its a start. --- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + tests/spec/ext_memory_object/CMakeLists.gl.txt | 14 ++ tests/spec/ext_memory_object/CMakeLists.txt| 1 +

Re: [Piglit] [Review Request (master branch)] textureGather: correct expected result for GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 1

Reviewed-by: Brian Paul I'll push this by tomorrow morning if there's no other comments. -Brian On 08/03/2017 05:04 AM, Neha Bhende wrote: Expected results were with respect to GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 4. This patch is fixing it for

Re: [Piglit] [Review Request (master branch)] textureGather: correct expected result for GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 1

Tests is setting GL_SWIZZLE_TEXTURE_RGBA to [GL_RED, GL_ZERO, GL_ZERO, GL_ZERO]. When GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 4 then all the 4 components are affected by textureGather on the other GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB=1, then only red component is getting

Re: [Piglit] [Review Request (master branch)] textureGather: correct expected result for GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 1

The GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB is in reference to the number of components the texture being gathered may have (with always the red component being gathered, at least with ARB_texture_gather): MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB determines what formats are

Re: [Piglit] [PATCH] egl: Add test for EGL_KHR_create_context_no_error

On 2017-08-03 02:10, Timothy Arceri wrote: One thing that is missing is a check that an error is generated (or the context is created successfully) when a shared context is created. Depending on whether the no error attributes match. That's true, but I don't know much about shared contexts

Re: [Piglit] [PATCH] egl: Add test for EGL_KHR_create_context_no_error

Hey Emil, On 2017-08-02 18:01, Emil Velikov wrote: Hi Grigori, +++ b/tests/all.py @@ -4608,6 +4608,8 @@ with profile.test_list.group_manager( run_concurrent=False) g(['egl-create-context-valid-flag-debug-gl', 'gl'], 'valid debug flag GL', run_concurrent=False) +

[Piglit] [PATCH] glx: add test for GLX_ARB_create_context_no_error

--- I'm going to rework this patch similar to the EGL test according to the review feedback. This is just here to aid testing of the implementation that I'm sending to mesa-dev and xorg-devel. Grigori .../spec/glx_arb_create_context/CMakeLists.gl.txt | 1 +

[Piglit] [Review Request (master branch)] textureGather: correct expected result for GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 1

Expected results were with respect to GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 4. This patch is fixing it for GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB =1 as well. --- tests/texturing/shaders/textureGather.c | 50 - 1 file changed, 31 insertions(+), 19

Re: [Piglit] [PATCH] egl: Add test for EGL_KHR_create_context_no_error

On 2017-08-03 02:10, Timothy Arceri wrote: One thing that is missing is a check that an error is generated (or the context is created successfully) when a shared context is created. Depending on whether the no error attributes match. I've got a partial Mesa implementation for the GLX version,

Re: [Piglit] RFC [PATCH] shader: Test to check conditional component access in loops

Hi Brian, thanks for the comments. > > > +u.z = 0.0; > > +} while (a <= n); > > Does the body of the loop need to be that complicated? The test must achieve two things: On one hand, at least one component of a temporary register must be written first at the beginning of the

Re: [Piglit] [PATCH] egl: Add test for EGL_KHR_create_context_no_error

On 03/08/17 20:48, Emil Velikov wrote: On 3 August 2017 at 01:10, Timothy Arceri wrote: One thing that is missing is a check that an error is generated (or the context is created successfully) when a shared context is created. Depending on whether the no error attributes

Re: [Piglit] [PATCH] egl: Add test for EGL_KHR_create_context_no_error

On 3 August 2017 at 01:10, Timothy Arceri wrote: > One thing that is missing is a check that an error is generated (or the > context is created successfully) when a shared context is created. Depending > on whether the no error attributes match. > > I've got a partial Mesa

[Piglit] RFC [PATCH] shader: Test to check conditional component access in loops

Hello all, this is my first message to the list. About the patch below: Commit message: "This test verifies whether the optimizer, and here specifically the register merge step keeps the according register for the whole loop alife." I created the test proposing a new register merge algorithm.