Re: [Piglit] [PATCH] glx: Rerun failing tests in auto mode if there is a pending expose event

2017-09-26 Thread Thomas Hellstrom
On 09/26/2017 08:47 AM, Brian Paul wrote: On 09/26/2017 10:32 AM, Thomas Hellstrom wrote: Tests that check frontbuffer contents after drawing may fail because the X server touch the front contents between drawing and checking. In those cases, there's typically a pending expose event. So check

Re: [Piglit] [PATCH] glx: Rerun failing tests in auto mode if there is a pending expose event

2017-09-26 Thread Brian Paul
On 09/26/2017 10:32 AM, Thomas Hellstrom wrote: Tests that check frontbuffer contents after drawing may fail because the X server touch the front contents between drawing and checking. In those cases, there's typically a pending expose event. So check for that situation and optionally rerun the t

Re: [Piglit] [PATCH] glx: Rerun failing tests in auto mode if there is a pending expose event

2017-09-26 Thread Brian Paul
On 09/26/2017 10:55 AM, Thomas Hellstrom wrote: On 09/26/2017 08:47 AM, Brian Paul wrote: On 09/26/2017 10:32 AM, Thomas Hellstrom wrote: Tests that check frontbuffer contents after drawing may fail because the X server touch the front contents between drawing and checking. In those cases, ther

Re: [Piglit] [PATCH] glx: Rerun failing tests in auto mode if there is a pending expose event

2017-09-26 Thread Eric Anholt
Thomas Hellstrom writes: > Tests that check frontbuffer contents after drawing may fail because > the X server touch the front contents between drawing and checking. In those > cases, there's typically a pending expose event. So check for that > situation and optionally rerun the test. Did this

[Piglit] [PATCH] glx: Rerun failing tests in auto mode if there is a pending expose event

2017-09-26 Thread Thomas Hellstrom
Tests that check frontbuffer contents after drawing may fail because the X server touch the front contents between drawing and checking. In those cases, there's typically a pending expose event. So check for that situation and optionally rerun the test. Signed-off-by: Thomas Hellstrom --- tests/

[Piglit] [PATCH] framework: Do not run with an empty test list

2017-09-26 Thread Arkadiusz Hiler
Because in Python we have `bool([]}) == False`, providing empty test list resulted in hitting the same code path as not providing it at all, meaning that we run everything. Let's just exit early with an appropriate message instead. This will get rid of the rather surprising behavior and will help