[Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

2017-10-12 Thread Brian Paul
The op-selection-bool-bvec4-bvec4.frag test has an expression which adds 512 terms. This causes 512 levels of recursion in Mesa's ir_expression::constant_expression_value() function. Since each function activation record is about 2KB in size with MSVC, this causes us to overflow the stack and cra

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

2017-10-12 Thread Jose Fonseca
The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. After all, nothing ever prevented us from setting a huge stack size on both MinGW and MSVC alike, as both toolchains allow to congifure the stack size to whatever we want. The key issue here i

[Piglit] [PATCH] mingw: build shader_runner with 2MB stack

2017-10-12 Thread Brian Paul
The op-selection-bool-bvec4-bvec4.frag test has an expression which adds 512 terms. This causes 512 levels of recursion in Mesa's ir_expression::constant_expression_value() function. Since each function activation record is about 2KB in size with MSVC, this causes us to overflow the stack and cra

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

2017-10-12 Thread Brian Paul
On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. After all, nothing ever prevented us from setting a huge stack size on both MinGW and MSVC alike, as both toolchains allow to congifure the stack size to

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

2017-10-12 Thread Jose Fonseca
On 12/10/17 17:51, Brian Paul wrote: On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. After all, nothing ever prevented us from setting a huge stack size on both MinGW and MSVC alike, as both toolchain

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

2017-10-12 Thread Brian Paul
On 10/12/2017 12:11 PM, Jose Fonseca wrote: On 12/10/17 17:51, Brian Paul wrote: On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. After all, nothing ever prevented us from setting a huge stack size on

Re: [Piglit] [PATCH] cl: Add tests for load hi16 instructions

2017-10-12 Thread Matt Arsenault
> On Oct 6, 2017, at 16:22, Jan Vesely wrote: > > On Tue, 2017-09-19 at 22:02 -0700, Matt Arsenault wrote: >> v2: Fix some formatting > > Reviewed-by: Jan Vesely > > sorry for the delay, feel free to cc me on cl piglit patches. I don't > think anyone else is interested in piglit cl. > Are the

[Piglit] [PATCH] cl: Add bigger versions of calls with struct tests

2017-10-12 Thread Matt Arsenault
These are just bigger versions of the existing struct calls tests so that they stress using byval/sret. The existing call with struct tests are now passed directly in registers. --- tests/cl/program/execute/calls-large-struct.cl | 156 + tests/cl/program/execute/calls-struc

[Piglit] [Bug 103248] New: piglit-util.h:308:8: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'

2017-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103248 Bug ID: 103248 Summary: piglit-util.h:308:8: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *' Product: piglit Version:

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

2017-10-12 Thread Jose Fonseca
On 12/10/17 20:19, Brian Paul wrote: On 10/12/2017 12:11 PM, Jose Fonseca wrote: On 12/10/17 17:51, Brian Paul wrote: On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. After all, nothing ever prevent

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

2017-10-12 Thread Roland Scheidegger
Am 12.10.2017 um 21:19 schrieb Brian Paul: > On 10/12/2017 12:11 PM, Jose Fonseca wrote: >> On 12/10/17 17:51, Brian Paul wrote: >>> On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build by MSVC in general. >>>

[Piglit] [Bug 103248] piglit-util.h:308:8: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'

2017-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103248 --- Comment #1 from Brian Paul --- If you change the declaration to this, does that help? const char *t = strchr(s, c); -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

[Piglit] [Bug 103248] piglit-util.h:308:8: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'

2017-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103248 --- Comment #2 from Vinson Lee --- (In reply to Brian Paul from comment #1) > If you change the declaration to this, does that help? > > const char *t = strchr(s, c); No, I get this error with that change. piglit-util.h:310:9: error: cannot i

Re: [Piglit] [PATCH] mingw: use default 2MB stack size instead of 1MB

2017-10-12 Thread Jose Fonseca
On 12/10/17 23:08, Roland Scheidegger wrote: Am 12.10.2017 um 21:19 schrieb Brian Paul: On 10/12/2017 12:11 PM, Jose Fonseca wrote: On 12/10/17 17:51, Brian Paul wrote: On 10/12/2017 08:04 AM, Jose Fonseca wrote: The intent here was not so much to match the piglti MSVC build, but apps build b

[Piglit] [Bug 103248] piglit-util.h:308:8: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'

2017-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103248 --- Comment #3 from Brian Paul --- How about this? return (t == NULL) ? ((char *) s + strlen(s)) : (char *) t; -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Piglit] [Bug 103248] piglit-util.h:308:8: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'

2017-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103248 --- Comment #4 from Vinson Lee --- (In reply to Brian Paul from comment #3) > How about this? > > return (t == NULL) ? ((char *) s + strlen(s)) : (char *) t; Yes, the combined two changes fixes the build error for me. diff --git a/tests

Re: [Piglit] [PATCH] mingw: build shader_runner with 2MB stack

2017-10-12 Thread Jose Fonseca
On 12/10/17 17:51, Brian Paul wrote: The op-selection-bool-bvec4-bvec4.frag test has an expression which adds 512 terms. This causes 512 levels of recursion in Mesa's ir_expression::constant_expression_value() function. Since each function activation record is about 2KB in size with MSVC, this

[Piglit] [PATCH 2/4] framework: fix comment typos in opengl.py

2017-10-12 Thread Brian Paul
--- framework/test/opengl.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/framework/test/opengl.py b/framework/test/opengl.py index 41dfd4a..091aeb0 100644 --- a/framework/test/opengl.py +++ b/framework/test/opengl.py @@ -65,7 +65,7 @@ class WflInfo(object):

[Piglit] [PATCH 1/4] framework: fix comment typos

2017-10-12 Thread Brian Paul
--- framework/test/shader_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/framework/test/shader_test.py b/framework/test/shader_test.py index 3e67cbd..7f3d876 100644 --- a/framework/test/shader_test.py +++ b/framework/test/shader_test.py @@ -75,7 +75,7 @@ class Pars

[Piglit] [PATCH 3/4] framework: eliminate a goto

2017-10-12 Thread Brian Paul
Not needed. Simplify the code. --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/util/piglit-framework-gl/piglit_wfl_framework.c b/tests/util/piglit-framework-gl/piglit_wfl_framework.c index 5968459..f

[Piglit] [PATCH 4/4] all.py: move assignment to groupname out of loop

2017-10-12 Thread Brian Paul
It's loop invariant. --- tests/all.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index fdb4a3e..54346d4 100644 --- a/tests/all.py +++ b/tests/all.py @@ -213,9 +213,9 @@ shader_tests = collections.defaultdict(list) # Find and add all shader test

[Piglit] [PATCH 5/6] framework: observe PIGLIT_NO_FAST_SKIP in ShaderTest::__init__()

2017-10-12 Thread Brian Paul
If PIGLIT_NO_FAST_SKIP is defined, the FastSkip/FastSkipMixin classes are no-ops. Therefore, the GL/GLSL version info collected in ShaderTest::__init()__ isn't used. Skipping the shader test parsing is a big win for reducing start-up time on Windows. There's not much difference either way on Lin

[Piglit] [PATCH 2/6] all.py: filter directories traversed to find shader tests

2017-10-12 Thread Brian Paul
The script searches all files under tests/ and generated_tests/ for files ending in ".shader_test". For each match, a ShaderTest() object is created and added to the test list. For GL extensions or versions not supported by the driver, this is wasted effort. This patch looks for directories unde

[Piglit] [PATCH 3/6] framework: move WflInfo class into new wflinfo.py module

2017-10-12 Thread Brian Paul
Reduce the clutter in opengl.py --- framework/test/opengl.py | 269 +-- framework/wflinfo.py | 290 +++ tests/all.py | 4 +- 3 files changed, 294 insertions(+), 269 deletions(-) create mode 10064

[Piglit] [PATCH 1/6] framework: fix wflinfo issues in opengl module

2017-10-12 Thread Brian Paul
1. If the PIGLIT_PLATFORM string is 'mixed_glx_egl' we need to convert it to 'glx' so that wflinfo understands it. 2. Look in the piglit bin/ directory for the wflinfo.exe program. When we build piglit, we copy wflinfo.exe into the bin/ directory for packaging to avoid having to install waffle on

[Piglit] [PATCH 4/6] framework: remove _DISABLED variable in opengl.py

2017-10-12 Thread Brian Paul
Just to simplify the code. --- framework/test/opengl.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/framework/test/opengl.py b/framework/test/opengl.py index 81de933..94d2f77 100644 --- a/framework/test/opengl.py +++ b/framework/test/opengl.py @@ -37,9 +37,6 @@ __all__

[Piglit] [PATCH 3/4] clear-accum: specify config.requires_displayed_window = true

2017-10-12 Thread Brian Paul
The accumulation buffer can only be present with the window system framebuffer, not an FBO. So this test fails if run with -fbo. Set the config.requires_displayed_window option to true to require a window system buffer. --- tests/general/clear-accum.c | 1 + 1 file changed, 1 insertion(+) diff -

[Piglit] [PATCH 6/6] all.py: use gl_extension_supported() to omit some test groups

2017-10-12 Thread Brian Paul
Some newer extensions like GL_ARB_texture_gather, GL_ARB_gpu_shader5 and GL_ARB_gpu_shader_fp64 aren't supported by some drivers. So if they're not supported by the driver, don't bother adding them to the test list. --- tests/all.py | 246 ++

[Piglit] [PATCH 2/4] util: change FAIL->SKIP in piglit_fbo_framework_create()

2017-10-12 Thread Brian Paul
If we pass -samples=X to a piglit test and the driver does not support MSAA, we get different test results depending on whether or not we set the -fbo flag. For example: $ bin/draw-pixels -auto -samples=4 piglit: error: waffle_config_choose failed due to WAFFLE_ERROR_UNKNOWN: glXChooseFBConfig r

[Piglit] [PATCH 4/4] simple-readbuffer: simplify a conditional

2017-10-12 Thread Brian Paul
I find this slightly easier to read. --- tests/spec/gl-1.0/simple-readbuffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/spec/gl-1.0/simple-readbuffer.c b/tests/spec/gl-1.0/simple-readbuffer.c index b67a286..57fbce4 100644 --- a/tests/spec/gl-1.0/simple-readb

[Piglit] [PATCH 1/4] util: don't use fbo if test_config->requires_displayed_window is true

2017-10-12 Thread Brian Paul
If the test is configured with config.requires_displayed_window = true we shouldn't create an fbo if the -fbo option is given. Fixes "drawbuffer-modes -auto -fbo" failure, for example. --- tests/util/piglit-framework-gl/piglit_gl_framework.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Piglit] [PATCH 1/5] all.py: remove run_concurrent=False from most 1.1 tests

2017-10-12 Thread Brian Paul
There was no reason for most of these tests to be marked as run_concurrent=False. The previous commits fixed a few issues when enabling concurrency. Also, move some of the slower-running tests (like streaming-texture-leak) to the top of the list to start them sooner. Piglit results with llvmpipe

[Piglit] [PATCH 5/5] all.py: remove run_concurrent=False from 1.5 tests

2017-10-12 Thread Brian Paul
--- tests/all.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/all.py b/tests/all.py index c69889a..74a7437 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1117,16 +1117,16 @@ with profile.test_list.group_manager( with profile.test_list.group_manager(

[Piglit] [PATCH 2/5] all.py: remove run_concurrent=False from 1.2 tests

2017-10-12 Thread Brian Paul
--- tests/all.py | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/tests/all.py b/tests/all.py index e58af17..4dac539 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1069,22 +1069,21 @@ with profile.test_list.group_manager( with profile.test_list

[Piglit] [PATCH 4/5] all.py: remove run_concurrent=False from 1.4 tests

2017-10-12 Thread Brian Paul
--- tests/all.py | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/tests/all.py b/tests/all.py index f2e329a..c69889a 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1096,28 +1096,23 @@ with profile.test_list.group_manager( with profile.test_list.gro

[Piglit] [PATCH 3/5] all.py: remove run_concurrent=False from 1.3 tests

2017-10-12 Thread Brian Paul
--- tests/all.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/all.py b/tests/all.py index 4dac539..f2e329a 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1089,8 +1089,8 @@ with profile.test_list.group_manager( with profile.test_list.group_manager( Pigli