Re: [Piglit] [PATCH] arb_internalformat_query2: fix TBO testing (v2)

2017-10-24 Thread Alejandro Piñeiro
On 24/10/17 03:39, Ilia Mirkin wrote: > On Mon, Oct 23, 2017 at 9:15 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> This was never tested and it uses functions that are illegal with TBOs, >> like glGetTexParameteriv and glTexImage2DMultisample. >> >> v2: enable GL_xxx_COMPONENTS testing >> ---

Re: [Piglit] [PATCH 3/4] arb_internalformat_query2: fix TBO testing

2017-10-24 Thread Marek Olšák
On Tue, Oct 24, 2017 at 8:54 AM, Alejandro Piñeiro wrote: > On 24/10/17 01:38, Marek Olšák wrote: >> On Sun, Oct 22, 2017 at 7:55 PM, Alejandro Piñeiro >> wrote: >>> On 22/10/17 17:21, Ilia Mirkin wrote: On Sun, Oct 22, 2017 at 6:33 AM, Alejandro Piñeiro wrote: > On 21/10/17 14:5

[Piglit] [PATCH] arb_internalformat_query2: fix TBO testing (v3)

2017-10-24 Thread Marek Olšák
From: Marek Olšák This was never tested and it uses functions that are illegal with TBOs, like glGetTexParameteriv and glTexImage2DMultisample. v2: enable GL_xxx_COMPONENTS testing v3: enable all pname tests --- tests/spec/arb_internalformat_query2/common.h | 4 +++- ...

Re: [Piglit] [PATCH] arb_internalformat_query2: fix TBO testing (v2)

2017-10-24 Thread Marek Olšák
Version 3 is on the list now. Marek On Tue, Oct 24, 2017 at 9:01 AM, Alejandro Piñeiro wrote: > On 24/10/17 03:39, Ilia Mirkin wrote: >> On Mon, Oct 23, 2017 at 9:15 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This was never tested and it uses functions that are illegal with TBOs, >>>

[Piglit] [PATCH] arb_internalformat_query2: don't test TEXTURE_BUFFER against GetTexParameter

2017-10-24 Thread Alejandro Piñeiro
--- Alternative fix to "arb_internalformat_query2: fix TBO testing (v3)". As mentioned on a different email, testing with target TEXTURE_BUFFER is correct, and we need to get the unsupported answer. This patch prevents to do the sanity check against GetTexParameteriv, because as Marek and Ilia po

Re: [Piglit] [PATCH] arb_internalformat_query2: don't test TEXTURE_BUFFER against GetTexParameter

2017-10-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Oct 24, 2017 at 11:25 AM, Alejandro Piñeiro wrote: > --- > > Alternative fix to "arb_internalformat_query2: fix TBO testing > (v3)". As mentioned on a different email, testing with target > TEXTURE_BUFFER is correct, and we need to get the unsupported answ

Re: [Piglit] [PATCH 5/6] framework: observe PIGLIT_NO_FAST_SKIP in ShaderTest::__init__()

2017-10-24 Thread Dylan Baker
Quoting Brian Paul (2017-10-23 10:37:39) > On 10/18/2017 06:41 PM, Dylan Baker wrote: > > Quoting Brian Paul (2017-10-12 21:23:09) > >> If PIGLIT_NO_FAST_SKIP is defined, the FastSkip/FastSkipMixin classes > >> are no-ops. Therefore, the GL/GLSL version info collected in > >> ShaderTest::__init()_

Re: [Piglit] [PATCH 3/6] framework: move WflInfo class into new wflinfo.py module

2017-10-24 Thread Dylan Baker
Quoting Brian Paul (2017-10-23 10:37:31) > On 10/18/2017 06:39 PM, Dylan Baker wrote: > > > > I think it makes sense to put TEST_BIN_DIR in core so that framework doesn't > > depend on test, but I'm content for that to be a follow up patch. > > OK, I'll make that change later. R-b on this patch?

Re: [Piglit] [PATCH 3/6] framework: move WflInfo class into new wflinfo.py module

2017-10-24 Thread dylan
Quoting Brian Paul (2017-10-23 10:37:31) > On 10/18/2017 06:39 PM, Dylan Baker wrote: > > Quoting Brian Paul (2017-10-12 21:23:07) > >> Reduce the clutter in opengl.py > >> --- > >> framework/test/opengl.py | 269 > >> +-- > >> framework/wflinfo.py |

Re: [Piglit] [PATCH 1/6] framework: fix wflinfo issues in opengl module

2017-10-24 Thread Dylan Baker
Quoting Brian Paul (2017-10-23 10:10:21) > On Wed, Oct 18, 2017 at 6:28 PM, Dylan Baker wrote: > > Quoting Brian Paul (2017-10-12 21:23:05) > > 1. If the PIGLIT_PLATFORM string is 'mixed_glx_egl' we need to convert > > it to 'glx' so that wflinfo understands it. > > > > 2. Loo

Re: [Piglit] [PATCH] all.py: filter directories traversed to find shader tests

2017-10-24 Thread Dylan Baker
Quoting Brian Paul (2017-10-23 10:47:50) > The script searches all files under tests/ and generated_tests/ for > files ending in ".shader_test". For each match, a ShaderTest() object > is created and added to the test list. > > For GL extensions or versions not supported by the driver, this is >

Re: [Piglit] [PATCH] all.py: filter directories traversed to find shader tests

2017-10-24 Thread Brian Paul
On 10/24/2017 11:01 AM, Dylan Baker wrote: Quoting Brian Paul (2017-10-23 10:47:50) The script searches all files under tests/ and generated_tests/ for files ending in ".shader_test". For each match, a ShaderTest() object is created and added to the test list. For GL extensions or versions not

Re: [Piglit] [PATCH 2/4] util, shader_runner: random fixes for compatibility profile

2017-10-24 Thread Marek Olšák
On Mon, Oct 23, 2017 at 2:49 PM, Ilia Mirkin wrote: > On Mon, Oct 23, 2017 at 8:35 AM, Marek Olšák wrote: >> On Sat, Oct 21, 2017 at 7:59 PM, Ilia Mirkin wrote: >>> On Sat, Oct 21, 2017 at 8:55 AM, Marek Olšák wrote: From: Marek Olšák --- tests/shaders/shader_runner.c

Re: [Piglit] [PATCH] util: add casts in strchrnul()

2017-10-24 Thread Vinson Lee
On Fri, Oct 13, 2017 at 9:31 AM, Brian Paul wrote: > To fix build on MacOS. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103248 > --- > tests/util/piglit-util.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/util/piglit-util.h b/tests/util/piglit-

[Piglit] [Bug 103248] piglit-util.h:308:8: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'

2017-10-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103248 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Piglit] [PATCH] minmax: change the glGet functions to accept 64-bit variables

2017-10-24 Thread Timothy Arceri
On 21/10/17 01:07, sandra koroniewska wrote: Is this fix alright now? If so, can anyone push please? Pushed. Thanks for the patch! ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit