Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2017-12-12 Thread Tapani Pälli
Hi; On 11.12.2017 22:15, Emil Velikov wrote: From: Emil Velikov Current Mesa implementation was overly cautious, flagging an error where it shouldn't - patch for Mesa is on the list. See the test for details. Cc: Ian Romanick Signed-off-by: Emil Velikov --- Nitpicks: - suggestions for te

Re: [Piglit] [PATCH 1/5] egl: Call eglBindAPI after eglInitialize

2017-12-12 Thread Emil Velikov
On 12 December 2017 at 09:08, Tapani Pälli wrote: > > > On 12/12/2017 10:23 AM, Tapani Pälli wrote: >> >> >> On 12/11/2017 10:15 PM, Emil Velikov wrote: >>> >>> From: Emil Velikov >>> >>> A couple of tests were calling eglBindAPI before eglInitialize. >>> Some versions of Mesa had problem with su

Re: [Piglit] [PATCH 1/5] egl: Call eglBindAPI after eglInitialize

2017-12-12 Thread Tapani Pälli
On 12/12/2017 10:23 AM, Tapani Pälli wrote: On 12/11/2017 10:15 PM, Emil Velikov wrote: From: Emil Velikov A couple of tests were calling eglBindAPI before eglInitialize. Some versions of Mesa had problem with such invocation order and the seeming consensus was that apps should not do that.

Re: [Piglit] [PATCH 1/5] egl: Call eglBindAPI after eglInitialize

2017-12-12 Thread Tapani Pälli
On 12/11/2017 10:15 PM, Emil Velikov wrote: From: Emil Velikov A couple of tests were calling eglBindAPI before eglInitialize. Some versions of Mesa had problem with such invocation order and the seeming consensus was that apps should not do that. This is likely a copy/paste mistake, that was