Re: [Piglit] [PATCH 1/2] arb_internalformat_query2: avoid bogus error spam about unsupported pnames

2018-01-26 Thread Roland Scheidegger
Am 27.01.2018 um 02:00 schrieb srol...@vmware.com: > From: Roland Scheidegger > > The test fed the equivalent_pname into the get_unsupported_response() > function, which led to nonsense logged errors as this only recognizes > the original pnames. > Refactor

[Piglit] [PATCH 2/2] arb_internalformat_query2: don't try glGetTexLevelParameteriv() for tex buffers

2018-01-26 Thread sroland
From: Roland Scheidegger I believe querying that information for GL_TEXTURE_BUFFFER via internal format query should return the correct values, but it's definitely impossible if just ARB_texture_buffer_object is supported but not GL 3.1. Hence just pretend it succeeded in

[Piglit] [PATCH 1/2] arb_internalformat_query2: avoid bogus error spam about unsupported pnames

2018-01-26 Thread sroland
From: Roland Scheidegger The test fed the equivalent_pname into the get_unsupported_response() function, which led to nonsense logged errors as this only recognizes the original pnames. Refactor pname/equivalent_pname translation so always the original pnames are fed into

Re: [Piglit] [PATCH 01/15] tests/util: Add config value to enumerate subtests

2018-01-26 Thread Dylan Baker
I can go either way, if you like 2 better then lets go with that. Quoting Fabian Bieler (2018-01-26 11:33:04) > I can resend to the list. > Did we reach an agreement on how piglit_run_selected_subtests should behave? > > Should it > enumerate all tests and mark unselected tests PIGLIT_SKIP > or

Re: [Piglit] [PATCH 01/15] tests/util: Add config value to enumerate subtests

2018-01-26 Thread Fabian Bieler
I can resend to the list. Did we reach an agreement on how piglit_run_selected_subtests should behave? Should it enumerate all tests and mark unselected tests PIGLIT_SKIP or enumerate only selected tests implicitly marking unselected tests as "not run" when compared to another test run? I favor

Re: [Piglit] [PATCH 01/15] tests/util: Add config value to enumerate subtests

2018-01-26 Thread Dylan Baker
Fabian, When you get a chance can you send your updated version of this series to the list? I think this is probably a good candidate for piecemeal fixes, we can land the framework bits and the initial tests that are ported, then land the changes to the rest of the tests in manageable chunks.

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2018-01-26 Thread Tapani Pälli
On 01/25/2018 07:28 PM, Emil Velikov wrote: On 21 December 2017 at 09:26, Tapani Pälli wrote: On 12/18/2017 04:37 PM, Emil Velikov wrote: On 13 December 2017 at 12:54, Tapani Pälli wrote: The test doesn't care how well eglCopyBuffers