Re: [Piglit] [PATCH 1/2] fbo-drawbuffers2-blend: fix incorrect comments

Brian Paul writes: > --- > tests/fbo/fbo-drawbuffers2-blend.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) These 2 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___

[Piglit] [PATCH 1/2] fbo-drawbuffers2-blend: fix incorrect comments

--- tests/fbo/fbo-drawbuffers2-blend.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/fbo/fbo-drawbuffers2-blend.c b/tests/fbo/fbo-drawbuffers2-blend.c index b97803b..2c16b8f 100644 --- a/tests/fbo/fbo-drawbuffers2-blend.c +++ b/tests/fbo/fbo-drawbuffers2-blend.c

[Piglit] [PATCH 2/2] piglit: fix some warnings about no return value from non-void function

--- tests/spec/arb_texture_multisample/large-float-texture.c | 1 + tests/spec/arb_vertex_program/property-bindings.c| 4 +++- tests/spec/glsl-1.10/execution/built-in-uniform-state.c | 4 +++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [Piglit] [PATCH] tests: add INTEL_blackhole_render

On 16/03/18 12:53, Lionel Landwerlin wrote: > On 16/03/18 07:31, Alejandro Piñeiro wrote: >> Is adding ${OPENGL_gl_LIBRARY} at link_libraries really needed at this >> gles CMakeKist? As far as I have seen, most gles2/3 CMakeLists just adds >> piglitutil_${piglit_target_api}. >> > Looks like I can

Re: [Piglit] [PATCH] tests: add INTEL_blackhole_render

On 16/03/18 07:31, Alejandro Piñeiro wrote: Is adding ${OPENGL_gl_LIBRARY} at link_libraries really needed at this gles CMakeKist? As far as I have seen, most gles2/3 CMakeLists just adds piglitutil_${piglit_target_api}. Looks like I can drop it from the GL tests too and it still links... Does

Re: [Piglit] [PATCH] tests: add INTEL_blackhole_render

Looks good to me, just a minor comment below. On 15/03/18 15:15, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > registry/gl.xml| 8 +- > tests/all.py | 9 ++ >