[Piglit] [PATCH] gl-3.0: test glUniform*ui{v} functions are compiled into display lists

2018-05-09 Thread Timothy Arceri
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78097 --- tests/opengl.py | 2 + tests/spec/gl-3.0/CMakeLists.gl.txt | 1 + tests/spec/gl-3.0/dlist-uint-uniforms.c | 305 3 files changed, 308 insertions(+) create mode 100644

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-05-09 Thread Matt Turner
On Tue, May 8, 2018 at 7:07 AM, Michel Dänzer wrote: > On 2018-05-07 06:49 PM, Michel Dänzer wrote: >> On 2018-05-07 06:44 PM, Dylan Baker wrote: >>> Quoting Tomi Sarvela (2018-05-07 01:20:46) piglit/framework$ diff -c profile.py.orig profile.py ***

Re: [Piglit] [PATCH v2] ext_packed_float: Add a test that queries GL_RGBA_SIGNED_COMPONENTS_EXT

2018-05-09 Thread Brian Paul
Reviewed-by: Brian Paul Thanks, Timothy! On 05/09/2018 05:52 PM, Timothy Arceri wrote: From: Bruce Merry V2 (Timothy Arceri): - use piglit_get_gl_enum_name() - use ARRAY_SIZE() - set config.khr_no_error_support Cc: Brian Paul

[Piglit] [PATCH v2] ext_packed_float: Add a test that queries GL_RGBA_SIGNED_COMPONENTS_EXT

2018-05-09 Thread Timothy Arceri
From: Bruce Merry V2 (Timothy Arceri): - use piglit_get_gl_enum_name() - use ARRAY_SIZE() - set config.khr_no_error_support Cc: Brian Paul Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73096 --- tests/opengl.py |

Re: [Piglit] [PATCH] ext_packed_float: Add a test that queries GL_RGBA_SIGNED_COMPONENTS_EXT

2018-05-09 Thread Timothy Arceri
On 10/05/18 03:36, Bruce Merry wrote: Hi I'm afraid it's been about 4 years since I last did any OpenGL work. Realistically I don't think that rebasing this is going to make it to the top of my priority stack any time soon. Apologies for abandoning it. Not a problem I'll get this over the

[Piglit] [PATCH 1/2] Fix bogus assertions in builtin uniform test generator.

2018-05-09 Thread Kenneth Graunke
self.test_rows is measured in a number of 4x4 rectangles, but y is measured in pixels, so they are not comparable. The only reason this doesn't trip is because self.test_rows is currently the number of 4x4 rectangles that can fit in a 250x250 window (62)...and no test has nearly that many rows of

[Piglit] [PATCH 2/2] Specify an explicit window size in builtin uniform tests.

2018-05-09 Thread Kenneth Graunke
Currently, these tests assume a 250x250 window size, but don't specify SIZE 250x250, which means they can break when using PIGLIT_DEFAULT_SIZE. The tests draw multiple 4x4 rectangles side by side, and lay them out based on the window size. We bump the window width to 256 so that it's a multiple

[Piglit] [PATCH 2/3] tests: rename shader_*_multi to shader_*.no_isolation

2018-05-09 Thread Dylan Baker
This allows the --process-isolation flag to control these profiles and load the correct one, as enabled by the previous patch. --- tests/CMakeLists.no_api.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/CMakeLists.no_api.txt b/tests/CMakeLists.no_api.txt index

[Piglit] [PATCH 3/3] tests: Add gpu and quick no_isolation metaprofiles

2018-05-09 Thread Dylan Baker
Even without these --process-isolation works as expected, but these improve runtime (for me by almost a minute) by putting the tests in a more optimal order. This is a very cheap optimization. --- tests/gpu.no_isolation.meta.xml | 11 +++ tests/quick.no_isolation.meta.xml | 6 ++ 2

[Piglit] [PATCH 1/3] profile: add the idea of process-isolated xml file

2018-05-09 Thread Dylan Baker
This adds a new name.no_process.xml (or .meta.xml) file that is loaded when --process-isolation=false is used. --- framework/profile.py | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/framework/profile.py b/framework/profile.py index aff0ffa2c..ffc91e0a6

Re: [Piglit] [PATCH v4] tests: add nvidia conservative rasterization tests

2018-05-09 Thread Rhys Perry
Ping I guess? On Fri, Mar 30, 2018 at 10:56 PM, Rhys Perry wrote: > Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate > and GL_NV_conservative_raster_pre_snap_triangles. > > Changes in v2: > - cleanup the tests > - fix some test failures > -

Re: [Piglit] [PATCH 1/4] framework: ensure that all tests are run before exiting

2018-05-09 Thread Dylan Baker
Quoting Michel Dänzer (2018-05-09 02:33:13) > On 2018-05-08 11:27 PM, Dylan Baker wrote: > > Michel, does this series fix the remaining issues you're seeing? > > It mostly fixes the gpu profile running fewer tests than before. The > only remaining minor issue there is that the >

Re: [Piglit] [PATCH 1/4] framework: ensure that all tests are run before exiting

2018-05-09 Thread Dylan Baker
Quoting Michel Dänzer (2018-05-09 02:33:13) > On 2018-05-08 11:27 PM, Dylan Baker wrote: > > Michel, does this series fix the remaining issues you're seeing? > > It mostly fixes the gpu profile running fewer tests than before. The > only remaining minor issue there is that the >

Re: [Piglit] [PATCH] framework: fix running with mixed concurrency (neither -c or -1)

2018-05-09 Thread Dylan Baker
Quoting Arkadiusz Hiler (2018-05-09 03:56:53) > On Tue, May 08, 2018 at 10:32:26AM -0700, Dylan Baker wrote: > > test_list is an iterator, you can't walk an iterator more than once. To > > solve this we use itertools.tee, which creates a shared buffer for the > > iterators to draw from. This fixes

Re: [Piglit] [PATCH] ext_packed_float: Add a test that queries GL_RGBA_SIGNED_COMPONENTS_EXT

2018-05-09 Thread Brian Paul
Minor things below. -Brian On 05/09/2018 12:13 AM, Timothy Arceri wrote: From: Bruce Merry Cc: Brian Paul Bugzilla:

Re: [Piglit] [PATCH] gl-1.5-get-array-attribs: exercise glGetIntegerv, etc. with vertex arrays

2018-05-09 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, May 9, 2018 8:30:05 AM To: piglit@lists.freedesktop.org Cc: xuelian@samsung.com; Neha Bhende; Charmaine Lee; Brian Paul Subject: [PATCH]

[Piglit] [PATCH] gl-1.5-get-array-attribs: exercise glGetIntegerv, etc. with vertex arrays

2018-05-09 Thread Brian Paul
This new test checks that glGetInteger/Fload/Double/Booleanv() return the right values when querying vertex array attributes. Currently broken in Mesa. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106450 --- tests/opengl.py | 1 +

Re: [Piglit] [PATCH] framework: fix running with mixed concurrency (neither -c or -1)

2018-05-09 Thread Juan A. Suarez Romero
On Tue, 2018-05-08 at 10:32 -0700, Dylan Baker wrote: > test_list is an iterator, you can't walk an iterator more than once. To > solve this we use itertools.tee, which creates a shared buffer for the > iterators to draw from. This fixes errors like: > Cool!! It seems to fix the problem. Thank

Re: [Piglit] [PATCH] framework: fix running with mixed concurrency (neither -c or -1)

2018-05-09 Thread Arkadiusz Hiler
On Tue, May 08, 2018 at 10:32:26AM -0700, Dylan Baker wrote: > test_list is an iterator, you can't walk an iterator more than once. To > solve this we use itertools.tee, which creates a shared buffer for the > iterators to draw from. This fixes errors like: > > [000/480] > Traceback (most recent

[Piglit] [PATCH] profile: Don't exhaust generator when concurrency == "some"

2018-05-09 Thread Arkadiusz Hiler
TestProfile.itertests() is a generator that we happily exhaust. If concurrency == "some" then run_profile() invokes run_threads() twice, once for thread safe tests, and once for non-safe ones. The first invocation exhaust the generator, so the second one sees nothing. This patch changes the call

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-05-09 Thread Michel Dänzer
On 2018-05-08 07:19 PM, Dylan Baker wrote: > Quoting Michel Dänzer (2018-05-08 07:07:34) >> >> I just bisected another problem to >> 9461d92301e72807eba4776a16a05207e3a16477: The xts-render profile doesn't >> work anymore. Most of the time, it doesn't even start: >> >> [000/480] >> Traceback

Re: [Piglit] [PATCH 1/4] framework: ensure that all tests are run before exiting

2018-05-09 Thread Michel Dänzer
On 2018-05-08 11:27 PM, Dylan Baker wrote: > Michel, does this series fix the remaining issues you're seeing? It mostly fixes the gpu profile running fewer tests than before. The only remaining minor issue there is that the shaders@glsl-{fs,vs}-{inline,unroll}-explosion tests were previously

Re: [Piglit] [PATCH] framework: fix running with mixed concurrency (neither -c or -1)

2018-05-09 Thread Michel Dänzer
On 2018-05-08 07:32 PM, Dylan Baker wrote: > test_list is an iterator, you can't walk an iterator more than once. To > solve this we use itertools.tee, which creates a shared buffer for the > iterators to draw from. This fixes errors like: > > [000/480] > Traceback (most recent call last): >

[Piglit] [PATCH] ext_packed_float: Add a test that queries GL_RGBA_SIGNED_COMPONENTS_EXT

2018-05-09 Thread Timothy Arceri
From: Bruce Merry Cc: Brian Paul Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73096 --- I came across this test when cleaning up bugzilla. Seems we fixed Mesa but never pushed the piglit test. tests/all.py |