Re: [Piglit] [PATCH] arb_gpu_shader_fp64: Test the sign() function with abs() and negation of its argument

2018-06-29 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 27/06/18 17:28, Ian Romanick wrote: From: Ian Romanick The saturate version hits an assertion failure in the Mesa i965 driver: src/intel/compiler/brw_fs.cpp:2377: bool fs_visitor::opt_algebraic(): Assertion `!"unimplemented: saturate mixed types"' failed. Sig

Re: [Piglit] [PATCH 7/9] tests/opengl: Add intel_conservative_rasterization-invalid_gles3

2018-06-29 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 27/06/18 18:32, Dylan Baker wrote: Fixes: ed153b51b57762e43d44e8f49dbe9bf0422e1400 ("Add GL_INTEL_conservative_rasterization tests") CC: Lionel Landwerlin --- tests/opengl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/opengl.py b/test

Re: [Piglit] [PATCH 8/9] tests/opengl: Add nv_image_formats-gles3

2018-06-29 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 27/06/18 18:32, Dylan Baker wrote: Fixes: 6ed37e5d2a58d36b4b04b09f8c069f2dbcff1968 ("Add nv_image_formats tests") CC: Lionel Landwerlin --- tests/opengl.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/opengl.py b/tests/opengl.py in

[Piglit] [PATCH 4/4] arb_gl_spirv: add test that mixes atomic counters with a normal uniform

2018-06-29 Thread Alejandro Piñeiro
Under ARB_gl_spirv, most uniforms require a explicit location. There are some exceptions like atomic counters. In that case, some drivers like mesa, still sets internally a location for those. This test purpose is checking that mixing "normal" uniforms with uniforms without location works properly,

[Piglit] [PATCH 2/4] arb_gl_spirv: add tests for atomic counter operations in FS

2018-06-29 Thread Alejandro Piñeiro
From: Antia Puentes Tests the atomic counter operations and layout qualifiers offset and binding described in the ARB_shader_atomic_counters specification. They check the final values for the atomic counters and that the values returned by the atomic counter operations are the expected ones. In

[Piglit] [PATCH 3/4] arb_gl_spirv: add tests for atomic counter operations in CS

2018-06-29 Thread Alejandro Piñeiro
From: Antia Puentes Tests the atomic counter operations and layout qualifiers offset and binding described in the ARB_shader_atomic_counters specification in a CS with local_size_x, y, z equal to 3, 2 and 1 respectively. Includes 3 tests: atomic_uint, arrays of atomic_uint and AOA of atomic_uint

[Piglit] [PATCH 1/4] shader_runner: add command 'probe atomic counter buffer'

2018-06-29 Thread Alejandro Piñeiro
From: Antia Puentes Extends the already existing 'probe atomic counter' command to allow comparing the value of an atomic counter stored in an ATOMIC_COUNTER_BUFFER with a binding different from zero, and at a chosen offset. In other words, adds support to test the atomic counter layout qualifier

[Piglit] [PATCH 0/4] ARB_gl_spirv: atomic counters tests

2018-06-29 Thread Alejandro Piñeiro
Hi, this is the second series with patches for the ARB_gl_spirv extension. This series includes atomic counter tests. The patches providing support for that feature on mesa has been sent recently to mesa-dev. This series depends on the still-to-be-reviewed first series with tests for ARB_gl_spirv