Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

2018-08-22 Thread Sagar Ghuge
Thank you for such a constructive comments/suggestions. I took a reference from existing depth_clamp tests. I will apply your suggestions to both the new tests and existing tests and send next revision. Thank you so much for reviewing the series. On 08/22/2018 01:37 PM, Ian Romanick wrote: >

Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

2018-08-22 Thread Ian Romanick
On 08/21/2018 05:05 PM, Sagar Ghuge wrote: > Signed-off-by: Sagar Ghuge > --- > tests/opengl.py | 8 + > tests/spec/CMakeLists.txt | 1 + > .../CMakeLists.gl.txt | 15 ++ > .../amd_depth_clamp_separate/CMakeLists.txt

Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

2018-08-22 Thread Marek Olšák
The other two tests should also do: piglit_require_extension("GL_AMD_depth_clamp_separate"); Marek On Tue, Aug 21, 2018 at 8:05 PM Sagar Ghuge wrote: > > Signed-off-by: Sagar Ghuge > --- > tests/opengl.py | 8 + > tests/spec/CMakeLists.txt |

[Piglit] [PATCH piglit] egl_khr_create_context: Proper invalid attributes for EGL 1.5

2018-08-22 Thread Miguel A. Vico
When EGL_KHR_create_context was originally written, EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR was an invalid attribute for OpenGL ES. After moving the extension to core EGL 1.5, the aforementioned attribute was made valid for both OpenGL and OpenGL ES. Check whether the EGL version is lo

Re: [Piglit] [PATCH piglit 4/4] egl: fix uninitialised counter

2018-08-22 Thread Caio Marcelo de Oliveira Filho
On Wed, Aug 22, 2018 at 12:38:42PM +0100, Eric Engestrom wrote: > CovID: 1438468 (UNINIT) > Fixes: e49d4479d6cabce970bb9 egl: Add basic EGL_MESA_device_software test" > Signed-off-by: Eric Engestrom > --- > .../spec/egl_mesa_device_software/egl_mesa_device_software.c| 2 +- > 1 file changed,

Re: [Piglit] [PATCH piglit 2/4] util: fix memory leak

2018-08-22 Thread Caio Marcelo de Oliveira Filho
On Wed, Aug 22, 2018 at 12:38:40PM +0100, Eric Engestrom wrote: > CovID: 1438469 (RESOURCE_LEAK) > Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test files" > Signed-off-by: Eric Engestrom > --- > tests/util/piglit-shader-test.c | 1 + > 1 file changed, 1 insertion(+) This p

Re: [Piglit] [PATCH piglit 1/4] arb_gpu_shader5: fix memory leak

2018-08-22 Thread Caio Marcelo de Oliveira Filho
On Wed, Aug 22, 2018 at 12:38:39PM +0100, Eric Engestrom wrote: > CovID: 1438471 (RESOURCE_LEAK) > Fixes: 7ec9b1734b66ee41c2700 "arb_gpu_shader5: Add support for testing > spirv with XFB streams" > Signed-off-by: Eric Engestrom > --- > .../execution/xfb-streams-witho

[Piglit] [PATCH] glsl-1.20: test that 'invariant' qualifier does not propagate on uniforms

2018-08-22 Thread Danylo Piliaiev
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100316 Signed-off-by: Danylo Piliaiev --- .../linker/invariant-propagation.shader_test | 25 +++ 1 file changed, 25 insertions(+) create mode 100644 tests/spec/glsl-1.20/linker/invariant-propagation.shader_test diff --git

[Piglit] [PATCH piglit 3/4] egl: fix uninitialised counter

2018-08-22 Thread Eric Engestrom
CovID: 1438470 (UNINIT) Fixes: 6c08c9fab326a526b41e1 "egl: Add basic EGL_EXT_device_drm test" Signed-off-by: Eric Engestrom --- tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/egl/spec/egl_ext_device_drm/egl_ext_devi

[Piglit] [PATCH piglit 4/4] egl: fix uninitialised counter

2018-08-22 Thread Eric Engestrom
CovID: 1438468 (UNINIT) Fixes: e49d4479d6cabce970bb9 egl: Add basic EGL_MESA_device_software test" Signed-off-by: Eric Engestrom --- .../spec/egl_mesa_device_software/egl_mesa_device_software.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/egl/spec/egl_mesa_device_s

[Piglit] [PATCH piglit 2/4] util: fix memory leak

2018-08-22 Thread Eric Engestrom
CovID: 1438469 (RESOURCE_LEAK) Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test files" Signed-off-by: Eric Engestrom --- tests/util/piglit-shader-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/piglit-shader-test.c b/tests/util/piglit-shader-test.c ind

[Piglit] [PATCH piglit 1/4] arb_gpu_shader5: fix memory leak

2018-08-22 Thread Eric Engestrom
CovID: 1438471 (RESOURCE_LEAK) Fixes: 7ec9b1734b66ee41c2700 "arb_gpu_shader5: Add support for testing spirv with XFB streams" Signed-off-by: Eric Engestrom --- .../execution/xfb-streams-without-invocations.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Piglit] [PATCH 2/2] cl: Add tests for calls with special inputs

2018-08-22 Thread Matt Arsenault
Also fixes apparently missing coverage for special input arguments not passed in registers. --- tests/cl/program/execute/calls-workitem-id.cl | 136 ++ 1 file changed, 136 insertions(+) diff --git a/tests/cl/program/execute/calls-workitem-id.cl b/tests/cl/program/execute/calls-wo

[Piglit] [PATCH 1/2] cl: Add test for respecting byval alignment in call setup

2018-08-22 Thread Matt Arsenault
--- .../cl/program/execute/calls-large-struct.cl | 36 +++ 1 file changed, 36 insertions(+) diff --git a/tests/cl/program/execute/calls-large-struct.cl b/tests/cl/program/execute/calls-large-struct.cl index c10458f37..0eac4d470 100644 --- a/tests/cl/program/execute/calls-large-s

Re: [Piglit] [Mesa-dev] XDC 2018: Call for Papers

2018-08-22 Thread Daniel Vetter
Hi all, We received an overwhelming response for this CFP - 35+ proposals (and still some latecomers trickling in), for only 18 slots. What we didn't much get (and the CFP failed to make it clear that we're looking for this) is proposals for the workshop/discussion track in the 2nd room. In the p