Re: [Piglit] [PATCH v1] piglit/vbo: memory leak

2018-10-11 Thread Ian Romanick
Reviewed-by: Ian Romanick On 10/11/2018 05:59 AM, Sergii Romantsov wrote: > Trivial fix of memory leaking for test 'initialized-vbo'. > > Fixes: 6a467e00cfae (security/initialized-vbo: test contents of uninitialized > VBOs) > CC: Brian Paul > Signed-off-by: Sergii Romantsov > --- >

Re: [Piglit] [PATCH] builtin_packing: Add swizzles to the sources of packing functions

2018-10-11 Thread Ian Romanick
On 10/11/2018 02:09 PM, Jason Ekstrand wrote: > commit dd553bc67f8ab1513fd196b6ffb7c4a76723adfd > Author: Jason Ekstrand > > Date:   Wed Oct 3 12:14:20 2018 -0500 > >     nir/alu_to_scalar: Use ssa_for_alu_src in hand-rolled expansions >     >     The

Re: [Piglit] [PATCH] builtin_packing: Add swizzles to the sources of packing functions

2018-10-11 Thread Jason Ekstrand
commit dd553bc67f8ab1513fd196b6ffb7c4a76723adfd Author: Jason Ekstrand Date: Wed Oct 3 12:14:20 2018 -0500 nir/alu_to_scalar: Use ssa_for_alu_src in hand-rolled expansions The ssa_for_alu_src helper will correctly handle swizzles and other source modifiers for you. The expansions

Re: [Piglit] [PATCH] egl: doesn't allow egl to create a forward-compatible context with req ver < 3

2018-10-11 Thread Matt Turner
Hello, Thanks for the patch. I notice that there are a lot of whitespace errors in this patch. I would fix them myself when I commit, but I have some questions that might require other changes. They should be pretty apparent. On Thu, Oct 11, 2018 at 4:35 AM wrote: > > From: Andrii Simiklit >

Re: [Piglit] [PATCH v2] framework/wflinfo: use x11_egl for gles with mixed_glx_egl

2018-10-11 Thread Dylan Baker
Quoting Emil Velikov (2018-10-11 03:48:20) > On Fri, 5 Oct 2018 at 17:06, Dylan Baker wrote: > > > > Because wflinfo returns GL legacy (non-profile) for gles on glx. > > > > v2: - If the platform is pure GLX then warn that things aren't going to > > work. > > --- > > framework/wflinfo.py |

[Piglit] [PATCH v1] piglit/vbo: memory leak

2018-10-11 Thread Sergii Romantsov
Trivial fix of memory leaking for test 'initialized-vbo'. Fixes: 6a467e00cfae (security/initialized-vbo: test contents of uninitialized VBOs) CC: Brian Paul Signed-off-by: Sergii Romantsov --- tests/security/initialized-vbo.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Piglit] [PATCH] egl: doesn't allow egl to create a forward-compatible context with req ver < 3

2018-10-11 Thread asimiklit . work
From: Andrii Simiklit EGL_KHR_create_context spec says: "The default values for EGL_CONTEXT_MAJOR_VERSION_KHR and EGL_CONTEXT_MINOR_VERSION_KHR are 1 and 0 respectively." requesting a forward-compatible context for OpenGL versions less than 3.0 will

Re: [Piglit] [PATCH v2] framework/wflinfo: use x11_egl for gles with mixed_glx_egl

2018-10-11 Thread Eric Engestrom
On Friday, 2018-10-05 09:06:24 -0700, Dylan Baker wrote: > Because wflinfo returns GL legacy (non-profile) for gles on glx. > > v2: - If the platform is pure GLX then warn that things aren't going to > work. > --- > framework/wflinfo.py | 21 +++-- > 1 file changed, 19

Re: [Piglit] [PATCH v2] framework/wflinfo: use x11_egl for gles with mixed_glx_egl

2018-10-11 Thread Emil Velikov
On Fri, 5 Oct 2018 at 17:06, Dylan Baker wrote: > > Because wflinfo returns GL legacy (non-profile) for gles on glx. > > v2: - If the platform is pure GLX then warn that things aren't going to > work. > --- > framework/wflinfo.py | 21 +++-- > 1 file changed, 19