Re: [Piglit] [PATCH 1/2] util: make it easier to use probe functions on ES

2019-02-13 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 2/13/19 5:40 AM, Ilia Mirkin wrote: With float color buffers, one can use glReadPixels with GL_FLOAT. Allow that usage scenario. Signed-off-by: Ilia Mirkin --- tests/util/piglit-util-gl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/

Re: [Piglit] [PATCH 2/2] ext_color_buffer_float: check fp32 blend enforcement

2019-02-13 Thread Tapani Pälli
On 2/13/19 9:15 AM, Tapani Pälli wrote: On 2/13/19 5:40 AM, Ilia Mirkin wrote: Without EXT_float_blend, fp32 blending should be disallowed. Ensure that this is the case. If it is supported, ensure that blending works as expected. Signed-off-by: Ilia Mirkin ---   tests/opengl.py

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: test alpha channel for AYUV format

2019-02-13 Thread Lionel Landwerlin
On 13/02/2019 08:28, Tapani Pälli wrote: Patches changes expected result to have a alpha ramp in case format supports alpha, each alpha supporting format should make sure data matches this expectation. Signed-off-by: Tapani Pälli Looks good, thanks! Reviewed-by: Lionel Landwerlin ---

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add P12, P16 format support

2019-02-13 Thread Lionel Landwerlin
On 13/02/2019 12:20, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Thanks for adding these. Reviewed-by: Lionel Landwerlin --- tests/opengl.py | 4 +++ .../ext_image_dma_buf_import/sample_common.c | 2 ++ .../ext_image_dma_buf_import/sample_yuv.c

[Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add P12, P16 format support

2019-02-13 Thread Tapani Pälli
v2: fix indentation and add /* Y */ comment to P16 Signed-off-by: Tapani Pälli --- tests/opengl.py | 4 +++ .../ext_image_dma_buf_import/sample_common.c | 2 ++ .../ext_image_dma_buf_import/sample_yuv.c | 28 +++ .../piglit-framework-gl/piglit

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add P12, P16 format support

2019-02-13 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- tests/opengl.py | 4 +++ .../ext_image_dma_buf_import/sample_common.c | 2 ++ .../ext_image_dma_buf_import/sample_yuv.c | 27 +++ .../piglit-framework-gl/piglit_drm_dma_buf.c | 4 +++ .../piglit-framework-gl/pi

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: test alpha channel for AYUV format

2019-02-13 Thread Tapani Pälli
Patches changes expected result to have a alpha ramp in case format supports alpha, each alpha supporting format should make sure data matches this expectation. Signed-off-by: Tapani Pälli --- .../ext_image_dma_buf_import/sample_yuv.c | 60 --- 1 file changed, 39 insertions(+