Re: [Piglit] [PATCH] arb_shading_language_420pack: test invalid function return type

2019-02-22 Thread apinheiro
Perhaps a spec quote? With or without it: Reviewed-by: Alejandro Piñeiro On 21/2/19 12:50, Tapani Pälli wrote: Extension adds implicit conversion for return types. This test checks that driver does not incorrectly allow invalid return type. Signed-off-by: Tapani Pälli --- .../implicit-conv

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add YUYV format support

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- tests/opengl.py | 2 ++ tests/spec/ext_image_dma_buf_import/sample_yuv.c| 13 + tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 2 ++ 3 files changed, 17 insertions(+) diff --git a/tests/opengl.py b/

[Piglit] [PATCH] editorconfig: Add max_line_length property

2019-02-22 Thread Andres Gomez
The property is supported by most of the editors, but not all: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Cc: Eric Engestrom Cc: Eric Anholt Signed-off-by: Andres Gomez --- .editorconfig | 4 1 file changed, 4 insertions(+) diff --git a/.edi

Re: [Piglit] [PATCH] editorconfig: Add max_line_length property

2019-02-22 Thread apinheiro
On 22/2/19 15:51, Andres Gomez wrote: The property is supported by most of the editors, but not all: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Cc: Eric Engestrom Cc: Eric Anholt Signed-off-by: Andres Gomez It is really realistic to set 79 as

Re: [Piglit] [PATCH] ARB_shader_storage_buffer_object: check ssbo array optimizations

2019-02-22 Thread Ian Romanick
I made a couple small adjustments to the tests and pushed them. Thanks! On 2/15/19 5:43 AM, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > The tests for a compiler which leads to mismatch between max_array_access > and the var type when the compiler tries to optimize unused ssbo in

Re: [Piglit] [PATCH] ARB_shader_storage_buffer_object: check ssbo array optimizations

2019-02-22 Thread andrey simiklit
Thanks for reviewing and push) Andrii. On Fri, Feb 22, 2019 at 8:25 PM Ian Romanick wrote: > I made a couple small adjustments to the tests and pushed them. > > Thanks! > > On 2/15/19 5:43 AM, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > The tests for a compiler which leads

Re: [Piglit] [PATCH] editorconfig: Add max_line_length property

2019-02-22 Thread Ian Romanick
On 2/22/19 8:25 AM, apinheiro wrote: > > On 22/2/19 15:51, Andres Gomez wrote: >> The property is supported by most of the editors, but not all: >> https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length >> >> >> Cc: Eric Engestrom >> Cc: Eric Anholt >> Signed-o

Re: [Piglit] [PATCH v2 1/1] viewport-clamp: to test the viewport clamping

2019-02-22 Thread Nanley Chery
On Thu, Feb 21, 2019 at 08:30:59PM +0200, Eleni Maria Stea wrote: > A test to check the viewport clamping and to reproduce the following bug > on i965: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108999 > > v2: > - Renamed the test to something more relevant (Nanley Chery) > -