Re: [Piglit] [PATCH] intel_shader_atomic_float_minmax: Explicitly request std430 layout

2019-06-26 Thread Dave Airlie
On Thu, 27 Jun 2019 at 03:00, Ian Romanick wrote: > > From: Ian Romanick > > These tests preinit the ssbo contents but expect the driver to be doing > std430 packing by default, just specify std430 packing. Reviewed-by: Dave Airlie ___ Piglit mailing

Re: [Piglit] Dumping render of a shader_test to PNG file

2019-06-26 Thread Ilia Mirkin
You can run anything that uses piglit-framework-gl with -png, which should produce a binname%d.png file containing the output. Probably best combined with -fbo -auto. e.g. bin/shader_runner tmp.shader_test -png -fbo -auto Writing shader_runner000.png... PIGLIT: {"result": "pass" } Cheers, -ili

[Piglit] Dumping render of a shader_test to PNG file

2019-06-26 Thread Abel Briggs
Hi, I was wondering if the idea of being able to dump the output of a shader_test to some kind of image file (maybe through a command in the [test] header) had ever come up before, and if so, whether it exists in piglit or not. I did some searching and I couldn't find any documentation about su

Re: [Piglit] [PATCH] ssbo: fix min/max tests to specify std430

2019-06-26 Thread Ian Romanick
Reviewed-by: Ian Romanick On 6/25/19 7:15 PM, Dave Airlie wrote: > From: Dave Airlie > > These tests preinit the ssbo contents but expect the driver to > be doing std430 packing by default, just specify std430 packing. > > This fixes the tests on softpipe > --- > .../execution/ssbo-atomicMax-

[Piglit] [PATCH] intel_shader_atomic_float_minmax: Explicitly request std430 layout

2019-06-26 Thread Ian Romanick
From: Ian Romanick These tests preinit the ssbo contents but expect the driver to be doing std430 packing by default, just specify std430 packing. Edits done by: grep -lr ' buffer ' tests/spec/intel_shader_atomic_float_minmax/execution |\ while read f; do sed --in-place -e 's/layout

Re: [Piglit] [PATCH] ssbo/shared: fix min/max tests to specify std430

2019-06-26 Thread Ian Romanick
Reviewed-by: Ian Romanick On 6/25/19 7:23 PM, Dave Airlie wrote: > From: Dave Airlie > > These tests preinit the ssbo contents but expect the driver to > be doing std430 packing by default, just specify std430 packing. > --- > .../execution/shared-atomicMax-int.shader_test | 2

Re: [Piglit] [PATCH] ssbo/shared: fix min/max tests to specify std430

2019-06-26 Thread apinheiro
Reviewed-by: Alejandro Piñeiro On 26/6/19 4:23, Dave Airlie wrote: From: Dave Airlie These tests preinit the ssbo contents but expect the driver to be doing std430 packing by default, just specify std430 packing. --- .../execution/shared-atomicMax-int.shader_test | 2 +- .

Re: [Piglit] [PATCH] ssbo: fix min/max tests to specify std430

2019-06-26 Thread apinheiro
Reviewed-by: Alejandro Piñeiro On 26/6/19 4:15, Dave Airlie wrote: From: Dave Airlie These tests preinit the ssbo contents but expect the driver to be doing std430 packing by default, just specify std430 packing. This fixes the tests on softpipe --- .../execution/ssbo-atomicMax-int.shader_