Re: [Piglit] [PATCH] ext_demote_to_helper_invocation: avoid requiring GL 4.5

On Wed, Oct 02, 2019 at 07:32:19PM -0400, Ilia Mirkin wrote: > The test doesn't really need GL 4.5, but *does* need the ext in question > to be supported. This change drops the requirement down to GL 3.3 + the > needed exts. > > Signed-off-by: Ilia Mirkin > --- >

Re: [Piglit] [PATCH 1/2] fbo: Silence compiler warnings about const mismatches

This and the other patch are Reviewed-by: Caio Marcelo de Oliveira Filho On Tue, Jan 22, 2019 at 01:33:10PM -0800, Ian Romanick wrote: > From: Ian Romanick > > tests/fbo/fbo-blending-format-quirks.c: In function ‘piglit_display’: > tests/fbo/fbo-blending-format-quirks.c:157

Re: [Piglit] [PATCH 0/5] modernize html

The series is Reviewed-by: Caio Marcelo de Oliveira Filho On Tue, Jan 22, 2019 at 11:41:06AM +0100, Erik Faye-Lund wrote: > It's been a while since XHTML was really a thing, so let's modernize our > HTML to follow HTML5 conventions. > > This series might not fix *everything*, mo

[Piglit] [PATCH] util: fix off-by-one when loading source

One extra character is leaking from the text into the copied line. The "+ 1" is an artifact from when malloc was used, strndup will add the extra '\0' after copying text_size bytes (if available). 7c8ee3f0f "util: simplify string duplication logic" --- tests/util/piglit-shader-test.c | 2 +- 1

Re: [Piglit] [PATCH crucible 2/2] Add test for VK_KHR_multiview

On Wed, Sep 26, 2018 at 12:01:49PM -0700, Caio Marcelo de Oliveira Filho wrote: > Uses the extension to write to two different layers of an image, then > merge those side-by-side in a final image. > --- > > This patch is available in my 'multiview' branch: > > https://g

[Piglit] [PATCH crucible 2/2] Add test for VK_KHR_multiview

Uses the extension to write to two different layers of an image, then merge those side-by-side in a final image. --- This patch is available in my 'multiview' branch: https://gitlab.freedesktop.org/cmarcelo/crucible/commits/multiview Makefile.am | 2 +

[Piglit] [PATCH crucible 1/2] framework: Add context to skip message in t_require_ext

Include the name of the missing extension as part of the message. --- This patch is available in my 'multiview' branch: https://gitlab.freedesktop.org/cmarcelo/crucible/commits/multiview src/framework/test/t_result.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH 1/2] sanity: Turn shader_test list into a string

> > -add_shader_test('tests/shaders/glsl-algebraic-add-zero.shader_test') > > -add_shader_test('tests/spec/glsl-1.50/execution/geometry-basic.shader_test') > > -add_shader_test('tests/spec/arb_tessellation_shader/execution/sanity.shader_test') > >

Re: [Piglit] [PATCH 1/2] sanity: Turn shader_test list into a string

On Fri, Sep 21, 2018 at 03:53:46PM -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > tests/sanity.py | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) Reviewed-by: Caio Marcelo de Oliveira Filho __

Re: [Piglit] [PATCH piglit] util: stop overallocating shader memory

On Thu, Aug 23, 2018 at 05:50:44PM +0100, Eric Engestrom wrote: > Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test files" > Cc: Alejandro Piñeiro > Signed-off-by: Eric Engestrom > --- > tests/util/piglit-shader-test.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Piglit] [PATCH piglit] util: stop overallocating shader memory

rintf(*output_source, line - first_line + 1, "%s", > first_line); > } Good catch. Reviewed-by: Caio Marcelo de Oliveira Filho ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH piglit] util: avoid leaking memory when caller doesn't ask for it

Thanks, Eric. This patch is Reviewed-by: Caio Marcelo de Oliveira Filho On Thu, Aug 23, 2018 at 03:23:55PM +0100, Eric Engestrom wrote: > It doesn't happen anywhere right now, but a caller could say it doesn't > want the source, only its size, and in that case we would just leak that &g

Re: [Piglit] [PATCH piglit 4/4] egl: fix uninitialised counter

+- > 1 file changed, 1 insertion(+), 1 deletion(-) Both this and the previous similar patch are Reviewed-by: Caio Marcelo de Oliveira Filho ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH piglit 2/4] util: fix memory leak

1 file changed, 1 insertion(+) This patch is Reviewed-by: Caio Marcelo de Oliveira Filho > diff --git a/tests/util/piglit-shader-test.c b/tests/util/piglit-shader-test.c > index 6aeb5a521a25b2d62301..4802983e56d1037be079 100644 > --- a/tests/util/piglit-shader-test.c > +++ b/tests/util

Re: [Piglit] [PATCH piglit 1/4] arb_gpu_shader5: fix memory leak

; .../execution/xfb-streams-without-invocations.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) This patch is Reviewed-by: Caio Marcelo de Oliveira Filho Thanks, Caio ___ Piglit mailing list Piglit@lists.freedesktop.or

[Piglit] [PATCH] tests/sanity: Add utf-8 encoding to file

Needed for the unicode (c) symbol. --- tests/sanity.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/sanity.py b/tests/sanity.py index 13f7859fb..928ba2423 100644 --- a/tests/sanity.py +++ b/tests/sanity.py @@ -1,3 +1,5 @@ +# coding: utf-8 + # Copyright © 2018 Intel Corporation