Reviewed-by: Chris Forbes
On Fri, May 30, 2014 at 2:56 PM, Ilia Mirkin wrote:
> Just ensures that without any MS set up, the coverage mask is 1.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> Silly test, but was enough for me to trace what the blob did with it. As th
The extension checks wouldn't have worked here; but may as well fix the
cases in output too.
Signed-off-by: Chris Forbes
---
tests/spec/arb_separate_shader_objects/ValidateProgramPipeline.c | 2 +-
tests/spec/arb_shader_atomic_counters/active-counters.c | 4 ++--
tests
For the series:
Reviewed-by: Chris Forbes
On Mon, Jun 2, 2014 at 12:39 PM, Jordan Justen
wrote:
> Signed-off-by: Jordan Justen
> ---
> Series available at 'cs' branch of:
> git://people.freedesktop.org/~jljusten/piglit
>
> tests/shaders/shader_runner.c | 12 +
Reviewed-by: Chris Forbes
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
It looks like nvidia just doesn't like redeclarations anywhere other
than global scope.
On Tue, Jun 3, 2014 at 7:55 PM, Jordan Justen wrote:
> On Fri, May 2, 2014 at 12:35 PM, Anuj Phogat wrote:
>> On Sat, Apr 26, 2014 at 9:04 PM, Chris Forbes wrote:
>>> Sign
, Jun 2, 2014 at 9:14 AM, Chris Forbes wrote:
> Reviewed-by: Chris Forbes
>
> On Fri, May 30, 2014 at 2:56 PM, Ilia Mirkin wrote:
>> Just ensures that without any MS set up, the coverage mask is 1.
>>
>> Signed-off-by: Ilia Mirkin
>> ---
>>
>> Silly
This seems needlessly complex with the FBO machinery. Presumably if
you just upload your solid red to the base level, (and something else
well-defined to the other levels, to avoid accidental passes if
glGenerateMipmap were broken completely) you can get rid of it all.
> + * FROM, OUT OF OR IN CON
Indeed, this was stricter than the spec requires.
Reviewed-by: Chris Forbes
On Sat, Jun 14, 2014 at 11:45 AM, Marek Olšák wrote:
> Cc'ing Chris.
>
> Marek
>
> On Sat, Jun 14, 2014 at 1:44 AM, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> Yes, the resul
s/Nvida/Nvidia/g in your commit messages
Otherwise, this series is
Reviewed-by: Chris Forbes
On Sun, Jun 15, 2014 at 12:38 AM, Timothy Arceri wrote:
> Test results are from the following hardware/driver combinations:
>
> AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3
> Nvidia
This isn't explicitly disallowed in the ARB_ubo spec or the GLSL
1.40 spec, but is very clear in the 1.50 spec. I believe this is a
clarification, not a change.
Signed-off-by: Chris Forbes
---
.../uniform_buffer/fs-struct-copy-complicated.shader_test | 12 +++-
.../glsl
This isn't explicitly disallowed in the ARB_ubo spec or the GLSL 1.40
spec, but is very clear in the 1.50 spec. I believe this is a
clarification, not a change.
Signed-off-by: Chris Forbes
---
.../spec/arb_uniform_buffer_object/layout-std140.c | 26 +-
1 file change
Interface blocks may contain instances of predeclared structs,
but not embedded definitions.
Signed-off-by: Chris Forbes
---
.../execution/interface-blocks-complex-vs-fs.shader_test | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git
a/tests/spec/glsl-1.50
These two are both:
Reviewed-by: Chris Forbes
On Tue, Jun 17, 2014 at 5:06 PM, Ilia Mirkin wrote:
> ---
>
> Not sure why this doesn't use the generic piglit functions for this, but this
> fixes log retrieval on nvidia blob.
>
> tests/spec/arb_shader_atomic_counters/comm
These are both
Reviewed-by: Chris Forbes
On Tue, Jun 17, 2014 at 5:52 PM, Ilia Mirkin wrote:
> ---
>
> Not actually an issue on the blob, since it supports ARB_geometry_shader4, but
> Chris Forbes pointed it out. This also works.
>
> tests/spec/arb_shader_atomic_counters/co
Ian,
That's true, but... we will probably have compute finished long before images.
Is there an acceptable thing to do here in the interim?
-- Chris
On Sat, Jun 21, 2014 at 1:07 PM, Ian Romanick wrote:
> On 06/19/2014 10:52 AM, Jordan Justen wrote:
>> Make sure ARB_shader_image_load_store is s
This allows attaching an entire 2darray texture as a layered
framebuffer.
Signed-off-by: Chris Forbes
---
tests/shaders/shader_runner.c | 28
1 file changed, 28 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 5fd76f2
Signed-off-by: Chris Forbes
---
tests/shaders/shader_runner.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 3a0ceda..4046a1e 100644
--- a/tests/shaders/shader_runner.c
+++ b/tests/shaders/shader_runner.c
er or gl_ViewportIndex is out of
range; we may or may not actually produce any FS invocations, but if we
do, the FS must see the bogus value the previous stage wrote. This is
currently mishandled by i965.
Signed-off-by: Chris Forbes
---
.../layer-gs-writes-in-range.shader_test
Signed-off-by: Chris Forbes
---
tests/all.py | 6 +++
.../layer-gs-no-write.shader_test | 51 ++
.../layer-no-gs.shader_test| 37
.../viewport-gs-no-write.shader_test
Reviewed-by: Chris Forbes
On Tue, Jun 24, 2014 at 7:18 AM, Ilia Mirkin wrote:
> On Mon, Jun 23, 2014 at 3:02 PM, Ian Romanick wrote:
>> On 06/23/2014 06:52 AM, Ilia Mirkin wrote:
>>> With no layered fb and unconfigured viewports, the values of
>>> gl_Layer/gl_Viewpor
Reviewed-by: Chris Forbes
On Wed, Jun 25, 2014 at 9:23 AM, Matt Turner wrote:
> ---
> tests/spec/arb_explicit_attrib_location/1.10/compiler/layout-12.frag | 2 +-
> tests/spec/arb_explicit_attrib_location/1.10/compiler/layout-13.frag | 2 +-
> 2 files changed, 2 insertions(+),
Reviewed-by: Chris Forbes
On Wed, Jun 25, 2014 at 2:32 PM, Ilia Mirkin wrote:
> With no layered fb and unconfigured viewports, the values of
> gl_Layer/gl_ViewportIndex shouldn't matter for rendering. Make sure that
> they're being passed through correctly from GS to FS. (Ou
Yes, you need the fence. Nothing needs to be done to sync the data,
but you must ensure that the GPU is finished working with the previous
contents of that memory before you clobber it.
On Tue, Jul 1, 2014 at 8:51 AM, Ilia Mirkin wrote:
> On Mon, Jun 30, 2014 at 4:44 PM, Ilia Mirkin wrote:
>> Si
The texture actually seems unnecessary -- are you using that to defeat
some optimization?
On Wed, Jul 2, 2014 at 9:28 AM, Cody Northrop wrote:
> On Tue, Jul 1, 2014 at 3:05 PM, Kenneth Graunke
> wrote:
>>
>> On Tuesday, July 01, 2014 12:53:18 PM Cody Northrop wrote:
>> > Add a test that ensures
Pick one of 1.40 and ARB_uniform_buffer_object -- you don't need both.
1.30+ARB_ubo would allow you to drop the GL version requirement down a
bit too.
Acked-by: Chris Forbes
On Wed, Jul 2, 2014 at 10:08 AM, Cody Northrop wrote:
> Yes, the texture sample is important. It may be affec
Need to actually ask for 1.20 in the 1.20 cases
On Sun, Jul 6, 2014 at 6:03 PM, Matt Turner wrote:
> The GLSL 1.10 tests currently fail (we accept floating-point suffixes
> regardless of language version).
> ---
> .../glsl-1.10/compiler/literals/invalid-float-suffix-F.vert| 10
> ++
glLinkProgram (re)sets all uniform block bindings to zero. If we want
to actually use multiple uniform blocks, we need to call
glUniformBlockBinding to specify which binding point goes with which
uniform block.
Signed-off-by: Chris Forbes
---
tests/shaders/shader_runner.c | 2 ++
1 file changed
This one needs to be asking for 1.20 too.
On Sun, Jul 6, 2014 at 6:03 PM, Matt Turner wrote:
> ---
> .../compiler/literals/valid-float-exponent-with-suffix.vert | 12
>
> 1 file changed, 12 insertions(+)
> create mode 100644
> tests/spec/glsl-1.20/compiler/literals/valid-float-e
Always nice to see more redundant glean stuff go away -- it's prone to
spurious failures with my WM.
For the series:
Reviewed-by: Chris Forbes
On Sun, Jul 6, 2014 at 6:03 PM, Matt Turner wrote:
> ---
> tests/spec/glsl-1.10/compiler/statements/empty-block.vert | 9 +
&g
These date back to a time before shader_runner was capable of testing
this case. Now redundant.
Signed-off-by: Chris Forbes
---
tests/all.py| 2 -
tests/shaders/CMakeLists.gl.txt | 2 -
tests/shaders/link-mismatch-layout-01.c | 96
This is an old test from before shader_runner could express multi-shader
cases, and a little broken.
Replace it with shader_tests which exercise the linker.
Signed-off-by: Chris Forbes
---
tests/all.py | 4 +-
tests/shaders/CMakeLists.gl.txt
Series is
Reviewed-by: Chris Forbes
On Tue, Jul 8, 2014 at 9:14 AM, Matt Turner wrote:
> ---
> tests/all.py | 2 --
> tests/glean/tglsl1.cpp | 24
> 2 files changed, 26 deletions(-)
>
> diff --git a/tests/all.py b/tests/all.py
> i
Brian,
I think the real answer here is "all of the above".
It seems reasonable that any of these extensions which introduce
specific layout qualifiers also cause layout() itself to exist. It
doesn't seem quite as reasonable for this to cause `out` to exist.
-- Chris
On Wed, Jul 9, 2014 at 3:54
---
tests/shaders/shader_runner.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index ed64b4e..2b5f10c 100644
--- a/tests/shaders/shader_runner.c
+++ b/tests/shaders/shader_runner.c
@@ -1335,7 +133
Signed-off-by: Chris Forbes
---
.../ubo_array_indexing/fs-array-const.shader_test | 63
.../fs-array-nonconst.shader_test | 68 +
.../ubo_array_indexing/fs-simple.shader_test | 58 +++
.../ubo_array_indexing/gs-array
---
tests/shaders/shader_runner.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 2b5f10c..f6761cd 100644
--- a/tests/shaders/shader_runner.c
+++ b/tests/shaders/shader_runner.c
@@ -2302,6 +2302,19 @@ piglit_dis
This ensures that the block index of the base of the array is correctly
taken into account, along with just being a little more stressful.
Signed-off-by: Chris Forbes
---
.../ubo_array_indexing/fs-two-arrays.shader_test | 200 +++
.../ubo_array_indexing/gs-two
Reviewed-by: Chris Forbes
On Fri, Jul 25, 2014 at 7:15 PM, Tapani Pälli wrote:
> This test is copy paste of fs-default_notlast.shader_test with
> the cases rearranged.
>
> Signed-off-by: Tapani Pälli
> ---
> .../execution/switch/fs-default_last.
This patch is:
Reviewed-by: Chris Forbes
and pushed.
On Tue, Jun 3, 2014 at 10:44 AM, Jordan Justen
wrote:
> Signed-off-by: Jordan Justen
> ---
> tests/all.py | 1 +
> tests/spec/CMakeLists.txt | 1 +
I haven't had time to examine your python changes in detail, but
patches 5, 9, 10, 13 (the ones that fix test headers) are:
Reviewed-by: Chris Forbes
On Tue, Jul 29, 2014 at 12:34 PM, Dylan Baker wrote:
> This currently uses 3 require extensions lines, this doesn't actually
>
Both block indices are dynamically uniform expressions (by virtue of
being uniforms) -- but only some invocations take each path.
Signed-off-by: Chris Forbes
---
.../ubo_array_indexing/fs-masked.shader_test | 66 ++
1 file changed, 66 insertions(+)
create mode 100644
Reviewed-by: Chris Forbes
On Sat, Aug 9, 2014 at 1:04 AM, Tapani Pälli wrote:
> Both of these tests are expected to fail as double cannot
> be used as vs input or fs output.
>
> v2: make sure we only fail because of wrong type
>
> Signed-off-by: Tapani Pälli
> ---
> ..
---
.../arb_shader_subroutine/preprocessor/define.vert| 19 +++
1 file changed, 19 insertions(+)
create mode 100644 tests/spec/arb_shader_subroutine/preprocessor/define.vert
diff --git a/tests/spec/arb_shader_subroutine/preprocessor/define.vert
b/tests/spec/arb_shader_subrou
Signed-off-by: Chris Forbes
---
tests/all.py | 9
tests/spec/CMakeLists.txt | 1 +
tests/spec/arb_shader_subroutine/CMakeLists.gl.txt | 12 +
tests/spec/arb_shader_subroutine/CMakeLists.txt| 1 +
tests/spec
Signed-off-by: Chris Forbes
---
.../compiler/subroutine-def-no-prototype.vert | 15 +++
1 file changed, 15 insertions(+)
create mode 100644
tests/spec/arb_shader_subroutine/compiler/subroutine-def-no-prototype.vert
diff --git
a/tests/spec/arb_shader_subroutine
Signed-off-by: Chris Forbes
---
.../compiler/multiple-subroutine-types.vert| 14 ++
1 file changed, 14 insertions(+)
create mode 100644
tests/spec/arb_shader_subroutine/compiler/multiple-subroutine-types.vert
diff --git
a/tests/spec/arb_shader_subroutine/compiler
Signed-off-by: Chris Forbes
---
.../arb_shader_subroutine/compiler/no-subroutine-var.vert | 14 ++
.../compiler/simple-subroutine-def.vert| 13 +
.../compiler/simple-subroutine-type-def.vert | 10 ++
.../compiler/simple
Signed-off-by: Chris Forbes
---
tests/spec/arb_shader_subroutine/compiler/keyword.vert | 13 +
1 file changed, 13 insertions(+)
create mode 100644 tests/spec/arb_shader_subroutine/compiler/keyword.vert
diff --git a/tests/spec/arb_shader_subroutine/compiler/keyword.vert
b/tests
Signed-off-by: Chris Forbes
---
.../linker/no-mutual-recursion.vert| 29 ++
.../linker/no-simple-recursion.vert| 23 +
2 files changed, 52 insertions(+)
create mode 100644
tests/spec/arb_shader_subroutine/linker/no-mutual
Signed-off-by: Chris Forbes
---
.../arb_shader_subroutine/linker/no-overloads.vert| 19 +++
.../linker/shared-namespace.vert | 16
2 files changed, 35 insertions(+)
create mode 100644 tests/spec/arb_shader_subroutine/linker/no
Signed-off-by: Chris Forbes
---
.../compiler/array-call-const-indexed.vert | 23 ++
.../array-call-dynamically-uniform-indexed.vert| 27 ++
.../compiler/call-param-mismatch.vert | 19 +++
.../compiler/direct-call.vert
Signed-off-by: Chris Forbes
---
.../compiler/subroutine-uniform-array.vert | 13 +
1 file changed, 13 insertions(+)
create mode 100644
tests/spec/arb_shader_subroutine/compiler/subroutine-uniform-array.vert
diff --git
a/tests/spec/arb_shader_subroutine/compiler
Signed-off-by: Chris Forbes
---
.../compiler/subroutine-param-type-mismatch.vert| 13 +
.../compiler/subroutine-return-type-mismatch.vert | 13 +
2 files changed, 26 insertions(+)
create mode 100644
tests/spec/arb_shader_subroutine/compiler
Signed-off-by: Chris Forbes
---
.../sampler_array_indexing/fs-simple.shader_test | 68 +
.../sampler_array_indexing/gs-simple.shader_test | 87 ++
.../sampler_array_indexing/vs-simple.shader_test | 80
3 files changed, 235 insertions
Signed-off-by: Chris Forbes
---
.../fs-nonzero-base.shader_test| 68 +
.../fs-weird-uniforms.shader_test | 69 +
.../fs-with-other.shader_test | 69 +
.../gs-nonzero-base.shader_test
Signed-off-by: Chris Forbes
---
.../compiler/subroutine-def-empty-type-list.vert | 19 +++
.../compiler/subroutine-def-not-identifier.vert | 11 +++
2 files changed, 30 insertions(+)
create mode 100644
tests/spec/arb_shader_subroutine/compiler/subroutine-def
Signed-off-by: Chris Forbes
---
.../compiler/subroutine-def-not-declared.vert | 11 +++
1 file changed, 11 insertions(+)
create mode 100644
tests/spec/arb_shader_subroutine/compiler/subroutine-def-not-declared.vert
diff --git
a/tests/spec/arb_shader_subroutine
Signed-off-by: Chris Forbes
---
tests/spec/arb_shader_subroutine/linker/no-overloads.vert | 2 ++
tests/spec/arb_shader_subroutine/linker/shared-namespace.vert | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tests/spec/arb_shader_subroutine/linker/no-overloads.vert
b/tests/spec
Bah, not sure what I was thinking. minmax for
GL_MAX_SUBROUTINE_UNIFORM_LOCATIONS is 1024, not 4096.
Will fix.
On Sun, Aug 10, 2014 at 11:06 PM, Chris Forbes wrote:
> Signed-off-by: Chris Forbes
> ---
> tests/all.py | 9
> tests/spec/CM
;
> +mat4 _mat4;
> +mat2x3 _mat2x3;
> +mat2x4 _mat2x4;
> +mat3x2 _mat3x2;
> +mat3x4 _mat3x4;
> +mat4x2 _mat4x2;
> +mat4x3 _mat4x3;
These probably should have initializers, since you read them. Not a
huge deal though.
With the tw
Reviewed-by: Chris Forbes
On Thu, Aug 14, 2014 at 5:56 PM, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin
> ---
> tests/all.py | 9 +++
> .../arb_derivative_control/compiler/define.frag| 29
> ++
>
Reviewed-by: Chris Forbes
On Thu, Aug 14, 2014 at 11:44 PM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> .../compiler/double-loop-iterator.vert | 22
> ++
> 1 file changed, 22 insertions(+)
> create mode 100644
> tests/spe
Should also have some positive cases to ensure that it does work at
the claimed maximum.
On Fri, Aug 15, 2014 at 10:28 AM, Timothy Arceri wrote:
> V2: changed to -> too
>
> Signed-off-by: Timothy Arceri
> ---
> tests/all.py| 1 +
> tests/spec/CMakeLists.txt
On Thu, Aug 21, 2014 at 12:36 AM, Tapani Pälli wrote:
> +++
> b/tests/spec/arb_gpu_shader_fp64/execution/built-in-functions/glsl-algebraic-div-double.shader_test
...
> + gl_FragColor = vec4(dvec4(1.0lf, 0.6lf, 1.0lf, 1.0lf) / dcolor);
...
> +uniform vec4 color 2.0 3.0 4.0 1.0
> +draw rect -
Both of these are
Reviewed-by: Chris Forbes
On Thu, Aug 21, 2014 at 2:34 PM, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin
> ---
>
> v1 -> v2:
> - added to all.py
> - removed checks for extensions in GL3
> - fixed comment about layer colors
> - removed glAct
With that fixed, does it pass on fglrx?
On Thu, Aug 21, 2014 at 4:16 PM, Tapani wrote:
> On 08/21/2014 05:26 AM, Chris Forbes wrote:
>>
>> On Thu, Aug 21, 2014 at 12:36 AM, Tapani Pälli
>> wrote:
>>>
>>> +++
>>> b/tests/spec/arb_gpu_shader_fp64
Signed-off-by: Chris Forbes
---
tests/spec/arb_texture_view/sampling-2d-array-as-cubemap-array.c | 2 +-
tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_texture_view/sampling-2d-array-as
From: Fabian Bieler
Reviewed-by: Chris Forbes
---
generated_tests/gen_builtin_uniform_tests.py | 129 ++-
1 file changed, 125 insertions(+), 4 deletions(-)
diff --git a/generated_tests/gen_builtin_uniform_tests.py
b/generated_tests/gen_builtin_uniform_tests.py
index
Previously this tried to assign vec4 to float, and would fail there
rather than testing anything useful.
Signed-off-by: Chris Forbes
---
tests/shaders/built-in-constants.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/shaders/built-in-constants.c
b/tests/shaders
gl_PerVertex.
Reviewed-by: Chris Forbes
---
generated_tests/CMakeLists.txt | 5 +
generated_tests/gen_tes_input_tests.py | 321 +
2 files changed, 326 insertions(+)
create mode 100644 generated_tests/gen_tes_input_tests.py
diff --git a/generated_tests
From: Fabian Bieler
Test declaring layout qualifiers in multiple shader objects and check for
linking arrays if qualifiers mismatch.
Reviewed-by: Chris Forbes
---
tests/all.py | 1 +
.../spec/arb_tessellation_shader/CMakeLists.gl.txt | 1 +
.../spec
From: Fabian Bieler
Test uniform arrays of maximal size as well as arrays of uniform blocks.
Also test for the required linking errors if too large uniform arrays are
requested.
Reviewed-by: Chris Forbes
---
tests/all.py | 1 +
.../spec
redundant with nop.shader_test, but the
approach in the tessellation evaluation shader is more normal (weighted
sum of vertices) so both are useful.
Reviewed-by: Chris Forbes
---
.../execution/sanity.shader_test | 55 ++
1 file changed, 55 insertions(+)
create
On Sun, Aug 24, 2014 at 4:38 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> This is a lot faster than RGBA FLOAT.
>
> There is a potential to speed up piglit by switching tests to ubyte
> r, rg, or rgba probing.
> ---
> tests/util/piglit-util-gl.c | 32
> tests/u
Either with or without the reduction in version requirements [to ~1.30
+ ARB_explicit_attrib_location + ARB_explicit_uniform_location] that
we discussed in IRC;
Reviewed-by: Chris Forbes
On Fri, Aug 22, 2014 at 5:04 PM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> Bugzilla:
We would like to be able to test this on 1.20+ARB_ubo as well. Unsigned
types are only present as of 1.30, so skip them if not available.
Signed-off-by: Chris Forbes
---
...getactiveuniformblockiv-uniform-block-data-size.c | 18 ++
.../getactiveuniformsiv-uniform-type.c
intended.
- Don't insist on an error when exceeding GL_MAX_UNIFORM_BLOCK_SIZE. The
spec doesn't require it to be emitted.
- Fetch max uniform block size before using it.
Signed-off-by: Chris Forbes
---
Various fixes for the `large-uniforms` test sent out a few days ago. Will
squash it
in
Signed-off-by: Chris Forbes
---
.../compiler/custom-in-length.tesc | 14 ++
.../compiler/custom-in-length.tese | 14 ++
.../compiler/custom-out-length-1.tesc| 16
.../compiler/custom-out
On Wed, Aug 27, 2014 at 12:16 AM, Ilia Mirkin wrote:
>> +/* Must not use gl_out.length() before it is established by the layout
>> declaration */
>> +
>> +int test[gl_out.length()];
>> +
>> +out (vertices = 3);
>
> I guess you meant
>
> layout (vertices = 3) out;
Yes -- not quite sure how that h
cessfully, when they should not.
On Thu, Aug 28, 2014 at 11:23 AM, Ian Romanick wrote:
> Have you tried these on any driver that supports the extension?
>
> On 08/10/2014 04:06 AM, Chris Forbes wrote:
>> Signed-off-by: Chris Forbes
>> ---
>> .../arb_shader_subrou
Reviewed-by: Chris Forbes
On Thu, Aug 28, 2014 at 12:27 PM, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin
> ---
>
> barrier-return/switch/func fail on NVIDIA 340.32 -- apparently it's
> perfectly happy with them, despite what the spec appears to say. That
> said, th
Would be nicer not to draw over itself -- if we need multiple
variants, they should be separate tests, or draw to non-overlapping
areas.
This + the communication via `patch out` variant discussed in IRC:
Reviewed-by: Chris Forbes
On Thu, Aug 28, 2014 at 2:35 PM, Ilia Mirkin wrote:
> Sig
Reviewed-by: Chris Forbes
On Thu, Aug 28, 2014 at 3:33 PM, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin
> ---
>
> v1 -> v2:
> - use passthrough vertex shader where possible
> - add a test without tcs
>
> These all pass on nvidia blob
>
> .../ex
Reviewed-by: Chris Forbes
You might also want some for 420pack-style initializers, since we
support that everywhere we'll support doubles.
On Tue, Sep 2, 2014 at 11:57 PM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> .../glsl-uniform-initializer-1.shader_tes
3.0 works for me.
On Wed, Sep 3, 2014 at 5:48 PM, Tapani Pälli wrote:
> On 09/03/2014 08:41 AM, Matt Turner wrote:
>> On Tue, Sep 2, 2014 at 10:00 PM, Tapani Pälli wrote:
>>> On 09/03/2014 01:07 AM, Matt Turner wrote:
On Tue, Sep 2, 2014 at 1:32 AM, Tapani Pälli
wrote:
> Signed-o
With these fixed, plus the [require] section fixed as per Matt's first comment,
Reviewed-by: Chris Forbes
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Chris Forbes
On Tue, Sep 9, 2014 at 5:06 PM, Dylan Baker wrote:
> This test takes an argument that is not a path, and this path is
> provided as a relative one. This works fine if piglit is run from the
> piglit git tree root dir, but if the piglit is installed or run out
Yep,
Reviewed-by: Chris Forbes
On Sat, Sep 13, 2014 at 3:03 AM, Timothy Arceri wrote:
> Hey guys,
>
> Are you happy enough with this version to give a rb I'd like to commit
> this now that the Mesa changes are in.
>
> Thanks,
> Tim
>
> On Fri, 2014-08-15 at 1
Reviewed-by: Chris Forbes
On Sep 11, 2014 10:17 AM, "Ian Romanick" wrote:
> These are all tests derived from failing tests generated by my test
> generator. These all have associated bugs.
>
> ___
> Piglit mailing list
>
Are you sure?
Previously, if the data had been stored in the wrong orientation, you
should have got (0.25, 0.75, 0.5, 1) due to the 0.5 and 0.75 being off
the diagonal.
(Or I've completely misunderstood something...)
On Tue, Sep 9, 2014 at 9:34 AM, Ian Romanick wrote:
> From: Ian Romanick
>
>
Signed-off-by: Chris Forbes
---
tests/spec/arb_gpu_shader5/linker/tf-wrong-stream-value.c | 4
1 file changed, 4 deletions(-)
diff --git a/tests/spec/arb_gpu_shader5/linker/tf-wrong-stream-value.c
b/tests/spec/arb_gpu_shader5/linker/tf-wrong-stream-value.c
index afc79ad..4d098c7 100644
is spurious but harmless.
Series is:
Reviewed-by: Chris Forbes
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
From: Fabian Bieler
Test uniform arrays of maximal size as well as arrays of uniform blocks.
Also test for the required linking errors if too large uniform arrays are
requested.
---
tests/all.py | 1 +
.../spec/arb_tessellation_shader/CMakeLists.gl.txt |
From: Fabian Bieler
For every GLSL variable type, generate four tests. One passes a per-vertex
and one a per-patch varying of said type as a scalar from the tessellation
control to the tessellation evaluation shader. The two other tests do the same
for a two-element array of that type.
The varyi
From: Fabian Bieler
---
generated_tests/gen_builtin_uniform_tests.py | 129 ++-
1 file changed, 125 insertions(+), 4 deletions(-)
diff --git a/generated_tests/gen_builtin_uniform_tests.py
b/generated_tests/gen_builtin_uniform_tests.py
index 7edd5cc..b8eceed 100644
--- a
Previously this tried to assign vec4 to float, and would fail there
rather than testing anything useful.
Signed-off-by: Chris Forbes
---
tests/shaders/built-in-constants.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/shaders/built-in-constants.c
b/tests/shaders
Signed-off-by: Chris Forbes
---
.../compiler/input-block-must-be-array-unnamed.tesc | 16
.../compiler/input-block-must-be-array-unnamed.tese | 16
.../compiler/input-block-must-be-array.tesc | 14 ++
.../compiler/input-block
From: Fabian Bieler
Test declaring layout qualifiers in multiple shader objects and check for
linking arrays if qualifiers mismatch.
---
tests/all.py | 1 +
.../spec/arb_tessellation_shader/CMakeLists.gl.txt | 1 +
.../spec/arb_tessellation_shader/layout
for every GLSL variable type, generate two tests. One passes a varying of said
type as a scalar from the vertex to the tessellation control shader and one
that passes a two-element array.
Fill the varying in the vertex shader from a uniform and compare
it against the uniform in the tessellation con
nop.shader_test, but the
approach in the tessellation evaluation shader is more normal (weighted
sum of vertices) so both are useful.
Reviewed-by: Chris Forbes
---
.../execution/sanity.shader_test | 55 ++
1 file changed, 55 insertions(+)
create mode 100644
tests/spec
1 - 100 of 380 matches
Mail list logo
