Re: [Piglit] [PATCH v5] CMake: define GBM_BO_MAP only when symbol is found

2017-06-07 Thread Daniel Díaz Rodríguez
Ping. -- ddiaz On 30 May 2017 at 12:52, Dylan Baker wrote: > Quoting Daniel Díaz (2017-05-16 17:06:40) >> gbm_bo_map() and _unmap() have been added recently to Mesa, >> and this update may not have reached all implementations of >> GBM, such as the one provided by Mali r6, where said >> defini

Re: [Piglit] [PATCH v5] CMake: define GBM_BO_MAP only when symbol is found

2017-05-29 Thread Daniel Díaz Rodríguez
Ping. -- ddiaz On 16 May 2017 at 19:06, Daniel Díaz wrote: > gbm_bo_map() and _unmap() have been added recently to Mesa, > and this update may not have reached all implementations of > GBM, such as the one provided by Mali r6, where said > definitions can be found in the header file but not i

Re: [Piglit] [PATCH v2] CMake: define GBM_BO_MAP only when symbol is found

2017-05-15 Thread Daniel Díaz Rodríguez
Hello! On 15 May 2017 at 15:05, Dylan Baker wrote: > GBM_HEADERS is undefined on my system with mesa 17.0.5. Thanks for giving it a go. It failed to find gbm_bo_map (as expected) on my system, but for the wrong reason (GBM_HEADERS being undefined). I have tried a few variations around CHECK_SY

Re: [Piglit] [PATCH] CMake: define GBM_BO_MAP only when symbol is found

2017-05-15 Thread Daniel Díaz Rodríguez
Hello! On 11 May 2017 at 14:56, Jan Vesely wrote: > wouldn't it be cleaner to use CheckSymbolExists(gbm_bo_map GBM_HEADERS > PIGLIT_HAS_GBM_BO_MAP) > instead of the autostyle detection? Thanks for the suggestion. That didn't work for me in a previous attempt (with the wrong headers, apparently)