[Piglit] [PATCH] arb_get_texture_sub_image-errors: Fix expected error values

glGetTextureSubImage() and glGetCompressedTextureSubImage() return GL_INVALID_VALUE instead of GL_INVALID_OPERATION when the 'texture' argument does not correspond to an existing texture object. From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236: "An INVALID_VALUE error is ge

Re: [Piglit] [PATCH v2 1/2] Test multiple inout parameters with indirect array indexing

void main() > +{ > + gl_FragColor = color; > +} > + > +[test] > +draw rect -1 -1 2 2 > +probe all rgb 0. 1. 0. Since you are explicitly assigning the w component of 'color', you should also probe it: probe all rgba 0. 1. 0. 1. The same comment applies to the rest of

Re: [Piglit] [PATCH 1/2] builtin_function*py: Corrected single to double conversions

Both patches are: Reviewed-by: Eduardo Lima Mitev Thanks! On 05/04/2016 07:02 PM, Andres Gomez wrote: > Calculation of the tolerance in single precision with very high > numbers was giving "inf" results while it was possible to calculate in > double precision and round back

Re: [Piglit] [PATCH] EGL_KHR_cl_event2: Clean up gl_extensions array from test_cleanup()

Patch looks good, but I was not able to test it fully. Acked-by: Eduardo Lima Mitev Eduardo On 05/12/2016 09:21 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes a crash with multiple OpenCL devices available, due to re-using > the stale gl_extensions array from a previous

Re: [Piglit] [PATCH v2] arb_shader_storage_buffer_object: memory qualifier tests for named blocks

Hi Ilia, Are you ok with the test split I did in v2? Thanks, Eduardo On 05/06/2016 08:29 AM, Eduardo Lima Mitev wrote: > There are missing tests to check for readonly and writeonly memory qualifiers > on a named interface block. And Mesa is actually failing to apply these > qualifiers

[Piglit] [PATCH v2] arb_shader_storage_buffer_object: memory qualifier tests for named blocks

There are missing tests to check for readonly and writeonly memory qualifiers on a named interface block. And Mesa is actually failing to apply these qualifiers right now. v2: (Ilia Mirkin) Put each test case into its own shader file. --- .../named-block-memory-qualifier-readonly-member.vert

[Piglit] [PATCH] arb_shader_storage_buffer_object: More readonly/writeonly qualifier tests

There are missing tests to check for readonly and writeonly memory qualifiers on a named interface block. And Mesa is actually failing to apply these qualifiers right now. --- .../compiler/block-memory-qualifier-readonly.vert| 20 .../compiler/block-memory-qualifier-writeo

Re: [Piglit] [PATCH] arb_internalformat_query2: use PRIi64 instead of PRIu64 macro

Looks good. Reviewed-by: Eduardo Lima Mitev Thanks! On 05/02/2016 02:50 PM, Alejandro Piñeiro wrote: > As all the values we are printing are 64 bit integers, not unsigned integers. > > In general this is not relevant, as no query for a supported combination > of pnam

Re: [Piglit] [PATCH] Add a test that reproduces a problem in GLideN64.

Confirmed it crashes without your 2-patch series in Mesa, and passes with it. Test looks good. Reviewed-by: Eduardo Lima Mitev On 04/29/2016 09:23 AM, Kenneth Graunke wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95164 > --- > .../compiler/vector-deref

Re: [Piglit] [PATCH] aa: too sensitive at the line end points for PNV platform

On 11/09/2015 07:28 PM, Predut, Marius wrote: > I confirm that not piglit regression. > Pushed to piglit master. Thanks! Eduardo > > -Original Message- > From: Piglit [mailto:piglit-boun...@lists.freedesktop.org] On Behalf Of > Eduardo Lima Mitev > Sent: Thursda

Re: [Piglit] [PATCH v2] ext_texture_format_bgra8888: Add test for GL_BGRA format API errors in Tex(Sub)Image

Hi, Just a heads-up that I'm planning to merge this patch tomorrow. I have renamed the test to api-errors.c, as Jason asked for his R-b, and also addressed all suggestions made by Emil. Eduardo On 10/16/2015 07:02 PM, Eduardo Lima Mitev wrote: > This is a new test that checks valid and

[Piglit] [PATCH v2] ext_texture_format_bgra8888: Add test for GL_BGRA format API errors in Tex(Sub)Image

This is a new test that checks valid and invalid combinations of GL_BGRA_EXT format and internal format in Tex(Sub)Image2D calls, as specified by the EXT_texture_format_BGRA extension. Although the test is very basic and doesn't really render anything or check pixels, it would have prevented t

Re: [Piglit] [PATCH] ext_texture_format_bgra8888: Add test for GL_BGRA format in Tex(Sub)Image calls

On 10/15/2015 05:10 PM, Jason Ekstrand wrote: > On Wed, Oct 14, 2015 at 6:50 PM, Eduardo Lima Mitev wrote: >> This is a new test that checks valid and invalid combinations of GL_BGRA_EXT >> format and internal format in Tex(Sub)Image2D calls, as specified by the >> EXT_te

Re: [Piglit] [PATCH] ext_texture_format_bgra8888: Add test for GL_BGRA format in Tex(Sub)Image calls

Hi Emil, I will update the test to address all your suggestions. I left some comments inline. On 10/15/2015 07:25 PM, Emil Velikov wrote: > Hi Eduardo, > > A few humble suggestions. > > On 15 October 2015 at 02:50, Eduardo Lima Mitev wrote: >> This is a new test that che

[Piglit] [PATCH] ext_texture_format_bgra8888: Add test for GL_BGRA format in Tex(Sub)Image calls

This is a new test that checks valid and invalid combinations of GL_BGRA_EXT format and internal format in Tex(Sub)Image2D calls, as specified by the EXT_texture_format_BGRA extension . Bugzilla: https://bugs

Re: [Piglit] [PATCH] aa: too sensitive at the line end points for PNV platform

till passes after applying this (and before having the fix in mesa). If you can confirm it does, then it is no risk to push this already. Eduardo >> -Original Message- >> From: Piglit [mailto:piglit-boun...@lists.freedesktop.org] On Behalf Of >> Eduardo Lima Mitev >&

Re: [Piglit] [PATCH] aa: too sensitive at the line end points for PNV platform

s to sample because we've >* hit the edge of the window, we're done. > -- > 1.9.1 > Looks fine, though I don't have available HW to confirm the test passes after applying corresponding Mesa patch. If somebody can confirm it, this patch is: Reviewed-By: Eduardo Lima Mitev ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] clearbuffer-invalid-drawbuffer: Fix test cases calling glClearBufferiv with depth buffers

Page 262 of the PDF, section '4.2.3 Clearing the Buffers' of the OpenGL 3.0 spec states: "Only ClearBufferfv should be used to clear depth buffers." And in the Errors definition of the same section (page 263 of the PDF): "ClearBuffer generates an INVALID ENUM error if buffer does not

Re: [Piglit] [Mesa-dev] [PATCH] arb_occlusion_query2: expect an error when target mismatch in glBeginQuery()

On 02/18/2015 11:15 PM, Mark Janes wrote: > Hi Eduardo, > > I track piglit regressions for the mesa team at Intel. It would really > help me if you put a note in your commit message when a new test is > known to fail on any platform. > Hi Mark, Ok, I will have that into account for the future.

[Piglit] [PATCH 2/2] arb_occlusion_query2: Checks that query obj passed to glBeginQuery matches target

From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94: "[...] if id is the name of an existing query object whose type does not match target, [...] the error INVALID_OPERATION is generated." Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13. ASYNCHRONOUS

[Piglit] [PATCH 1/2] arb_occlusion_query2: expect an error when target mismatch in glBeginQuery()

From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94: "[...] if id is the name of an existing query object whose type does not match target, [...] the error INVALID_OPERATION is generated." Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13. ASYNCHRONOUS

Re: [Piglit] [Mesa-dev] [PATCH 0/2] arb_occlusion_query2: expect an error when target mismatch in glBeginQuery()

fails the check introduced in patch 02; so NVidia driver is not doing what the specs says. I will report the issue directly to the NVidia Linux driver team. Thanks a lot for the feedback! Eduardo Eduardo Lima Mitev (2): arb_occlusion_query2: expect an error when target mismatch in

Re: [Piglit] [Mesa-dev] [PATCH] arb_occlusion_query2: expect an error when target mismatch in glBeginQuery()

On 02/11/2015 12:28 AM, Emil Velikov wrote: > I'm guessing that this was meant for the piglit ML - Cc-ing it :) > Oh, sorry for the mistake and thank you Emil! cheers, Eduardo ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedeskt