Re: [Piglit] [PATCH 2/2] arb_texture_view: Add rendering test for layout consistency

2014-03-26 Thread Jon Ashburn
AM, Jon Ashburn j...@lunarg.com wrote: +void +piglit_init(int argc, char **argv) +{ + piglit_require_extension(GL_ARB_texture_view); also require texture_storage. I disagree, actually -- an implementation that exposes ARB_texture_view without 4.2/ARB_texture_storage is broken, and so we'd

[Piglit] [PATCH 1/2 v3] getteximage-targets: Refactor and cleanup with generalized texture targets

2014-03-25 Thread Jon Ashburn
--- tests/texturing/getteximage-targets.c | 228 -- 1 file changed, 132 insertions(+), 96 deletions(-) diff --git a/tests/texturing/getteximage-targets.c b/tests/texturing/getteximage-targets.c index 383ee03..df8a726 100644 ---

[Piglit] [PATCH 2/2 v3] getteximage-targets: Add read texture image into PBO case for each target

2014-03-25 Thread Jon Ashburn
--- tests/texturing/getteximage-targets.c | 46 ++- 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/tests/texturing/getteximage-targets.c b/tests/texturing/getteximage-targets.c index df8a726..3017226 100644 ---

Re: [Piglit] [PATCH 1/2] arb_texture_view: add test for layout consistency via GetTexImage

2014-03-25 Thread Jon Ashburn
On 03/19/2014 03:17 AM, Chris Forbes wrote: Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.py | 1 + tests/spec/arb_texture_view/CMakeLists.gl.txt | 1 + .../spec/arb_texture_view/format-consistency-get.c | 136 +

Re: [Piglit] [PATCH 2/2] arb_texture_view: Add rendering test for layout consistency

2014-03-25 Thread Jon Ashburn
On 03/19/2014 03:17 AM, Chris Forbes wrote: Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.py | 1 + tests/spec/arb_texture_view/CMakeLists.gl.txt | 1 + .../arb_texture_view/format-consistency-render.c | 164 +

Re: [Piglit] [PATCH] arb_texture_view: add test for glCopyTexSubImage with MinLayer

2014-03-21 Thread Jon Ashburn
, + 0, 0, i, TEX_SIZE, TEX_SIZE, 1, + expected_color) pass; + } + + piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL); +} With these changes Reviewed-by: Jon Ashburn j...@lunarg.com

[Piglit] [PATCH 1/2 v2] getteximage-targets: Refactor and cleanup with generalized texture targets

2014-03-21 Thread Jon Ashburn
--- tests/texturing/getteximage-targets.c | 225 +++--- 1 file changed, 127 insertions(+), 98 deletions(-) diff --git a/tests/texturing/getteximage-targets.c b/tests/texturing/getteximage-targets.c index 383ee03..1b626db 100644 ---

[Piglit] [PATCH] Add test case for existing test getteximage-targets of reading into a PBO.

2014-03-03 Thread Jon Ashburn
Initial test always used glGetTexImage into client memory for the various texture targets. Add case of reading into PBO in addition to client memory. --- tests/texturing/getteximage-targets.c | 334 -- 1 file changed, 242 insertions(+), 92 deletions(-) diff

Re: [Piglit] [PATCH] arb_texture_view-targets: Silence uninitialized variable warning.

2014-01-27 Thread Jon Ashburn
Looks fine. Reviewed-by: Jon Ashburn j...@lunarg.com On 1/25/14, 12:32 AM, Vinson Lee wrote: This patch fixes this GCC maybe-uninitialized warning. targets.c: In function 'test_target_errors': targets.c:198:35: warning: 'numTargets' may be used uninitialized in this function [-Wmaybe

[Piglit] [PATCH 1/2] arb_viewport_array: Test glScissor indexed ignore invalid width/height

2014-01-23 Thread Jon Ashburn
. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Verify that calling glScissorArrayv, glScissorIndexed, or glScissorIndexedv + * with an invalid width (or height) in elements after the first generates + * a GL error and does not modify any of the scissor rectangles. + */ +#include piglit-util

[Piglit] [PATCH 2/2] arb_viewport_array: Test glViewport indexed ignores invalid width/height

2014-01-23 Thread Jon Ashburn
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Verify that calling glViewportArrayv, glViewportIndexed, or glViewportIndexedv

Re: [Piglit] [PATCH 1/2] util: add piglit_probe_texel_volume_rgba()

2014-01-22 Thread Jon Ashburn
Add error check for malloc() failure then it looks good. Reviewed-by: Jon Ashburn j...@lunarg.com On 01/18/2014 11:51 PM, Chris Forbes wrote: This is similar to piglit_probe_texel_rect_rgba except it allows for probing a subvolume of a 3D texture, or slices of a 2D array texture. Signed-off

Re: [Piglit] [PATCH 2/2] arb_texture_view: Test uploading into a view with nonzero MinLayer

2014-01-22 Thread Jon Ashburn
see inline On 01/18/2014 11:51 PM, Chris Forbes wrote: Tests that the correct layers of a 2D array texture are overwritten when uploading through a view. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.py | 1 +

Re: [Piglit] [PATCH] arb_texture_view: Test uploading into a view with nonzero MinLevel

2014-01-22 Thread Jon Ashburn
On 01/20/2014 01:15 AM, Chris Forbes wrote: The calculation of color_index isn't correct as sent -- inside the view range it should be i + NUM_LEVELS - VIEW_MIN_LEVEL. Similar fix applies to the layers test. On Sun, Jan 19, 2014 at 4:32 PM, Chris Forbes chr...@ijw.co.nz wrote: Tests that the

Re: [Piglit] [PATCH 2/4] arb_texture_view: Constrain accessible mip levels correctly

2014-01-14 Thread Jon Ashburn
. It's possible that I've misunderstood what you were trying to do though and destroyed the essence of it. What do you think? On Tue, Jan 14, 2014 at 1:58 PM, Jon Ashburn j...@lunarg.com wrote: Hey Chris: I think the texture level used should be clamped when using immutable texture so

Re: [Piglit] [PATCH 3/4] arb_texture_view: Pass correct layer index to shader

2014-01-14 Thread Jon Ashburn
see inline On 01/11/2014 05:39 PM, Chris Forbes wrote: We want to sample from the last layer in the view, but we were actually trying to sample from a layer beyond that [by the texture's minimum layer]. This might have worked on hardware where the sampler clamps the layer index before sampling

Re: [Piglit] [PATCH 4/4] arb_texture_view: Fill 2D array texture properly

2014-01-14 Thread Jon Ashburn
Looks good to me Reviewed-by: Jon Ashburn j...@lunarg.com On 01/11/2014 05:39 PM, Chris Forbes wrote: The depth only varies by miplevel for volume textures -- all miplevels have the same number of layers for an array texture. Previously we would fail to fill all but the first layers

Re: [Piglit] [PATCH 2/4] arb_viewport_array: Move error detection closer to the causes

2014-01-14 Thread Jon Ashburn
These two patches regarding arb_viewport_array look good to me. Reviewed-by: Jon Ashburn j...@lunarg.com On 01/10/2014 03:05 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com This made it a bit easier to notice which cases were actually failing. Signed-off-by: Ian Romanick

Re: [Piglit] [PATCH 3/4] arb_texture_view: Pass correct layer index to shader

2014-01-14 Thread Jon Ashburn
on master? On Wed, Jan 15, 2014 at 5:36 AM, Jon Ashburn j...@lunarg.com wrote: see inline On 01/11/2014 05:39 PM, Chris Forbes wrote: We want to sample from the last layer in the view, but we were actually trying to sample from a layer beyond that [by the texture's minimum layer]. This might

Re: [Piglit] [PATCH 1/4] arb_texture_view: Don't claim core profile support for rendering tests

2014-01-13 Thread Jon Ashburn
Looks good to me. Reviewed-by: Jon Ashburn j...@lunarg.com On 01/11/2014 05:39 PM, Chris Forbes wrote: These aren't core-profile-clean. They don't bother to set up a VAO, and rendering_levels tests some fixed-function behavior. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/spec

Re: [Piglit] [PATCH 2/4] arb_texture_view: Constrain accessible mip levels correctly

2014-01-13 Thread Jon Ashburn
Hey Chris: I think the texture level used should be clamped when using immutable texture so if the MAX_LEVEL is out of range it shouldn't matter. Also an unset BASE_LEVEL should default to 0 which is relative to the view. From arb_texture_storage: Redefine level_base, level_max to be

Re: [Piglit] [PATCH] ARB_texture_view: Add format test case for formats not in VIEW_CLASS table

2013-12-02 Thread Jon Ashburn
Can anyone review this patch from a week ago? Thanks, Jon Ashburn On 11/25/13, 5:43 PM, Jon Ashburn wrote: Add test case for this sentence in the extension registry spec for ARB_texture_view, that involves identical formats: The two textures' internal formats must be compatible according

Re: [Piglit] [PATCH] arb_viewport_array: Only specify 150 for shader version

2013-11-26 Thread Jon Ashburn
These changes pass on Nvidia Quadro 600 with this driver: 4.3.0 NVIDIA 313.30 Regards, Jon Ashburn On 11/26/2013 09:57 AM, Jordan Justen wrote: tests/spec/arb_viewport_array/render_depthrange.c | 8 +--- tests/spec/arb_viewport_array/render_scissor.c| 7 --- tests/spec

[Piglit] [PATCH] ARB_texture_view: Add format test case for formats not in VIEW_CLASS table

2013-11-25 Thread Jon Ashburn
Add test case for this sentence in the extension registry spec for ARB_texture_view, that involves identical formats: The two textures' internal formats must be compatible according to Table 3.X.2 ... the internal formats must be identical if not in that table, or else an INVALID_OPERATION error

[Piglit] [PATCH v2] ARB_texture_view: Add multisample texture target testing

2013-11-12 Thread Jon Ashburn
-by: Jon Ashburn j...@lunarg.com --- tests/spec/arb_texture_view/targets.c | 53 +++ 1 file changed, 41 insertions(+), 12 deletions(-) diff --git a/tests/spec/arb_texture_view/targets.c b/tests/spec/arb_texture_view/targets.c index 2c2e5c5..b000751 100644

[Piglit] [PATCH] ARB_texture_view: Add multisample texture target testing

2013-11-08 Thread Jon Ashburn
The targets test is extended to include testing of GL_TEXTURE_2D_MULTISAMPLE and GL_TEXTURE_2D_MULTISAMPLE_ARRAY. This will test making valid and invalid texture views of these two multisample targets and ensuring the correct GL error is set. --- tests/spec/arb_texture_view/targets.c | 28

[Piglit] [PATCH 9/9 v2] ARB_viewport_array: Rendering test with multiple scissor rectangles/enables

2013-11-04 Thread Jon Ashburn
indexed scissor tests and indexed scissor enables are used. Geometry shader is used to expand a single rectangle primitve to N rectangles. Tested on Nvidia Quadro 600, test passes. Signed-off-by: Jon Ashburn j...@lunarg.com --- tests/all.tests | 1 + tests/spec

Re: [Piglit] [PATCHES] arb_viewport_array

2013-11-01 Thread Jon Ashburn
review (Brian Paul review signed off) so only plan to resend for person pushing to master. Jon Ashburn ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 3/4] ARB_viewport_array: Validity test for scissor index related params

2013-11-01 Thread Jon Ashburn
cases pass except for invalid indices with glIsEnabledi(GL_SCISSOR_TEST,...). Signed-off-by: Jon Ashburn j...@lunarg.com --- tests/all.tests | 1 + tests/spec/arb_viewport_array/CMakeLists.gl.txt | 1 + tests/spec/arb_viewport_array/scissor_indices.c | 157

[Piglit] [PATCH 2/4] ARB_viewport_array: Validity test for depth range index/first/count params

2013-11-01 Thread Jon Ashburn
Tests GL_ARB_viewport_array validity for indices. Use both valid and invalid parameters (index, first, count) for all these new API entry points: glDepthRangeArrayv, glDepthRangeIndexed, glGetDoublei_v. Tested on Nvidia Quadro 600 all tests pass. Signed-off-by: Jon Ashburn j...@lunarg.com

[Piglit] [PATCH 4/4] ARB_viewport_array: Test validity of bounds for viewport, depthRange, scissor

2013-11-01 Thread Jon Ashburn
height fails to return a gl error. Reviewed-by: Brian Paul bri...@vmware.com Signed-off-by: Jon Ashburn j...@lunarg.com --- tests/all.tests | 1 + tests/spec/arb_viewport_array/CMakeLists.gl.txt | 1 + tests/spec/arb_viewport_array/bounds.c | 270

[Piglit] [PATCH 1/4] ARB_viewport_array: Validity test for viewport index/first/count params

2013-11-01 Thread Jon Ashburn
for Viewport, DepthRange, Scissor Box, Scissor Test does not modify any of the state for the valid range of indices. Tested on Nvidia Quadro 600 all tests pass. Signed-off-by: Jon Ashburn j...@lunarg.com --- tests/all.tests | 4 + tests/spec/CMakeLists.txt

Re: [Piglit] [PATCH 1/9] ARB_viewport_array: Validity test for viewport index/first/count params

2013-10-31 Thread Jon Ashburn
On 10/29/2013 05:47 PM, Brian Paul wrote: On 10/29/2013 03:55 PM, Jon Ashburn wrote: Tests GL_ARB_viewport_array regarding the validity for the indices. Use both valid and invalid parameters (index, first, count) for these new API entry points: glViewportArrayv, glViewportIndexedf

Re: [Piglit] [PATCH 5/9] ARB_viewport_array: Test validity for glGetFloati_v and glGetDoublei_v

2013-10-31 Thread Jon Ashburn
On 10/29/2013 05:47 PM, Brian Paul wrote: On 10/29/2013 03:55 PM, Jon Ashburn wrote: Test valid and invalid queries using glGetFLoati_v and glGetDoublei_v. Also test correct queries of GL_SCISSOR_TEST default value and settable values. Tested on Nvidia Quadro 600 and all tests pass

Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-29 Thread Jon Ashburn
also make the test independent of window size (except really tiny windows). Jon On 10/29/2013 12:24 PM, Jordan Justen wrote: On Fri, Oct 25, 2013 at 9:41 AM, Jon Ashburn j...@lunarg.com wrote: RE your comment: +config.window_width = 128; +config.window_height = 128; Is 128 special

[Piglit] [PATCH 2/9] ARB_viewport_array: Validity test for depth range index/first/count params

2013-10-29 Thread Jon Ashburn
+ * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests GL_ARB_viewport_array validity for indices. + * Use both valid and invalid parameters (index, first, count) + * for all these new API entry points: + * glDepthRangeArrayv, glDepthRangeIndexed, glGetDoublei_v

[Piglit] [PATCH 4/9] ARB_viewport_array: Test validity of bounds for viewport, depthRange, scissor

2013-10-29 Thread Jon Ashburn
+ * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests for the validity of Viewport bounds, Depth Range bounds and + * Scissor Box bounds with viewport arrays (0 to GL_MAX_VIEWPORTS-1). + * Viewport bounds are x, y, width, height. + * Depth Range bounds are near, far. + * Scissor Box

[Piglit] [PATCH 3/9] ARB_viewport_array: Validity test for scissor index related params

2013-10-29 Thread Jon Ashburn
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests

[Piglit] [PATCH 5/9] ARB_viewport_array: Test validity for glGetFloati_v and glGetDoublei_v

2013-10-29 Thread Jon Ashburn
OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ +/** + * Test valid and invalid queries using glGetFloati_v

[Piglit] [PATCH 6/9] ARB_viewport_array: Test min/max values for new implementation constants

2013-10-29 Thread Jon Ashburn
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** @file minmax.c + * + * Test for the minimum maximum values listed in section 23 State Tables

[Piglit] [PATCH 9/9] ARB_viewport_array: Rendering test with multiple scissor rectangles/enables

2013-10-29 Thread Jon Ashburn
, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests rendering into a single framebuffer surface

[Piglit] [PATCH 1/9] ARB_viewport_array: Validity test for viewport index/first/count params

2013-10-29 Thread Jon Ashburn
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests GL_ARB_viewport_array regarding the validity for the indices. + * Use both valid

[Piglit] [PATCH 8/9] ARB_viewport_array: Rendering test with multiple depthranges

2013-10-29 Thread Jon Ashburn
OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Draws quads into a single framebuffer surface with multiple viewports + * via a geometry shader. Each different viewport has a different DepthRange

[Piglit] [PATCH 7/9] ARB_viewport_array: Rendering test with multiple viewports

2013-10-29 Thread Jon Ashburn
. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn

[Piglit] [PATCH 3/7] ARB_texture_view: Test valid and invalid targets for TextureView

2013-10-28 Thread Jon Ashburn
The new target supplied with textureView must be compatible with the original textures target. This tests valid and invalid combinations. Tested on Nvidia Quadro 600, all tests pass. Reviewed-by: Brian Paul bri...@vmware.com Signed-off-by: Jon Ashburn j...@lunarg.com --- tests/all.tests

[Piglit] [PATCH 4/7] ARB_texture_view: Add query tests for gl state effected by this extension

2013-10-28 Thread Jon Ashburn
-by: Jon Ashburn j...@lunarg.com --- tests/all.tests | 1 + tests/spec/arb_texture_view/CMakeLists.gl.txt | 1 + tests/spec/arb_texture_view/queries.c | 307 ++ 3 files changed, 309 insertions(+) create mode 100644 tests/spec

[Piglit] [PATCH 2/7] arb_texture_view: Test valid and invalid formats

2013-10-28 Thread Jon Ashburn
When calling glTextureView() only certain formats are valid based on the format of the original texture. This tests valid/invalid combinations. Tested on Nvidia Quadro 600, all tests pass. Reviewed-by: Brian Paul bri...@vmware.com Signed-off-by: Jon Ashburn j...@lunarg.com --- tests/all.tests

[Piglit] [PATCH 7/7] ARB_texture_view: Test texture view format changes and lifetimes

2013-10-28 Thread Jon Ashburn
Tests texture views with data format changes. 1D textures only. Uses multiple simultaneous views with different lifetimes and check results via glGetTexImage(). Tested on Nvidia Quadro 600, all subtests pass. Signed-off-by: Jon Ashburn j...@lunarg.com --- tests/all.tests

Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-25 Thread Jon Ashburn
more robust to varying window width and heights rather than fixing the window width and height to a value that samples correctly. Jon On 10/24/2013 05:56 PM, Brian Paul wrote: I didn't really study this test, but some things jumped out... On 10/24/2013 03:49 PM, Jon Ashburn wrote: Tests

[Piglit] [PATCH 1/7] ARB_texture_view: Test for API coverage of subset of input params

2013-10-24 Thread Jon Ashburn
OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests

[Piglit] [PATCH 7/7] ARB_texture_view: Test texture view format changes and lifetimes

2013-10-24 Thread Jon Ashburn
SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j

[Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-24 Thread Jon Ashburn
a/tests/spec/arb_texture_view/common.h b/tests/spec/arb_texture_view/common.h index 1ffcaea..2a0ecfa 100644 --- a/tests/spec/arb_texture_view/common.h +++ b/tests/spec/arb_texture_view/common.h @@ -22,7 +22,22 @@ * * Author: Jon Ashburn j...@lunarg.com */ +#include piglit-util-gl-common.h

[Piglit] [PATCH 6/7] ARB_texture_view: Test for rendering various levels and layers in texture view

2013-10-24 Thread Jon Ashburn
AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon

[Piglit] [PATCH 1/6] ARB_viewport_array: Validity test for viewport index/first/count params

2013-10-23 Thread Jon Ashburn
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests GL_ARB_viewport_array regarding the validity for the indices. + * Use both valid

[Piglit] [PATCH 2/6] ARB_viewport_array: Validity test for depth range index/first/count params

2013-10-23 Thread Jon Ashburn
+ * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests GL_ARB_viewport_array validity for indices. + * Use both valid and invalid parameters (index, first, count) + * for all these new API entry points: + * glDepthRangeArrayv, glDepthRangeIndexed, glGetDoublei_v

[Piglit] [PATCH 3/6] ARB_viewport_array: Validity test for scissor index related params

2013-10-23 Thread Jon Ashburn
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests

[Piglit] [PATCH 4/6] ARB_viewport_array: Test validity of bounds for viewport, depthRange, scissor

2013-10-23 Thread Jon Ashburn
+ * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests for the validity of Viewport bounds, Depth Range bounds and + * Scissor Box bounds with viewport arrays (0 to GL_MAX_VIEWPORTS-1). + * Viewport bounds are x, y, width, height. + * Depth Range bounds are near, far. + * Scissor Box

[Piglit] [PATCH 5/6] ARB_viewport_array: Test validity for glGetFloati_v and glGetDoublei_v

2013-10-23 Thread Jon Ashburn
OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ +/** + * Test valid and invalid queries using glGetFloati_v

[Piglit] [PATCH 6/6] ARB_viewport_array: Test min/max values for new implementation constants

2013-10-23 Thread Jon Ashburn
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** @file minmax.c + * + * Test for the minimum maximum values listed in section 23 State Tables

[Piglit] [PATCH] ARB_viewport_array: Add test for API coverage of index/first/count params

2013-10-18 Thread Jon Ashburn
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests

Re: [Piglit] [PATCH 3/3] ARB_texture_view:Test valid and invalid targets for TextureView

2013-10-18 Thread Jon Ashburn
On 10/18/2013 12:43 PM, Ian Romanick wrote: On 10/16/2013 04:37 PM, Jon Ashburn wrote: The new target supplied with textureView must be compatible with the original textures target. This tests valid and invalid combinations. Tested on Nvidia Quadro 600, all tests pass. --- tests/all.tests

[Piglit] [PATCH 3/4] ARB_texture_view:Test valid and invalid targets for TextureView

2013-10-18 Thread Jon Ashburn
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * \file + * This (arb_texture_view-targets) tests valid and invalid new TextureView + * targets based on the original textures target. + * + * Section 8.18 (Texture Views) of OpenGL

Re: [Piglit] [PATCH 1/3] ARB_texture_view: Test for API coverage of subset of input params

2013-10-17 Thread Jon Ashburn
) they map to: glTexStorage2D(GL_TEXTURE_2D,2, GL_RGBA32F, 16, 16); glTextureView(tex[2], GL_TEXTURE_2D, 0, GL_RGBA32UI, 0, 1, 0, 1); On 10/17/2013 12:38 PM, Ian Romanick wrote: On 10/16/2013 04:37 PM, Jon Ashburn wrote: Tests GL_ARB_texture_view and validity of input parameters. Use both

Re: [Piglit] [PATCH 2/3] arb_texture_view: Test valid and invalid formats

2013-10-17 Thread Jon Ashburn
On 10/17/2013 12:46 PM, Ian Romanick wrote: On 10/16/2013 04:37 PM, Jon Ashburn wrote: diff --git a/tests/spec/arb_texture_view/common.c b/tests/spec/arb_texture_view/common.c new file mode 100644 index 000..c5f5a23 --- /dev/null +++ b/tests/spec/arb_texture_view/common.c @@ -0,0 +1,48

Re: [Piglit] [PATCH] ARB_texture_view: Add query tests for gl state effected by this extension

2013-10-16 Thread Jon Ashburn
them since it is a different test case. Jon On 10/15/2013 05:33 PM, Matt Turner wrote: On Mon, Oct 14, 2013 at 3:53 PM, Jon Ashburn j...@lunarg.com wrote: Tests the queryable state from ARB_texture_view extension is correct. Includes GL_TEXTURE_IMMUTABLE_LEVELS,GL_TEXTURE_VIEW_MIN_LEVEL

Re: [Piglit] [PATCH] ARB_texture_view: Add test suite

2013-10-16 Thread Jon Ashburn
I am not sure why the texture-immutable-levels.c file is in the arb_texture_view directory since it doesn't actually call glTextureView(). Should it be in the arb_texture_storage directory instead? On 10/15/2013 05:34 PM, Matt Turner wrote: On Mon, Oct 14, 2013 at 2:31 PM, Jon Ashburn j

[Piglit] (no subject)

2013-10-16 Thread Jon Ashburn
Updated the params test to divide it into three smaller tests: formats, targets and params. Also updated code to better follow current Piglit idioms and coding practices as found in arb_sync and arb_texture_storage. Added existing texture_view test texture_immutable_levels to all.tests.

[Piglit] [PATCH 1/3] ARB_texture_view: Test for API coverage of subset of input params

2013-10-16 Thread Jon Ashburn
OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests GL_ARB_texture_view and validity of input parameters. + * Use both valid and invalid parameters, although

[Piglit] [PATCH 2/3] arb_texture_view: Test valid and invalid formats

2013-10-16 Thread Jon Ashburn
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +#include GL/gl.h +#include stdarg.h + + +void update_valid_arrays(GLenum *valid, GLenum *invalid, +unsigned int numInvalid, unsigned int

[Piglit] [PATCH 3/3] ARB_texture_view:Test valid and invalid targets for TextureView

2013-10-16 Thread Jon Ashburn
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * \file + * This (arb_texture_view-targets) tests valid and invalid new TextureView + * targets based on the original textures target. + * + * Section 8.18 (Texture Views) of OpenGL

[Piglit] [PATCH] ARB_texture_view: Add test for API coverage

2013-10-14 Thread Jon Ashburn
BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests GL_ARB_texture_view

[Piglit] [PATCH] ARB_texture_view: Add query tests for gl state effected by this extension

2013-10-14 Thread Jon Ashburn
OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Author: Jon Ashburn j...@lunarg.com + */ + +/** + * Tests GL_ARB_texture_view queries of new state added

[Piglit] usage of C++11 STL features in a Piglit test

2013-10-02 Thread Jon Ashburn
if compilers on other platforms which Piglit might support have reasonably thorough C++11 support? For GNU compiler C++11 features require -std=c++11 or -std=gnu++11 compiler options. I can always fall back to implementing test using non-C++11 features. Thanks, Jon Ashburn