Re: [Piglit] [PATCH] framework: Do not run with an empty test list

On 19/10/17 19:50, Dylan Baker wrote: Quoting Martin Peres (2017-10-19 07:17:25) On 30/09/17 23:42, Dylan Baker wrote: Actually CC'ing him this time Quoting Dylan Baker (2017-09-29 20:29:34) Quoting Arkadiusz Hiler (2017-09-26 03:27:50) Because in Python we have `bool([]}) ==

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

On 30/09/17 23:42, Dylan Baker wrote: Actually CC'ing him this time Quoting Dylan Baker (2017-09-29 20:29:34) Quoting Arkadiusz Hiler (2017-09-26 03:27:50) Because in Python we have `bool([]}) == False`, providing empty test list resulted in hitting the same code path as not providing it a

Re: [Piglit] [PATCH v2] framework: Add --ignore-missing option

zilla: https://bugs.freedesktop.org/show_bug.cgi?id=99649 Cc: Dylan Baker Cc: Tomi Sarvela Cc: Martin Peres Tested-by: Petri Latvala Signed-off-by: Arkadiusz Hiler Sorry for the delay. Looks clean and neat to me: Reviewed-by: Martin Peres ___

Re: [Piglit] [PATCH] gl30basic: add some extra suspected extension

On 26/07/17 15:58, sandra koroniewska wrote: Hello, is this patch ok now? Because it hasn't been pushed. Regards, Sandra It still did not get any Reviewed-by. I guess the summer vacation is affecting the piglit team. ___ Piglit mailing list Piglit@

Re: [Piglit] [PATCH] framework: remove duplicate import of framework.exceptions

On 20/07/17 19:20, Dylan Baker wrote: Reported-by: Matt Turner Splitting the line is indeed the right approach, as it is too easy to miss elements. Thanks! Reviewed-by: Martin Peres Signed-off-by: Dylan Baker --- framework/programs/run.py | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Piglit] [PATCH] framework: Don't stop resume because no tests are left to be run

produce a unified result. Signed-off-by: Dylan Baker cc: Martin Peres Thanks! Tested-by: Hector Edmundo Ramirez Gomez --- framework/programs/run.py | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/ru

Re: [Piglit] [PATCH 3/3] framework: Exit if a filter removes all tests from a profile

On 27/06/17 20:44, Martin Peres wrote: On 27/06/17 19:31, Dylan Baker wrote: Quoting Martin Peres (2017-06-27 03:38:33) On 22/06/17 22:12, Dylan Baker wrote: Quoting Petri Latvala (2017-06-21 01:37:21) On 06/20/2017 08:59 PM, Dylan Baker wrote: Quoting Petri Latvala (2017-06-20 05:41:11

Re: [Piglit] [PATCH 3/3] framework: Exit if a filter removes all tests from a profile

On 27/06/17 19:31, Dylan Baker wrote: Quoting Martin Peres (2017-06-27 03:38:33) On 22/06/17 22:12, Dylan Baker wrote: Quoting Petri Latvala (2017-06-21 01:37:21) On 06/20/2017 08:59 PM, Dylan Baker wrote: Quoting Petri Latvala (2017-06-20 05:41:11) On 04/13/2017 09:46 PM, Dylan Baker

Re: [Piglit] [PATCH 3/3] framework: Exit if a filter removes all tests from a profile

On 22/06/17 22:12, Dylan Baker wrote: Quoting Petri Latvala (2017-06-21 01:37:21) On 06/20/2017 08:59 PM, Dylan Baker wrote: Quoting Petri Latvala (2017-06-20 05:41:11) On 04/13/2017 09:46 PM, Dylan Baker wrote: Quoting Brian Paul (2017-04-12 13:04:59) On 04/12/2017 11:55 AM, Dylan Baker wro

Re: [Piglit] [PATCH] tests/igt.py: mark segfaulted IGT process as 'crash'

Reviewed-by: Martin Peres I will push the patch now. It has waited on the list long-enough! Thanks, Martin On 16/05/17 18:08, Tomi Sarvela wrote: On IGT testing segfaulted processes are lumped together with failed tests in results. This patch separates the two for correctness: test doesn&#

Re: [Piglit] [PATCH] framework/backends/json: always flush the metadata to the disk

On 30/01/17 20:09, Dylan Baker wrote: Reviewed-by: Dylan Baker Thanks Dylan! Just pushed the patch :) ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] framework/backends/json: always flush the metadata to the disk

This guarantees that whatever the state we are in, we can always continue the piglit run. Do not use FileBackend.__fsync as it would not do the fsync call in the non-sync mode. This change makes it easier to integrate into a CI system that is hard-reboot-resistant. Signed-off-by: Martin Peres

Re: [Piglit] [PATCH] resume: use the previously-set test-list when resuming

On 11/01/17 22:24, Dylan Baker wrote: Reviewed-by: Dylan Baker Thanks Dylan! Pushed it! ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] resume: use the previously-set test-list when resuming

Dumez Cc: Dylan Baker Reported-by: Rami Ben Hassine Signed-off-by: Martin Peres --- framework/programs/run.py | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index e5d55837a..177bd535c 1

Re: [Piglit] [PATCH] arb_shader_image_size: actually run in the relevant shader stage

midway... Reviewed-by: Martin Peres --- tests/spec/arb_shader_image_size/builtin.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/spec/arb_shader_image_size/builtin.c b/tests/spec/arb_shader_image_size/builtin.c index c8a7724..b728529 100755 --- a/tests/spec

Re: [Piglit] [PATCH 0/6] make gen_vs_in_fp64 run faster

On 09/06/16 19:50, Dylan Baker wrote: Quoting Andres Gomez (2016-06-09 06:45:49) Nice optimizations, Dylan. I'm quite impressed/surprised on the gain through avoiding the inheritance/include mechanisms in the mako templates. This series is: Reviewed-by: Andres Gomez Andres I was definitel

Re: [Piglit] [PATCH 0/3] Fix some program input / output issues with ARB_piq

On 26/05/16 21:56, Ian Romanick wrote: On 05/26/2016 11:55 AM, Ian Romanick wrote: On 05/26/2016 08:01 AM, Martin Peres wrote: On 26/05/16 01:36, Ian Romanick wrote: After spending about a week with dEQP, GL_OES_shader_io_blocks, and GL_OES_geometry_shader, I believe there are some errors

Re: [Piglit] [PATCH 3/3] arb_program_interface_query: Fix TCS input expectations

for them to be available since the compiler should be free to get rid of them even if I use SSO as they are merely inputs. Reviewed-by: Martin Peres Signed-off-by: Ian Romanick Cc: Martin Peres Cc: Dave Airlie --- .../arb_program_interface_query/resource-query.c | 23

Re: [Piglit] [PATCH 2/3] arb_program_interface_query: Expect array suffixes on array inputs / outputs

"[0]". I can find no language that implies that geometry or tessellation inputs or tessellation control outputs should be excluded from this rule. Various dEQP tests also expect [0] be added to geometry shader inputs. Signed-off-by: Ian Romanick Cc: Martin Peres Cc: Dave Airlie

Re: [Piglit] [PATCH 1/3] arb_program_interface_query: Expect certain built-ins be prefixed with gl_PerVertex

ot;. In these cases, applying the standard rules would result in an enumerated name of "gl_PerVertex.gl_Position". Signed-off-by: Ian Romanick Cc: Martin Peres Cc: Dave Airlie Well, this issue indeed seems clear-enough, thanks f

Re: [Piglit] [PATCH 0/3] Fix some program input / output issues with ARB_piq

On 26/05/16 01:36, Ian Romanick wrote: After spending about a week with dEQP, GL_OES_shader_io_blocks, and GL_OES_geometry_shader, I believe there are some errors with the expectations of our existing ARB_piq tests. I have included spec justifications for the changes, and the changes match tests

Re: [Piglit] [PATCH v2] glx_arb_sync_control/wait_for_msc: Add a missing timeout

On 20/04/16 14:58, Lofstedt, Marta wrote: -Original Message- From: Martin Peres [mailto:martin.pe...@linux.intel.com] Sent: Wednesday, April 20, 2016 12:30 PM To: Marta Lofstedt ; piglit@lists.freedesktop.org Cc: Lofstedt, Marta Subject: Re: [PATCH v2] glx_arb_sync_control

Re: [Piglit] [PATCH v2] glx_arb_sync_control/wait_for_msc: Add a missing timeout

Thanks! Looks good now :) Reviewed-by: Martin Peres I will push it tomorrow! --- tests/spec/glx_oml_sync_control/waitformsc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/glx_oml_sync_control/waitformsc.c b/tests/spec/glx_oml_sync_control/waitformsc.c index 3d08dbc..86c5b25

Re: [Piglit] [PATCH] glx_arb_sync_control: Add timeout

On 18/04/16 13:22, Marta Lofstedt wrote: From: Marta Lofstedt The glx_arb_sync_control piglit tests should fail after a timeout expired, instead of not terminating. Signed-off-by: Marta Lofstedt All the files in tests/spec/glx_oml_sync_control/ already have this timeout ... except one, wai

Re: [Piglit] [PATCH v2] arb_program_interface_query: Silence uninitialized variable warning.

f = GL_COMPUTE_SUBROUTINE; break; +default: +assert(!"unexpected programInterface value"); +pif = GL_NONE; } /* check that the return count is as expected */ Reviewed-by: Brian Paul Thanks for doi

Re: [Piglit] [PATCH][RFC] Add dmesg option for reboot policy

:48:35PM +0200, Martin Peres wrote: On 02/11/15 16:57, yann.argo...@linux.intel.com wrote: This adds a policy which advises when user should reboot system to avoid noisy test results due to system becoming unstable, for instance, and therefore continues testing successfully. To do this, a new

Re: [Piglit] [PATCH][RFC] Add dmesg option for reboot policy

On 02/11/15 16:57, yann.argo...@linux.intel.com wrote: This adds a policy which advises when user should reboot system to avoid noisy test results due to system becoming unstable, for instance, and therefore continues testing successfully. To do this, a new Dmesg class is proposed which is not fi

Re: [Piglit] [PATCH v2] winsys-framework Default to showing window

On 17/11/15 22:01, Dave Airlie wrote: On 18 November 2015 at 05:49, Arthur Huillet wrote: Thanks :) Reviewed by: Arthur Huillet Reviewed-by: Dave Airlie Pushed ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/ma

Re: [Piglit] [PATCH] winsys-framework Default to showing window

On 09/11/15 05:19, Dave Airlie wrote: On 21 August 2015 at 22:08, Marek Olšák wrote: Hi Alex, The tests which don't specifically test the behavior of the default framebuffer should use -fbo. I think this is done by marking a test as "concurrent" in all.py. A lot of tests don't do that, because

Re: [Piglit] Patchwork

On 10/11/15 21:52, Dylan Baker wrote: Hi ladies and gents, I've just finished (mostly) cleaning up patchwork, removing tests that have been superseded, rejected, sent to the wrong list, etc. We now have four pages of patches for review that are outstanding, some as far back as 2013, and some fo

Re: [Piglit] [PATCH 06/15] arb_direct_state_access: Testing CopyNamedBufferSubData.

up on this :s Martin On Wed, Apr 1, 2015 at 7:52 AM, Martin Peres wrote: On 23/01/15 21:03, Laura Ekstrand wrote: --- tests/spec/arb_direct_state_access/namedbufferstorage.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/spec/arb_direct_state_access

[Piglit] [PATCH 3/4] arb_shader_image_size/builtin: test all the image formats

slow mode takes 6.5 minutes on a Fermi with the NVIDIA proprietary driver while the normal execution time is around 1 second. Signed-off-by: Martin Peres --- tests/spec/arb_shader_image_size/builtin.c | 87 +++--- 1 file changed, 68 insertions(+), 19 deletions(-) diff --

[Piglit] [PATCH 2/4] arb_shader_image_load_store/common: handle uploading non-32-bits buffer_texture images

Signed-off-by: Martin Peres --- tests/spec/arb_shader_image_load_store/common.c | 2 +- tests/spec/arb_shader_image_load_store/image.c | 10 -- tests/spec/arb_shader_image_load_store/image.h | 6 ++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/tests/spec

[Piglit] [PATCH 1/4] arb_shader_image_size/builtin: Fix the CubeMap image test

Signed-off-by: Martin Peres --- tests/spec/arb_shader_image_size/builtin.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/spec/arb_shader_image_size/builtin.c b/tests/spec/arb_shader_image_size/builtin.c index cb427df..48a1d1e 100755 --- a/tests/spec/arb_shader_image_size

[Piglit] [PATCH 4/4] arb_shader_image_size/builtin: test a simple size before testing max sizes

The normal mode will run the small tests on the interesting stages and formats while the slow mode will test every stage and every format. Disable all the max-size tests in quick mode since they are redundant with the smaller tests anyway which run faster. Signed-off-by: Martin Peres --- tests

Re: [Piglit] Posting tests results

On 23/08/15 01:03, Herminio Hernandez Jr. wrote: I am new to the thread. I am Debian and Ubuntu on PowerPC machines. I have installed and ran piglit tests on Radeon graphics cards and would like share my results. Just would like to know what is the proper way of doing that. Thanks! Ilia Mirki

[Piglit] [PATCH 2/2] arb_shader_image_size/builtin: make sure that each target gets tested

Signed-off-by: Martin Peres --- tests/spec/arb_shader_image_size/builtin.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_shader_image_size/builtin.c b/tests/spec/arb_shader_image_size/builtin.c index 48a1d1e..550a913 100755 --- a/tests/spec

[Piglit] [PATCH 1/2] arb_shader_image_size/builtin: Fix the CubeMap image test

Signed-off-by: Martin Peres --- tests/spec/arb_shader_image_size/builtin.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/spec/arb_shader_image_size/builtin.c b/tests/spec/arb_shader_image_size/builtin.c index cb427df..48a1d1e 100755 --- a/tests/spec/arb_shader_image_size

Re: [Piglit] [PATCH] arb_dsa: avoid non-determinism in create-programpipelines subtests

1; glGetObjectLabel(GL_PROGRAM_PIPELINE, ids[2], 11, &length, label); piglit_check_gl_error(GL_NO_ERROR); SUBTESTCONDITION(length == 0, pass, Thanks. I recently stumbled onto this one too, but didn't had opportunity to do anything about it. Reviewed-by: Jose Fonseca Sorry about this:

Re: [Piglit] [PATCH] shaders: add a test counting builtin active uniforms

On 28/05/15 21:50, Dylan Baker wrote: Hey Martin, I know these have already landed, but I noticed that you added tests in the shaders/ directory. I Just wanted to let you know that we're not adding new tests in the shaders directory, in the future putting them in the appropriate directory under

[Piglit] [PATCH 1/3] shaders: test the vec4(mat3) constructor

This is currently problematic in mesa. Signed-off-by: Martin Peres --- tests/shaders/glsl-fs-vec4-mat3.shader_test | 20 1 file changed, 20 insertions(+) create mode 100644 tests/shaders/glsl-fs-vec4-mat3.shader_test diff --git a/tests/shaders/glsl-fs-vec4-mat3

[Piglit] [PATCH 3/3] shaders: test the ivec4(mat3) constructor

This is currently problematic in mesa. Signed-off-by: Martin Peres --- tests/shaders/glsl-fs-ivec4-mat3.shader_test | 20 1 file changed, 20 insertions(+) create mode 100644 tests/shaders/glsl-fs-ivec4-mat3.shader_test diff --git a/tests/shaders/glsl-fs-ivec4-mat3

[Piglit] [PATCH 2/3] shaders: test the vec4(mat2) constructor

This is currently problematic in mesa. Signed-off-by: Martin Peres --- tests/shaders/glsl-fs-vec4-mat2.shader_test | 20 1 file changed, 20 insertions(+) create mode 100644 tests/shaders/glsl-fs-vec4-mat2.shader_test diff --git a/tests/shaders/glsl-fs-vec4-mat2

[Piglit] [PATCH 0/3] Add mulitple vector constructor tests

My "shaders: add a test counting builtin active uniforms" test exposed a bug in mesa related to constructor vectors with a matrix as an input. This series formally test this unusual feature. Martin Peres (3): shaders: test the vec4(mat3) constructor shaders: test the vec4(mat2) c

Re: [Piglit] [PATCH v2] program_interface_query: add new subtest for getprogramresourceiv

ot;(tes,tcs)", st_r_tess_uniform), ST( 2, 8, -1, -1,NULL,NULL,NULL,NULL,NULL, cs_sub, GL_UNIFORM, "(cs)", st_r_cs_uniform), - ST( 3, 17, 2, -1, vs_std,NULL,NULL, gs_std, fs_std, NULL, GL_UNIFORM_BLOCK, "(vs,gs,fs)", st_r_unif

Re: [Piglit] [PATCH] program_interface_query: add new subtest for getprogramresourceiv

On 20/05/15 11:39, Samuel Iglesias Gonsálvez wrote: On 19/05/15 12:02, Martin Peres wrote: On 19/05/15 08:46, Samuel Iglesias Gonsalvez wrote: Test that uniforms inside arrays of uniform blocks with instance name are queried properly. Tested on NVIDIA's proprietary driver version 3

Re: [Piglit] [PATCH 4/4] arb_shader_image_load_store/grid: Iterate over all known shader stages in generate_program_v().

id, stage->stage, Reviewed-by: Martin Peres ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/4] arb_shader_image_load_store/image: Expose array of known shader shader stages.

d); + +/** * Get all shader stages that support image access in pipeline order. */ const struct image_stage_info * Reviewed-by: Martin Peres ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/4] arb_shader_image_load_store/image: Document behaviour of get_image_stage() if images aren't supported.

specified + * stage doesn't support images. */ const struct image_stage_info * get_image_stage(GLenum s); Reviewed-by: Martin Peres ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/4] arb_shader_image_load_store/indexing: Plug memory leak.

og, name, unit); +free(name); } return true; Reviewed-by: Martin Peres ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] shaders: add a test counting builtin active uniforms

The test will almost-always pass but it is a nice way to catch bugs in our implementation... More information inside the test! Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=32403 Signed-off-by: Martin Peres --- tests/all.py| 1 + tests/shaders/CMakeLists.gl.txt

Re: [Piglit] [PATCH] program_interface_query: add new subtest for getprogramresourceiv

On 19/05/15 08:46, Samuel Iglesias Gonsalvez wrote: Test that uniforms inside arrays of uniform blocks with instance name are queried properly. Tested on NVIDIA's proprietary driver version 340.65 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90397 Signed-off-by: Samuel Iglesias Gonsa

Re: [Piglit] [PATCH] arb_shader_image_size: test GLSL's builtin imageSize

On 08/05/15 18:52, Francisco Jerez wrote: Martin Peres writes: v2: - make sure that GL_ARB_shader_image_size == 1 in the shaders Signed-off-by: Martin Peres --- tests/all.py | 5 + tests/quick.py | 7 + tests

[Piglit] [PATCH] direct_state_access/queries: add a subtest checking QUERY_TARGET

Tested on NVIDIA's proprietary driver version 346.35. Reported-by: Ilia Mirkin Signed-off-by: Martin Peres --- tests/spec/arb_direct_state_access/create-queries.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/spec/arb_direct_state_access/create-queries.c b/tests

[Piglit] [PATCH] arb_shader_image_size: test GLSL's builtin imageSize

v2: - make sure that GL_ARB_shader_image_size == 1 in the shaders Signed-off-by: Martin Peres --- tests/all.py | 5 + tests/quick.py | 7 + tests/spec/CMakeLists.txt | 1 + tests/spec

[Piglit] [PATCH] arb_shader_image_size: test GLSL's builtin imageSize

Signed-off-by: Martin Peres --- tests/all.py | 5 + tests/quick.py | 7 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_shader_image_size/CMakeLists.gl.txt | 16 ++ tests/spec

Re: [Piglit] [PATCH] DSA: fix error value for *TextureSubImage* when target doesn't match

On 23/04/15 15:12, Arthur Huillet wrote: Hi, On Thu, 23 Apr 2015 14:26:32 +0300 Martin Peres wrote: Does the patch look OK to you? Yeah, patch looks perfectly fine. But I'd like to hear from Laura (or Martin perhaps, who reviewed a lot of these) about whether this was done on purpose o

Re: [Piglit] [PATCH] DSA: fix error value for *TextureSubImage* when target doesn't match

On 22/04/15 20:06, Ilia Mirkin wrote: [fixing Laura's email] On Wed, Apr 22, 2015 at 1:05 PM, Ilia Mirkin wrote: On Wed, Apr 22, 2015 at 12:53 PM, Arthur Huillet wrote: Hi, On 2015-04-22 18:37, Ilia Mirkin wrote: From the ARB_dsa spec: An INVALID_ENUM error is generated by *TexSubIm

Re: [Piglit] [PATCH] program_interface_query: add getprogramresourceiv in all.py

On 08/04/15 11:13, Tapani Pälli wrote: Reviewed-by: Tapani Pälli Thanks, pushed. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] program_interface_query: add getprogramresourceiv in all.py

Signed-off-by: Martin Peres --- tests/all.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.py b/tests/all.py index 5138f73..507f84f 100755 --- a/tests/all.py +++ b/tests/all.py @@ -2287,6 +2287,7 @@ with profile.group_manager( g(['arb_program_interface_

Re: [Piglit] [PATCH v5 6/6] program_interface_query: add tests for getprogramresourceiv

On 07/04/15 21:20, Dylan Baker wrote: Martin, do you need to add this test to all.py? Hmm, it must have been deleted in a rebase. Will send a patch to the ML right now. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/

Re: [Piglit] [PATCH 02/15] arb_direct_state_access: Testing NamedBufferStorage.

On 03/04/15 04:00, Laura Ekstrand wrote: Well, it wasn't as bad as I thought initially. Here's the version with core = 32: http://cgit.freedesktop.org/~ldeks/piglit/commit/?h=adsa-buffer-objects&id=2eb0b4b2a4ee17f2981aa834b02d6340bdad174d

[Piglit] [PATCH v6 6/6] program_interface_query: add tests for getprogramresourceiv

d-off-by: Martin Peres --- .../arb_program_interface_query/CMakeLists.gl.txt |1 + .../getprogramresourceiv.c | 1132 2 files changed, 1133 insertions(+) create mode 100755 tests/spec/arb_program_interface_query/getprogramresourceiv.c diff --git

Re: [Piglit] [PATCH v5 6/6] program_interface_query: add tests for getprogramresourceiv

On 02/04/15 14:10, Tapani Pälli wrote: On 04/01/2015 01:56 PM, Martin Peres wrote: Tested on NVIDIA's proprietary driver version 346.35. Signed-off-by: Martin Peres --- .../arb_program_interface_query/CMakeLists.gl.txt |1 + .../getprogramresourc

Re: [Piglit] [PATCH 03/15] arb_direct_state_access: Testing NamedFramebufferRenderbuffer.

On 06/03/15 04:01, Laura Ekstrand wrote: --- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../namedframebufferrenderbuffer.c | 159 + 3 files changed, 161 insertions(+) create mod

Re: [Piglit] [PATCH 01/15] arb_direct_state_access: Test for CreateFramebuffers.

TESTCONDITION((bool) glIsFramebuffer(name), pass, +"IsFramebuffer()"); + + glDeleteFramebuffers(1, &name); + + return pass ? PIGLIT_PASS : PIGLIT_FAIL; +} + -- 2.1.0 With above comment fixed: Reviewed-by: Anuj Phogat With the above comment fixed + the

Re: [Piglit] [PATCH 02/15] arb_direct_state_access: Testing glCreateFramebuffers "in the wild."

info/piglit Reviewed-by: Anuj Phogat Reviewed-by: Martin Peres ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 15/15] arb_direct_state_access: Testing glGetNamedBufferSubData.

On 23/01/15 21:03, Laura Ekstrand wrote: --- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../getnamedbuffersubdata.c| 112 + 3 files changed, 114 insertions(+) create mod

Re: [Piglit] [PATCH 13/15] arb_direct_state_access: Testing glGetNamedBufferParameteri[64]v.

On 23/01/15 21:03, Laura Ekstrand wrote: --- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../getnamedbufferparameter.c | 215 + 3 files changed, 217 insertions(+) create m

Re: [Piglit] [PATCH 12/15] arb_direct_state_access: Testing FlushMappedNamedBufferRange.

); + if (!ret) + piglit_report_result(PIGLIT_FAIL); + + piglit_report_result(PIGLIT_PASS); +} This test is also quite problematic since it is hard to detect that a cache did not get written back ... in your back. Anyway, this tests the DSA path so it is fine. Reviewed-by: Martin Peres ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 11/15] arb_direct_state_access: Testing UnmapNamedBuffer.

On 23/01/15 21:03, Laura Ekstrand wrote: --- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../mapnamedbuffer-pbo-readpixels.c| 6 +- .../arb_direct_state_access/unmapnamedbuffer-vbo.c | 128 +++

Re: [Piglit] [PATCH 10/15] arb_direct_state_access: Testing MapNamedBuffer.

&= probe(1, 1, 0x00ff, addr[1]); + glUnmapBuffer(GL_PIXEL_PACK_BUFFER); + + piglit_present_results(); + + glDeleteBuffers(1, &pbo); + + return pass ? PIGLIT_PASS : PIGLIT_FAIL; +} + + +void +piglit_init(int argc, char **argv) +{ + piglit_require_ext

Re: [Piglit] [PATCH 08/15] arb_direct_state_access: Testing glClearNamedBufferSubData.

orts_gl_compat_version = 15; + config.supports_gl_core_version = 31; + +PIGLIT_GL_TEST_CONFIG_END + +static GLuint buffer; + +void +piglit_init(int argc, char **argv) +{ + bool pass = true; + int i; + const int buffer_size = 1<<20; Do you really need to allocate 1 MB? 1 &

Re: [Piglit] [PATCH 07/15] arb_direct_state_access: Testing glClearNamedBufferData.

COMPRESSED_ALPHA, GL_ALPHA, GL_UNSIGNED_BYTE}, + {GL_COMPRESSED_LUMINANCE, GL_LUMINANCE, GL_UNSIGNED_BYTE}, + {GL_COMPRESSED_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE}, + {GL_COMPRESSED_INTENSITY, GL_INTENSITY, GL_UNSIGNED_BYTE}, + {GL_COMPRESSED_RGB, GL_RGB

Re: [Piglit] [PATCH 05/15] arb_direct_state_access: Testing NamedBufferSubData.

artin Peres On Wed, Feb 18, 2015 at 8:06 AM, Martin Peres mailto:martin.pe...@linux.intel.com>> wrote: On 23/01/15 21:03, Laura Ekstrand wrote: --- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../namedbuffer

Re: [Piglit] [PATCH 03/15] arb_sync: Test to demonstrate ClientWaitSync bug.

times before the signal is actually recorded and either GL_CONDITION_SATISFIED or GL_ALREADY_SIGNALED is returned. Looks good to me: Reviewed-by: Martin Peres --- tests/all.py | 1 + tests/spec/arb_sync/CMakeLists.gl.txt| 1 + tests/spec/arb_sync

Re: [Piglit] [PATCH 02/15] arb_direct_state_access: Testing NamedBufferStorage.

t(int argc, char **argv) +{ + piglit_require_gl_version(15); + piglit_require_extension("GL_ARB_buffer_storage"); + piglit_require_extension("GL_ARB_map_buffer_range"); This one would not be needed because the extension got introduced in OpenGL 3.0. Othe

Re: [Piglit] [PATCH 14/15] arb_direct_state_access: Testing GetNamedBufferPointerv.

On 23/01/15 21:03, Laura Ekstrand wrote: --- .../arb_direct_state_access/getnamedbufferparameter.c| 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/spec/arb_direct_state_access/getnamedbufferparameter.c b/tests/spec/arb_direct_state_access/getname

Re: [Piglit] [PATCH 06/15] arb_direct_state_access: Testing CopyNamedBufferSubData.

On 23/01/15 21:03, Laura Ekstrand wrote: --- tests/spec/arb_direct_state_access/namedbufferstorage.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/spec/arb_direct_state_access/namedbufferstorage.c b/tests/spec/arb_direct_state_access/namedbufferstorage.c inde

Re: [Piglit] [PATCH 09/15] arb_direct_state_access: Testing MapNamedBufferRange.

On 23/01/15 21:03, Laura Ekstrand wrote: --- tests/spec/arb_direct_state_access/namedbufferstorage.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/spec/arb_direct_state_access/namedbufferstorage.c b/tests/spec/arb_direct_state_access/namedbufferstorage.

Re: [Piglit] [PATCH 04/15] arb_direct_state_access: Testing NamedBufferData.

On 23/01/15 21:03, Laura Ekstrand wrote: --- tests/spec/arb_direct_state_access/namedbufferstorage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_direct_state_access/namedbufferstorage.c b/tests/spec/arb_direct_state_access/namedbufferstorage.c index 2ddf

[Piglit] [PATCH v5 2/6] program_interface_query: add tests for getprograminterfaceiv

This test exercises the error codepaths of getprograminterfaceiv. Tested on NVIDIA's proprietary driver version 346.35. Reviewed-by: Tapani Pälli Signed-off-by: Martin Peres --- tests/all.py | 1 + .../arb_program_interface_query/CMakeLists.g

[Piglit] [PATCH v5 0/6] program_interface_query: tests for getprograminterfaceiv and getprogramresourceindex/name/iv

etary driver (346.35) which passes the majority of the tests. All the tests pass on Tapani's implementation for mesa. Martin Peres (6): program_interface_query: add tests for querying the resources program_interface_query: add tests for getprograminterfaceiv program_interface_query: add

[Piglit] [PATCH v5 1/6] program_interface_query: add tests for querying the resources

: - GL_ARB_shader_atomic_counters - GL_ARB_shader_storage_buffer_object - GL_ARB_shader_subroutine - GL_ARB_tessellation_shader - GL_ARB_compute_shader - GL_ARB_shader_image_load_store Tested on NVIDIA's proprietary driver version 346.35. v2: Martin Peres - Fix the cs subtest to test PROGRAM_INPU

[Piglit] [PATCH v5 5/6] program_interface_query: move some shaders to common.h

This will be needed for the next test. Signed-off-by: Martin Peres --- tests/spec/arb_program_interface_query/common.h| 22 +++ .../resource-location.c| 32 -- 2 files changed, 27 insertions(+), 27 deletions(-) mode change 100644

[Piglit] [PATCH v5 6/6] program_interface_query: add tests for getprogramresourceiv

Tested on NVIDIA's proprietary driver version 346.35. Signed-off-by: Martin Peres --- .../arb_program_interface_query/CMakeLists.gl.txt |1 + .../getprogramresourceiv.c | 1063 2 files changed, 1064 insertions(+) create mode 100755 tests

[Piglit] [PATCH v5 3/6] program_interface_query: add tests for getprogramresourceindex

. v2: - also test a NULL name (Tapani) Reviewed-by: Tapani Pälli Signed-off-by: Martin Peres --- tests/all.py | 2 +- .../arb_program_interface_query/CMakeLists.gl.txt | 2 +- tests/spec/arb_program_interface_query/common.h

[Piglit] [PATCH v5 4/6] program_interface_query: add tests for getprogramresourcename

Tests the error paths of GetProgramResourceName Tested on NVIDIA's proprietary driver version 346.35. v2: - Test that a NULL name does not crash (suggested by Tapani) Reviewed-by: Tapani Pälli Signed-off-by: Martin Peres --- tests/all.py

Re: [Piglit] [PATCH 00/14] Add DSA tests for vertex array objects

On 31/03/15 20:26, Fredrik Höglund wrote: This series adds piglit tests for the VAO portion of GL_ARB_direct_state_access. The tests are written so that they can be run against either the core or compatibility profiles. The exception is vao-core and vao-compatibility, which contain all the prof

Re: [Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types

On 01/04/15 08:14, Timothy Arceri wrote: On Tue, 2015-03-31 at 12:02 +0300, Martin Peres wrote: On 30/03/15 10:29, Timothy Arceri wrote: Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- This is just /tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any

Re: [Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types

On 30/03/15 10:29, Timothy Arceri wrote: Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- This is just /tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any-type.vert with an extra dimension added. .../compiler/arrays-of-any-type.vert | 44 ++

Re: [Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types

On 31/03/15 00:17, Timothy Arceri wrote: On Mon, 2015-03-30 at 10:51 +0300, Martin Peres wrote: On 30/03/15 10:29, Timothy Arceri wrote: Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- This is just /tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any

Re: [Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types

On 30/03/15 10:29, Timothy Arceri wrote: Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- This is just /tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any-type.vert with an extra dimension added. Do you have any other test that would cover more than just

Re: [Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

should be PROGRAM_INPUT not OUTPUT but that you already fixed, right?). Yes, it is already fixed in my tree and on freedesktop. Some nitpicking and comments on the layout below; I'd give r-b but I want to hear if you will address some of this; On 03/25/2015 06:01 PM, Martin Peres wrote: This

Re: [Piglit] [PATCH 3/4] program_interface_query: add tests for getprogramresourceindex

On 25/03/15 18:01, Martin Peres wrote: Tests tricky cases of resource naming along with some error cases of getprogramresourceindex. It also replaces the resource-index test that was incomplete and did not consistently report the same number of subtests depending on errors. Signed-off-by

Re: [Piglit] [PATCH 2/4] program_interface_query: add tests for getprograminterfaceiv

not force every driver to not crash. Reviewed-by: Tapani Pälli As discussed IRL, I will keep your R-b :) On 03/25/2015 06:01 PM, Martin Peres wrote: This test exercises the error codepaths of getprograminterfaceiv. Signed-off-by: Martin Peres --- tests/all.py

Re: [Piglit] [PATCH 3/4] program_interface_query: add tests for getprogramresourceindex

On 26/03/15 12:50, Tapani Pälli wrote: On 03/26/2015 12:35 PM, Tapani Pälli wrote: On 03/25/2015 06:01 PM, Martin Peres wrote: Tests tricky cases of resource naming along with some error cases of getprogramresourceindex. It also replaces the resource-index test that was incomplete and did

Re: [Piglit] [PATCH 4/4] program_interface_query: add tests for getprogramresourcename

"NULL name"); + if (piglit_is_extension_supported("GL_ARB_shader_atomic_counters")) { glGetProgramResourceName(prog, GL_ATOMIC_COUNTER_BUFFER, 0, 100, &length, name); With this addition; Reviewed-by: Tapani Pälli Added too, tha

Re: [Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

On 25/03/15 18:01, Martin Peres wrote: This tests primarily glGetProgramInterfaceiv in various (potentially tricky) program pipelines. All the calls are supposed to succeed as this test is purely functional. This test requires a OpenGL 3.2 core context but also has optional subtests that depend

[Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

: - GL_ARB_shader_atomic_counters - GL_ARB_shader_storage_buffer_object - GL_ARB_shader_subroutine - GL_ARB_tessellation_shader - GL_ARB_compute_shader - GL_ARB_shader_image_load_store Signed-off-by: Martin Peres --- tests/all.py | 1

  1   2   >