Re: [Piglit] [PATCH 4/4] arb_sample_shading: don't use gl_FragColor/Data in fragment shaders

For series, Reviewed-by: Neha Bhende<bhen...@vmware.com> Regards, Neha From: Piglit <piglit-boun...@lists.freedesktop.org> on behalf of Brian Paul <bri...@vmware.com> Sent: Friday, November 10, 2017 2:44:45 PM To: piglit@lists.freed

Re: [Piglit] [Review Request (master branch)] textureGather: correct expected result for GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 1

affected, if I understood notion of GL_SWIZZLE_TEXTURE_RGBA correctly. Regards, Neha From: ibmir...@gmail.com <ibmir...@gmail.com> on behalf of Ilia Mirkin <imir...@alum.mit.edu> Sent: Thursday, August 3, 2017 11:44:34 AM To: Neha Bhend

[Piglit] [Review Request (master branch)] textureGather: correct expected result for GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 1

Expected results were with respect to GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB = 4. This patch is fixing it for GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB =1 as well. --- tests/texturing/shaders/textureGather.c | 50 - 1 file changed, 31 insertions(+), 19

[Piglit] [Review Request (master branch)] fbo: Use glLinkProgram after binding attributes to location.

After binding attribute location, test was assuming that attributes are getting bind to specified location without calling glLinkProgram. Sometime it gets lucky that attributes are bind to expected location but sometimes it doesn't. It fixes rendering corruption seen while running this test. ---

Re: [Piglit] [PATCH] arb_provoking_vertex: fix quads-follow-provoking-vertex test

Looks great. Reviewed-by: Neha Bhende<bhen...@vmware.com> I suppose, we will also need similar fix in arb-provoking-vertex-render as well Regards, Neha From: Brian Paul <bri...@vmware.com> Sent: Monday, July 17, 2017 11:28:54 A

Re: [Piglit] [PATCH] clipflat: refactor some code

Looks good. Reviewed-by : Neha Bhende <bhen...@vmware.com> Thanks, Neha From: Brian Paul <bri...@vmware.com> Sent: Friday, July 14, 2017 9:06:17 AM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH] clipfl

Re: [Piglit] [PATCH] wgl: add new multi-context, multi-window rendering tests

Looks great! Reviewed-by: Neha Bhende<bhen...@vmware.com> Regards, Neha From: Brian Paul <bri...@vmware.com> Sent: Tuesday, July 11, 2017 8:22:07 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH]

Re: [Piglit] [PATCH] blit-scaled-linear: minor shader code improvements

Looks good to me. Reviewed-by: Neha Bhende<bhen...@vmware.com> Regards, Neha From: Brian Paul <bri...@vmware.com> Sent: Tuesday, July 11, 2017 1:09:29 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH]

Re: [Piglit] [PATCH] polygon-mode: print more info if there's a failure

Looks good. Reviewed-by: Neha Bhende <bhen...@vmware.com> Regards, Neha From: Brian Paul <bri...@vmware.com> Sent: Friday, June 16, 2017 3:44:11 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH]

Re: [Piglit] [PATCH] util: fix Windows stdout/stderr buffering

Looks good to me. Reviewed-by: Neha Bhende<bhen...@vmware.com> Regards, Neha From: Brian Paul <bri...@vmware.com> Sent: Wednesday, June 7, 2017 1:17:19 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATC

Re: [Piglit] [PATCH] util: call fflush() after printf() calls

Looks good. Reviewed-by: Neha Bhende <bhen...@vmware.com> Regards, Neha From: Brian Paul <bri...@vmware.com> Sent: Wednesday, June 7, 2017 8:51:52 AM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATCH

Re: [Piglit] [PATCH] primitive-restart: run all tests even when there's a failure

Looks good to me. Reviewed-by: Neha Bhende <bhen...@vmware.com> Regards, Neha From: Brian Paul <bri...@vmware.com> Sent: Thursday, May 4, 2017 6:18 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Brian Paul Subject: [PATC

[Piglit] [Review Request (master branch)] srgb_conformance: fix error computation

piglit_linear_to_srgb() returns float values in [0,1]. The test was comparing it against integer values in [0,255]. This is why test was failing. Also, fix the overall test pass/fail logic. Reviewed-by: Brian Paul --- tests/spec/arb_framebuffer_srgb/srgb_conformance.c | 15

Re: [Piglit] [PATCH] all.py: s/OpenGL 1.1/opengl 1.1/

looks good to me. Reviewed-by: Neha Bhende<bhen...@vmware.com> Regards, Neha From: Piglit <piglit-boun...@lists.freedesktop.org> on behalf of Brian Paul <bri...@vmware.com> Sent: Thursday, April 27, 2017 2:14:16 PM To: piglit@lists.freed

[Piglit] [Review Request (master branch)] framework/test/glsl_parser_test.py: fix python script to run glslparsertest on windows

glslparsertest was not running on windows because python script is looking for glslparsertest. On windows, piglit creates glslparsertest.exe. With this fix, all glslparsertest will run on windows. --- framework/test/glsl_parser_test.py | 8 ++-- 1 file changed, 6 insertions(+), 2