[Piglit] [PATCH 4/4] arb_tessellation_shader/tes-gs-max-output: new test for TES/GS amplification

2018-09-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Test extremes of GS amplification under tessellation. --- tests/opengl.py | 1 + .../arb_tessellation_shader/CMakeLists.gl.txt | 1 + .../tes-gs-max-output.cpp | 817 ++ 3 files changed, 819 insertions

[Piglit] [PATCH 3/4] glsl-1.50/gs-max-output: new test for geometry shader amplification

2018-09-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Test the extremes of # of GS output vertices / components per GS input primitive. Existing tests only cover cases of high # of components per vertex, but not cases of low # of components per vertex and high # of output vertices. --- tests/opengl.py

[Piglit] [PATCH 1/4] fbo-drawbuffers-maxtargets: fix a warning

2018-09-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Ensure that the allocated buffer is guaranteed to be big enough. --- tests/fbo/fbo-drawbuffers-maxtargets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fbo/fbo-drawbuffers-maxtargets.c b/tests/fbo/fbo-drawbuffers-maxtargets.c index f5e2a48ed

[Piglit] [PATCH 2/4] glsl-1.20/fs-deref-literal-array-of-structs-with-multiple-members-large-array: Fix it

2018-09-13 Thread Nicolai Hähnle
From: Nicolai Hähnle Hard to believe that this was never noticed... --- ...f-structs-with-multiple-members-large-array.shader_test | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/spec/glsl-1.20/execution/fs-deref-literal-array-of-structs-with-multiple-members

[Piglit] [PATCH 0/4] Autumn cleaning: misc test case additions and fixes

2018-09-13 Thread Nicolai Hähnle
Hi all, These are a bunch of patches that I've had locally for a while now, hopefully cleaned up enough to be useful :) The big ones are #3 and #4, which add tests for extreme GS and GS+tess amplification cases. Please review! Thanks, Nicolai ___ Pig

Re: [Piglit] [PATCH] arb_compute_variable_group_size: check gl_GlobalInvocationID

2017-10-22 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 21.10.2017 21:21, Ilia Mirkin wrote: An implementation bug in mesa caused these values to be computed incorrectly. Make sure that they work as defined. Signed-off-by: Ilia Mirkin --- .../execution/global-invocation-id.shader_test | 44

Re: [Piglit] [PATCH 11/11] all.py: run ARB_draw_buffers tests concurrently

2017-10-16 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 14.10.2017 05:33, Brian Paul wrote: --- tests/all.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/all.py b/tests/all.py index 046c02b..9f37ba2 100644 --- a/tests/all.py +++ b/tests/all.py @@ -4276,9 +4276,9

Re: [Piglit] [PATCH] all.py: add missing argument to arb_sample_shading-samplemask test

2017-10-16 Thread Nicolai Hähnle
On 14.10.2017 05:49, Brian Paul wrote: As it was, argc != 4 caused the test to print usage info and exit with PIGLIT_FAIL. Fixes bbc27395cfc93d3f3 "arb_sample_shading: add more extensive gl_SampleMask(In) tests". Thanks! Reviewed-by: Nicolai Hähnle --- tests/all.py | 2 +

[Piglit] [RFC 03/10] framework: add Test.name attribute

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle So that we can just pass Test objects around instead of (name, test) pairs. --- framework/backends/abstract.py | 8 framework/profile.py | 26 +++--- framework/programs/run.py | 2 +- framework/test/base.py | 11

[Piglit] [RFC 09/10] framework: allow specifying the number of jobs for concurrency

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle The default remains the same: number of CPUs. But on systems with lots of cores but comparatively little (V)RAM it can make sense to reduce the number of jobs to avoid random failures caused by out-of-memory conditions. --- framework/options.py | 1 + framework

[Piglit] [RFC 10/10] framework/resume: properly parse the no_retry option

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- framework/programs/run.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index bf8a0e612..ecef3dead 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py @@ -380,20

[Piglit] [RFC 05/10] framework: add various helper functions to TestResult

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- framework/results.py | 46 ++ 1 file changed, 46 insertions(+) diff --git a/framework/results.py b/framework/results.py index 26ebbe7a6..c13379b3e 100644 --- a/framework/results.py +++ b/framework/results.py @@ -202,20

[Piglit] [RFC 00/10] Running dEQP tests without process isolation

2017-10-11 Thread Nicolai Hähnle
Hi all, This series allows running dEQP tests (including GL CTS) without process isolation. I've been using it quite successfully for the last few weeks, though there are a bunch of loose ends, off the top of my head: 1. One remaining spurious failure in the `gpu` profile 2. Only tested on gpu, d

[Piglit] [RFC 04/10] framework: fix grouptools.commonprefix when len(args) == 1

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- framework/grouptools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/grouptools.py b/framework/grouptools.py index 2ee74ed9f..1a65c0dcd 100644 --- a/framework/grouptools.py +++ b/framework/grouptools.py @@ -82,21 +82,21 @@ def splitname

[Piglit] [RFC 01/10] framework: refactor subtest handling

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle The old design of TestResult and TestrunResult has two related limitations that prevent us from relaxing process isolation more than what is done for shader tests: 1. A TestResult can only have subtests one level below its 'root' group. 2. If one TestResult wit

[Piglit] [RFC 02/10] framework: update JSON storage format to version 10

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle Reflect the refactoring of TestResult and TestrunResult in the on-disk storage format. --- framework/backends/abstract.py | 6 +++--- framework/backends/json.py | 39 ++- framework/results.py | 17

[Piglit] [RFC 06/10] framework: refactor test running to use explicit TestWorkItems and TestRunners

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle Factor out the execution of tests into TestRunner objects, to allow a cleaner approach to running multiple tests without process isolation. After this patch, which already adapts the shader tests, each individual test is unaffected by whether process isolation is enabled or

[Piglit] [RFC 07/10] framework: add a dEQP runner that can run without process isolation

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- framework/test/deqp.py | 202 ++--- 1 file changed, 141 insertions(+), 61 deletions(-) diff --git a/framework/test/deqp.py b/framework/test/deqp.py index 8627feabb..f62d731b1 100644 --- a/framework/test/deqp.py +++ b/framewor

[Piglit] [RFC 08/10] framework/deqp: allow loading a *-master.txt file as mustpass list

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- framework/test/deqp.py | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/framework/test/deqp.py b/framework/test/deqp.py index f62d731b1..f54135b0e 100644 --- a/framework/test/deqp.py +++ b/framework/test/deqp.py @@ -69,39 +69,49 @@ def

[Piglit] [PATCH 7/7] shader_runner: don't use glMapNamedBufferRange

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle We want to be able to run atomic counter tests even when the DSA entry points are unavailable (e.g. in GLES). --- tests/shaders/shader_runner.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders

[Piglit] [PATCH 6/7] tests/deqp: remove redundant constructors

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- tests/deqp_gles3.py | 4 tests/deqp_vk.py| 3 --- 2 files changed, 7 deletions(-) diff --git a/tests/deqp_gles3.py b/tests/deqp_gles3.py index 210c6e4ed..6441a9600 100644 --- a/tests/deqp_gles3.py +++ b/tests/deqp_gles3.py @@ -81,18 +81,14 @@ _EXTRA_ARGS

[Piglit] [PATCH 5/7] framework: remove outdated comment

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle TestrunResult.from_dict is indeed used at the end of the function. --- framework/backends/json.py | 1 - 1 file changed, 1 deletion(-) diff --git a/framework/backends/json.py b/framework/backends/json.py index 440202612..882169e09 100644 --- a/framework/backends/json.py

[Piglit] [PATCH 4/7] framework: fix a comment

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- framework/profile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 53358868b..a19b4d2d2 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -365,22 +365,22 @@ def load_test_profile

[Piglit] [PATCH 1/7] framework: fix typos in comments

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- framework/backends/abstract.py | 2 +- framework/backends/json.py | 8 framework/core.py | 2 +- framework/grouptools.py| 2 +- framework/profile.py | 2 +- framework/results.py | 2 +- framework/summary/common.py

[Piglit] [PATCH 0/7] framework, shader_runner: misc fixed and cleanups

2017-10-11 Thread Nicolai Hähnle
Hi all, Mostly no-op changes in comments, but a few functional changes as well. Please review! Thanks, Nicolai -- framework/backends/abstract.py | 2 +- framework/backends/json.py | 12 +--- framework/core.py | 2 +- framework/grouptools.py| 2 +- framework/pr

[Piglit] [PATCH 3/7] framework: fix outdated comment

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle --- framework/backends/json.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/framework/backends/json.py b/framework/backends/json.py index c810dcaa5..440202612 100644 --- a/framework/backends/json.py +++ b/framework/backends/json.py @@ -223,22

[Piglit] [PATCH 2/7] framework: fix a comment

2017-10-11 Thread Nicolai Hähnle
From: Nicolai Hähnle See ReducedProcessMixin._run_command: if not self._is_cherry(): ... rerun path ... --- framework/test/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/test/base.py b/framework/test/base.py index e74ea3d38..0b7ebab2e 100644

[Piglit] [PATCH] arb_gpu_shader_int64: test two operands with indirect access simultaneously

2017-10-06 Thread Nicolai Hähnle
From: Nicolai Hähnle This hits a bug in Mesa st/glsl_to_tgsi. --- .../indirect-array-two-accesses.shader_test| 61 ++ 1 file changed, 61 insertions(+) create mode 100644 tests/spec/arb_gpu_shader_int64/execution/indirect-array-two-accesses.shader_test diff --git

[Piglit] [PATCH] arb_gpu_shader_fp64: add tests for frexp() corner cases

2017-10-06 Thread Nicolai Hähnle
From: Nicolai Hähnle The only-{exponent,mantissa} tests hit a bug in Mesa's st/glsl_to_tgsi. --- .../fs-frexp-dvec4-only-exponent.shader_test | 37 + .../fs-frexp-dvec4-only-mantissa.shader_test | 38 + .../fs-frexp-dvec4-variable-index.shader_test

[Piglit] [PATCH] fbo-viewport: fix false error caused by slight rounding differences

2017-09-29 Thread Nicolai Hähnle
From: Nicolai Hähnle This test compares rendering to the window system framebuffer with rendering to an FBO, and it does so by rendering rotated quads. There can be slight differences in rounding if the Y axis is flipped between those buffers causing rendering differences which are permitted by

Re: [Piglit] [PATCH] arb_texture_query_lod: add tolerance for some comparisons

2017-09-19 Thread Nicolai Hähnle
Seems reasonable. Reviewed-by: Nicolai Hähnle On 15.09.2017 00:59, Roland Scheidegger wrote: ping? Am 09.09.2017 um 07:31 schrieb srol...@vmware.com: From: Roland Scheidegger Tolerance was added for the tests a while ago, but it looks like it was forgotten for the nearest_biased test

[Piglit] [PATCH 2/2] arb_sample_shading: run more tests concurrently

2017-09-18 Thread Nicolai Hähnle
From: Nicolai Hähnle There doesn't seem to be a reason for not running those tests concurrently. Looks like they were just missed. --- tests/all.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/all.py b/tests/all.py index 286c01eee..404c13f3e 100644 --- a/

[Piglit] [PATCH 1/2] arb_sample_shading: add more extensive gl_SampleMask(In) tests

2017-09-18 Thread Nicolai Hähnle
From: Nicolai Hähnle Test the interaction of gl_SampleMask and gl_SampleMaskIn with different sample shading rates. It used to fail on radeonsi. --- tests/all.py | 4 + .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 + .../arb_sample_shading

[Piglit] [PATCH 1/2] arb_query_buffer_object: extract some common code for running queries

2017-09-18 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../spec/arb_query_buffer_object/CMakeLists.gl.txt | 2 +- tests/spec/arb_query_buffer_object/common.c| 169 + tests/spec/arb_query_buffer_object/common.h| 58 +++ tests/spec/arb_query_buffer_object/qbo.c | 140

[Piglit] [PATCH 2/2] arb_query_buffer_object: add additional coherency tests

2017-09-18 Thread Nicolai Hähnle
From: Nicolai Hähnle The existing tests only test that shaders receive the query result. The new tests also check for earlier pipeline stages. --- tests/all.py | 1 + .../spec/arb_query_buffer_object/CMakeLists.gl.txt | 1 + tests/spec

[Piglit] [PATCH] arb_arrays_of_arrays: remove an unused variable

2017-09-18 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../execution/atomic_counters/fs-indirect-index.shader_test | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/spec/arb_arrays_of_arrays/execution/atomic_counters/fs-indirect-index.shader_test b/tests/spec/arb_arrays_of_arrays/execution

[Piglit] [PATCH] arb_gpu_shader_fp64: relax ldexp test due to denorms

2017-09-18 Thread Nicolai Hähnle
From: Nicolai Hähnle ldexp(0.5, -1028) will be different from 0.0 on implementations that support denorms. Simply crank up the exponents to exclude the possibility of denorms. --- .../execution/built-in-functions/fs-ldexp-dvec4.shader_test | 8 ++-- 1 file changed, 2 insertions(+), 6

[Piglit] [PATCH v2 3/4] arb_gpu_shader5: add interpolateAt* tests with input in a struct

2017-08-01 Thread Nicolai Hähnle
From: Nicolai Hähnle The fact that this should be allowed was clarified in GLSL 4.60. --- .../fs-interpolateAtCentroid-struct.shader_test| 59 .../fs-interpolateAtOffset-struct.shader_test | 63 ++ .../fs-interpolateAtSample-struct.shader_test

[Piglit] [PATCH v2 1/4] arb_gpu_shader5: add execution tests for interpolateAt* with input in an interface block

2017-08-01 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Timothy Arceri --- ...s-interpolateAtCentroid-block-array.shader_test | 73 + .../fs-interpolateAtCentroid-block.shader_test | 62 ++ .../fs-interpolateAtOffset-block-array.shader_test | 75 ++ .../fs

[Piglit] [PATCH v2 0/4] More interpolateAt*() tests

2017-08-01 Thread Nicolai Hähnle
Now with clarifications that made their way into GLSL 4.60. Please review! Thanks, Nicolai ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH v2 4/4] glsl-4.40: add tests for interpolateAt* with swizzles / array subscripts on vectors

2017-08-01 Thread Nicolai Hähnle
From: Nicolai Hähnle For swizzles, the language changed in GLSL 4.40. For array subscripts, it's not entirely clear whether the clarification wrt interpolant being an l-value should be backdated even earlier or not. Keeping it a 4.40 test should be enough for practical purposes. --- .

[Piglit] [PATCH v2 2/4] arb_gpu_shader5: add interpolateAtSample tests with input in an array

2017-08-01 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Timothy Arceri --- ...nterpolateAtSample-array-nonuniform.shader_test | 59 + ...-interpolateAtSample-array-of-array.shader_test | 76 ++ 2 files changed, 135 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5

[Piglit] [PATCH 2/2] arb_transform_feedback_overflow_query-basic: add any_inverted subtest

2017-07-31 Thread Nicolai Hähnle
From: Nicolai Hähnle There is a bug in VI+ with conditional render for any-stream overflow that depends on whether the condition is inverted or not. --- .../arb_transform_feedback_overflow_query/basic.c| 20 1 file changed, 20 insertions(+) diff --git a/tests/spec

[Piglit] [PATCH 1/2] arb_transform_feedback_overflow_query-basic: fix subtest selection

2017-07-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- tests/spec/arb_transform_feedback_overflow_query/basic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_transform_feedback_overflow_query/basic.c b/tests/spec/arb_transform_feedback_overflow_query/basic.c index 0ca0afe..72b32fb

Re: [Piglit] [PATCH 3/3] arb_gpu_shader5: interpolateAt* must reject inputs in structs

2017-06-20 Thread Nicolai Hähnle
On 20.06.2017 13:32, Nicolai Hähnle wrote: On 19.06.2017 23:46, Ian Romanick wrote: That's actually a little surprising... do other drivers reject this? If so, I'll agree with Timothy that a spec quote would be nice. So, I guess I was going off of what was in the Mesa source alr

Re: [Piglit] [PATCH 3/3] arb_gpu_shader5: interpolateAt* must reject inputs in structs

2017-06-20 Thread Nicolai Hähnle
oint and we simply missed it. More digging needed... Honestly, I'd interpret the spec language above in a way that forbids using struct elements. The other compilers I can test disagree, but both of them aren't exactly known for their high quality... Cheers, Nicolai On 06/16/2017 01:34 PM

[Piglit] [PATCH 1/3] arb_gpu_shader5: add execution tests for interpolateAt* with input in an interface block

2017-06-16 Thread Nicolai Hähnle
From: Nicolai Hähnle --- ...s-interpolateAtCentroid-block-array.shader_test | 73 + .../fs-interpolateAtCentroid-block.shader_test | 62 ++ .../fs-interpolateAtOffset-block-array.shader_test | 75 ++ .../fs-interpolateAtOffset

[Piglit] [PATCH 2/3] arb_gpu_shader5: add interpolateAtSample tests with input in an array

2017-06-16 Thread Nicolai Hähnle
From: Nicolai Hähnle --- ...nterpolateAtSample-array-nonuniform.shader_test | 59 + ...-interpolateAtSample-array-of-array.shader_test | 76 ++ 2 files changed, 135 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs

[Piglit] [PATCH 3/3] arb_gpu_shader5: interpolateAt* must reject inputs in structs

2017-06-16 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../fs-interpolateAtCentroid-struct.frag| 17 + .../fs-interpolateAtOffset-struct.frag | 17 + .../fs-interpolateAtSampler-struct.frag | 17 + 3 files changed, 51 insertions

Re: [Piglit] [PATCH] arb_bindless_texture: add new compiler tests for struct with image arrays

2017-06-07 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 05.06.2017 16:34, Samuel Pitoiset wrote: ping? On 05/25/2017 08:02 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- .../nested-struct-arrays-mismatch-format.frag | 27 .../nested-struct-with-arrays-no-qualifiers.frag

[Piglit] [PATCH 2/4] shader_runner: add "relative probe rect rgba" command

2017-05-03 Thread Nicolai Hähnle
From: Nicolai Hähnle --- tests/shaders/shader_runner.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 39922d3..b990887 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c

[Piglit] [PATCH 0/4] Test gl_PrimitiveID in instanced draws

2017-05-03 Thread Nicolai Hähnle
Hi all, these tests add coverage for checking that gl_PrimitiveID resets at the start of a new instance. Radeon GPUs require a few subtleties in hardware to make sure that works correctly, and we were missing some of them. Please review! Thanks, Nicolai -- tests/shaders/shader_runner.c

[Piglit] [PATCH 1/4] shader_runner: add "draw arrays instanced" command

2017-05-03 Thread Nicolai Hähnle
From: Nicolai Hähnle --- tests/shaders/shader_runner.c | 54 +++ 1 file changed, 34 insertions(+), 20 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 6ac5f98..39922d3 100644 --- a/tests/shaders

[Piglit] [PATCH 3/4] arb_tessellation_shader: test gl_PrimitiveID in instanced draws

2017-05-03 Thread Nicolai Hähnle
From: Nicolai Hähnle These tests expose a couple of bugs related to gl_PrimitiveID in radeonsi with tessellation enabled: - garbage gl_PrimitiveID in fragment shader if no geometry shader is present - gl_PrimitiveIDIn in geometry shaders is not reset at the start of an instance when

[Piglit] [PATCH 4/4] glsl-1.50: test gl_PrimitiveID in fragment shader when instancing is used

2017-05-03 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../primitive-id-no-gs-instanced.shader_test | 60 ++ 1 file changed, 60 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution/primitive-id-no-gs-instanced.shader_test diff --git a/tests/spec/glsl-1.50/execution/primitive-id-no-gs

Re: [Piglit] [PATCH] arb_shader_storage_buffer_object: add member-memory-qualifiers.frag

2017-04-29 Thread Nicolai Hähnle
On 29.04.2017 16:23, Samuel Pitoiset wrote: There is actually no positive test which validates the memory qualifiers with members of shader storage blocks. Nice one. Should using readonly/writeonly variables incorrectly be a compile-time error? Reviewed-by: Nicolai Hähnle Signed-off-by

Re: [Piglit] [PATCH] arb_bindless_texture: add new execution tests with sampler/image arrays

2017-04-28 Thread Nicolai Hähnle
On 28.04.2017 14:17, Samuel Pitoiset wrote: Tests loosely based on arb_arrays_of_arrays but with resident textures/images. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- .../fs-const-index-three-dimensions.shader_test| 45 +++ .../images/fs-struct-non-const

Re: [Piglit] [PATCH 2/2] arb_bindless_texture: add struct-inside-uniform-block.frag compiler tests

2017-04-28 Thread Nicolai Hähnle
On 28.04.2017 11:48, Samuel Pitoiset wrote: The spec doesn't clearly state this, but the spec authors say it's allowed. Signed-off-by: Samuel Pitoiset Both patches: Reviewed-by: Nicolai Hähnle --- .../images/struct-inside-uniform-block.frag

Re: [Piglit] [PATCH 1/6] arb_bindless_texture: test bound samplers/image with glUniform1i()

2017-04-28 Thread Nicolai Hähnle
On 27.04.2017 22:12, Samuel Pitoiset wrote: On 04/27/2017 10:02 PM, Nicolai Hähnle wrote: On 27.04.2017 00:52, Samuel Pitoiset wrote: From section 2.14.16 of the ARB_bindless_texture spec: "When used as uniforms in the default block, the value of sampler variables may be spec

Re: [Piglit] [PATCH 5/6] arb_bindless_texture: add inout-non-matching-type.frag compiler tests

2017-04-27 Thread Nicolai Hähnle
pting the syntax in the first place, so it's fine if they're trivial to optimize away. The execution tests are what checks that later stages of the compiler pipeline are working correctly. With that in mind, patches 2-5 are: Reviewed-by: Nicolai Hähnle On 27/04/17 08:52, Samu

Re: [Piglit] [PATCH 1/6] arb_bindless_texture: test bound samplers/image with glUniform1i()

2017-04-27 Thread Nicolai Hähnle
On 27.04.2017 00:52, Samuel Pitoiset wrote: From section 2.14.16 of the ARB_bindless_texture spec: "When used as uniforms in the default block, the value of sampler variables may be specified with either Uniform1i{v} or UniformHandleui64{v}ARB." From section 2.14.X of the ARB_bind

Re: [Piglit] [PATCH] shader_runner: clean up resident handles at exit time

2017-04-27 Thread Nicolai Hähnle
I wonder whether this should also be cleaned up after each test when running multiple tests at a time. But I don't think we're doing that with textures and other objects either... Reviewed-by: Nicolai Hähnle On 27.04.2017 10:42, Samuel Pitoiset wrote: Signed-off-by: Samue

Re: [Piglit] [PATCH] arb_shader_image_load_store: add memory-qualifier-with-non-image-type.frag

2017-04-27 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 26.04.2017 18:42, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- .../memory-qualifier-with-non-image-type.frag | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 tests/spec/arb_shader_image_load_store/compiler

Re: [Piglit] [PATCH] arb_fragment_shader_interlock: Test image load/store.

2017-04-27 Thread Nicolai Hähnle
- current_alpha) * previous_color Multisampling is also enabled and tested at 2, 4, 8 and 16. Signed-off-by: Plamena Manolova Thanks for the v2! Reviewed-by: Nicolai Hähnle --- tests/all.py | 5 + tests/spec/CMakeLists.txt | 1

Re: [Piglit] [PATCH] arb_shader_image_load_store: add format-layout-with-non-image-type.frag compiler test

2017-04-27 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 26.04.2017 18:28, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- .../format-layout-with-non-image-type.frag | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 tests/spec/arb_shader_image_load_store/compiler

Re: [Piglit] [PATCH] arb_fragment_shader_interlock: Test image load/store.

2017-04-24 Thread Nicolai Hähnle
Hi Plamena, On 24.04.2017 23:04, Manolova, Plamena wrote: [snip] + static const char *fs_text = + "#version 430\n" + "#extension GL_ARB_fragment_shader_interlock: require\n" + "layout(sample_interlock_ordered

Re: [Piglit] [PATCH] arb_fragment_shader_interlock: Test image load/store.

2017-04-23 Thread Nicolai Hähnle
On 19.04.2017 02:58, Plamena Manolova wrote: A test to check whether GL_ARB_fragment_shader_interlock operates as expected. This test simulates blending behaviour by using image loads/stores to a 3D texture. The bledning formula used is: Type: blending result = current_alpha * current_color

Re: [Piglit] [PATCH] arb_enhanced_layouts: Remove unused variable.

2017-04-21 Thread Nicolai Hähnle
; ^ Fixes: b81ecc9d3c68 ("arb_enhanced_layouts: add test for location aliasing across GS vertex streams") Signed-off-by: Vinson Lee Thanks, and sorry for the noise. Reviewed-by: Nicolai Hähnle --- tests/spec/arb_enhanced_layouts/gs-stream-location-aliasing.c | 1 - 1 file changed,

[Piglit] [PATCH v2 3/5] arb_sparse_buffer: add basic rendering test

2017-04-19 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: also add a test where the vbuf is stored outside the committed region Reviewed-by: Alejandro Piñeiro (v1) --- tests/all.py | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 1 + tests/spec/arb_sparse_buffer/basic.c

[Piglit] [PATCH v2 2/5] arb_sparse_buffer: minmax test

2017-04-19 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Alejandro Piñeiro --- tests/all.py | 5 +++ tests/spec/CMakeLists.txt | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 12 ++ tests/spec/arb_sparse_buffer/CMakeLists.txt| 1 + tests/spec

[Piglit] [PATCH v2 1/5] util: add MIN3/MAX3 convenience macros

2017-04-19 Thread Nicolai Hähnle
From: Nicolai Hähnle --- tests/util/piglit-util.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-util.h b/tests/util/piglit-util.h index 7e9c840..b30ae07 100644 --- a/tests/util/piglit-util.h +++ b/tests/util/piglit-util.h @@ -176,20 +176,22 @@ enum piglit_result

[Piglit] [PATCH v2 5/5] arb_sparse_buffer: add tests for various *BufferSubData commands

2017-04-19 Thread Nicolai Hähnle
From: Nicolai Hähnle --- tests/all.py | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 1 + tests/spec/arb_sparse_buffer/buffer-data.c | 593 + 3 files changed, 595 insertions(+) create mode 100644 tests/spec

[Piglit] [PATCH v2 0/5] ARB_sparse_buffer tests (less rudimentary version)

2017-04-19 Thread Nicolai Hähnle
Hi all, some more additions to the sparse buffer tests I posted some time ago. This allows you to stress the commit/uncommit logic and buffer ops. Cheers, Nicolai ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailma

[Piglit] [PATCH v2 4/5] arb_sparse_buffer: add an extended commit test

2017-04-19 Thread Nicolai Hähnle
From: Nicolai Hähnle Test sequences of commit / uncommit. Verify that the committed pages are there and retain their data using ClearNamedBufferData and GetBufferSubData. --- tests/all.py | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 1 + tests

Re: [Piglit] [PATCH] gl-1.4: test some glMultiDrawArrays error conditions

2017-04-18 Thread Nicolai Hähnle
I added some spec quotes before pushing, thanks for taking a look! Cheers, Nicolai On 14.04.2017 10:33, Samuel Pitoiset wrote: On 04/13/2017 09:38 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- tests/all.py | 1 + tests/spec/gl-1.4/CMakeLists.gl.txt

[Piglit] [PATCH] gl-1.4: test some glMultiDrawArrays error conditions

2017-04-13 Thread Nicolai Hähnle
From: Nicolai Hähnle --- tests/all.py | 1 + tests/spec/gl-1.4/CMakeLists.gl.txt| 1 + tests/spec/gl-1.4/multidrawarrays-errors.c | 114 + 3 files changed, 116 insertions(+) create mode 100644 tests/spec/gl-1.4

Re: [Piglit] [PATCH] arb_shader_image_load_store: Create complete textures.

2017-04-11 Thread Nicolai Hähnle
olai Thanks, Dorian 2017-04-05 15:58 GMT+02:00 Nicolai Hähnle mailto:nhaeh...@gmail.com>>: On 05.04.2017 09:55, Dorian Apanel wrote: From: Dorian Apanel mailto:dorian.apanel%2bpig...@gmail.com>> Textures created by image load/store tests are not complete (max

Re: [Piglit] [PATCH] arb_shader_image_load_store: Create complete textures.

2017-04-05 Thread Nicolai Hähnle
On 05.04.2017 09:55, Dorian Apanel wrote: From: Dorian Apanel Textures created by image load/store tests are not complete (max level defaults to 1000). Load/Store on incomplete textures should return zeros/change nothing. This fix sets proper base and max level of textures. Signed-off-by: Dor

Re: [Piglit] [PATCH] arb_texture_buffer_range: test glTexBufferRange() with wrong target

2017-04-05 Thread Nicolai Hähnle
On 04.04.2017 14:50, Samuel Pitoiset wrote: From OpenGL 4.5 spec, section 8.9 Buffer Textures: "An INVALID_ENUM error is generated if the effective target is not TEXTURE_BUFFER." Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- tests/spec/arb_texture_bu

Re: [Piglit] [PATCH] glslparsertest: Add test case for FDO bug #100438.

2017-04-03 Thread Nicolai Hähnle
On 01.04.2017 01:25, Vinson Lee wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100438 Signed-off-by: Vinson Lee Reviewed-by: Nicolai Hähnle --- tests/glslparsertest/glsl2/fdo100438.frag | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 tests

Re: [Piglit] [PATCH] arb_cull_distance: Fix sometimes-uninitialized warnings.

2017-04-03 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 01.04.2017 01:27, Vinson Lee wrote: exceed-limits.c:75:6: warning: variable 'clip_distances' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (strcmp(a

Re: [Piglit] [PATCH] glsl: update assumption in array out of bounds test

2017-04-03 Thread Nicolai Hähnle
On 03.04.2017 02:01, Timothy Arceri wrote: On 31/03/17 17:30, Nicolai Hähnle wrote: On 31.03.2017 01:53, Timothy Arceri wrote: Section 5.7 of the GLSL 4.5 spec says: "Behavior is undefined if a shader subscripts an array with an index less than 0 or greater than or equal to the

[Piglit] [PATCH 5/6] arb_shader_ballot: test ballotARB inside if/else control flow

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../execution/fs-ballot-if-else.shader_test| 83 ++ 1 file changed, 83 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/execution/fs-ballot-if-else.shader_test diff --git a/tests/spec/arb_shader_ballot/execution/fs-ballot-if

[Piglit] [PATCH 4/6] arb_shader_ballot: test builtin variables

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../execution/fs-builtin-variables.shader_test | 58 ++ 1 file changed, 58 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/execution/fs-builtin-variables.shader_test diff --git a/tests/spec/arb_shader_ballot/execution/fs-builtin

[Piglit] [PATCH 6/6] arb_shader_ballot: test peeling away the first invocation

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../fs-readFirstInvocation-uint-if.shader_test | 32 ++ .../fs-readFirstInvocation-uint-loop.shader_test | 49 ++ 2 files changed, 81 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/execution/fs-readFirstInvocation

[Piglit] [PATCH 2/6] arb_shader_ballot: add readInvocationARB tests

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../fs-readInvocation-uint-uniform.shader_test | 39 ++ .../execution/fs-readInvocation-uint.shader_test | 37 2 files changed, 76 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/execution/fs-readInvocation

[Piglit] [PATCH 0/6] ARB_shader_ballot tests

2017-03-31 Thread Nicolai Hähnle
Hi, this series adds some basic tests for the builtin functions and variables of the ARB_shader_ballot extension. I have only tested this against my own work-in-progress implementation. If somebody got to test it against the AMD or Nvidia blobs, that would be much appreciated. Please review! Th

[Piglit] [PATCH 3/6] arb_shader_ballot: add readFirstInvocationARB test

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- ...fs-readFirstInvocation-uint-uniform.shader_test | 39 .../fs-readFirstInvocation-uint.shader_test| 52 ++ 2 files changed, 91 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/execution/fs-readFirstInvocation

[Piglit] [PATCH 1/6] arb_shader_ballot: simple ballotARB execution test

2017-03-31 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../execution/fs-ballot.shader_test| 28 ++ 1 file changed, 28 insertions(+) create mode 100644 tests/spec/arb_shader_ballot/execution/fs-ballot.shader_test diff --git a/tests/spec/arb_shader_ballot/execution/fs-ballot.shader_test

Re: [Piglit] [PATCH] arb_shader_clock: add basic execution tests

2017-03-30 Thread Nicolai Hähnle
On 30.03.2017 15:03, Ilia Mirkin wrote: On Thu, Mar 30, 2017 at 8:19 AM, Nicolai Hähnle wrote: On 30.03.2017 14:07, Ilia Mirkin wrote: Time could roll over... not sure what to do about that though. Maybe check if the top 2 bits are set in the old value and are unset in the new value, and

Re: [Piglit] [PATCH] glsl: update assumption in array out of bounds test

2017-03-30 Thread Nicolai Hähnle
On 31.03.2017 01:53, Timothy Arceri wrote: Section 5.7 of the GLSL 4.5 spec says: "Behavior is undefined if a shader subscripts an array with an index less than 0 or greater than or equal to the size the array was declared with." So we cannot be sure which path the shader will take. Up

[Piglit] [PATCH] arb_gpu_shader_int64: add bit-shift tests

2017-03-30 Thread Nicolai Hähnle
From: Nicolai Hähnle Exposes a bug in st/glsl_to_tgsi. --- .../fs-shift-scalar-by-scalar.shader_test | 78 ++ .../fs-shift-vector-by-scalar.shader_test | 77 + .../fs-shift-vector-by-vector.shader_test | 77

Re: [Piglit] [PATCH] arb_shader_clock: add basic execution tests

2017-03-30 Thread Nicolai Hähnle
lures in these tests...] Shouldn't roll-over be covered by the cast to int followed by comparison with 0? Cheers, Nicolai On Thu, Mar 30, 2017 at 3:23 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- .../arb_shader_clock/execution/clock.shader_test | 54 +++

[Piglit] [PATCH] arb_shader_clock: add basic execution tests

2017-03-30 Thread Nicolai Hähnle
From: Nicolai Hähnle --- .../arb_shader_clock/execution/clock.shader_test | 54 +++ .../execution/clock2x32.shader_test| 63 ++ 2 files changed, 117 insertions(+) create mode 100644 tests/spec/arb_shader_clock/execution/clock.shader_test

Re: [Piglit] [RFC PATCH 0/5] Add tests for ARB_bindless_texture

2017-03-29 Thread Nicolai Hähnle
On 28.03.2017 00:05, Samuel Pitoiset wrote: Hi, This series introduces some tests for ARB_bindless_texture. The series has been splitted into 4 different parts to try to help reviewers because it's a bunch of new code. Although this seems huge at first look, I don't cover 100% of the spec but I

Re: [Piglit] [RFC PATCH 3/5] arb_bindless_texture: add compiler-related tests

2017-03-29 Thread Nicolai Hähnle
On 29.03.2017 01:09, Samuel Pitoiset wrote: diff --git a/tests/spec/arb_bindless_texture/compiler/images/indexing.vert b/tests/spec/arb_bindless_texture/compiler/images/indexing.vert new file mode 100644 index 0..dd865b22f --- /dev/null +++ b/tests/spec/arb_bindless_texture/compiler/image

[Piglit] [PATCH] get-active-attrib-array: allocate a sufficiently large buffer

2017-02-22 Thread Nicolai Hähnle
From: Nicolai Hähnle Found by ASAN. --- tests/spec/glsl-1.50/execution/get-active-attrib-array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/glsl-1.50/execution/get-active-attrib-array.c b/tests/spec/glsl-1.50/execution/get-active-attrib-array.c index e2d4e64

Re: [Piglit] [PATCH] draw-elements: test glMultiDrawElements(GL_UNSIGNED_BYTE)

2017-02-19 Thread Nicolai Hähnle
Thanks for doing this. Reviewed-by: Nicolai Hähnle On 17.02.2017 13:08, Marek Olšák wrote: From: Marek Olšák this was broken in radeonsi --- tests/general/draw-elements.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/tests/general

Re: [Piglit] [PATCH] glsl-shaders: test correct shader source is use on cache fallback

2017-02-16 Thread Nicolai Hähnle
ounds glsl-uniform-out-of-bounds.c) diff --git a/tests/shaders/glsl-cache-fallback-shader-source.c b/tests/shaders/glsl-cache-fallback-shader-source.c new file mode 100644 index 000..f764617 --- /dev/null +++ b/tests/shaders/glsl-cache-fallback-shader-source.c @@ -0,0 +1,187 @@ +/

[Piglit] [PATCH 1/2] arb_sparse_buffer: minmax test

2017-02-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- tests/all.py | 5 +++ tests/spec/CMakeLists.txt | 1 + tests/spec/arb_sparse_buffer/CMakeLists.gl.txt | 12 ++ tests/spec/arb_sparse_buffer/CMakeLists.txt| 1 + tests/spec/arb_sparse_buffer/minmax.c

  1   2   3   >