[Piglit] [PATCH] framework/programs/run.py: Allow comments in test-list files.

2016-10-17 Thread Petri Latvala
IGT testing in Intel's CI is using a static list of tests to run. Commenting out tests and annotating them will help human-readability. Signed-off-by: Petri Latvala --- Possible duplicate, I didn't see this arrive on the mailing list myself framework/programs/run.py | 5 +++-- 1 fi

[Piglit] [PATCH] framework/programs/run.py: Allow comments in test-list files.

2017-02-01 Thread Petri Latvala
IGT testing in Intel's CI is using static lists of tests to run. Commenting out tests and annotating them will help human-readability. v2: Use comprehensions (Dylan) CC: Dylan Baker Signed-off-by: Petri Latvala --- Here's a version with comprehensions. Tested and verified locally.

Re: [Piglit] [PATCH] framework/programs/run.py: Allow comments in test-list files.

2017-02-02 Thread Petri Latvala
On 02/01/2017 08:36 PM, Dylan Baker wrote: This look good, thanks for making the changes. Do you have push access or should I push this for you? Reviewed-by: Dylan Baker I don't think I have access. If you'd be so kind? -- Pet

[Piglit] [PATCH] framework: change one missed core.checkDir call to core.check_dir

2017-04-13 Thread Petri Latvala
Commit 5e699e402a8b ("framework: rename core.checkDir to core.check_dir") missed one call to checkDir in summary/feature. Signed-off-by: Petri Latvala --- Does this also need exception handling changes like was done in aaf55584a42d ("framework: core.checkDir raises

Re: [Piglit] [PATCH 3/3] framework: Exit if a filter removes all tests from a profile

2017-06-20 Thread Petri Latvala
by this commit with IGT tests. When the last test of a run never finishes and you attempt to piglit resume -n test-results-path this exception is raised instead of the expected result of finishing up the run. -- Petri Latvala ___ Piglit mailing

Re: [Piglit] [PATCH 3/3] framework: Exit if a filter removes all tests from a profile

2017-06-21 Thread Petri Latvala
On 06/20/2017 08:59 PM, Dylan Baker wrote: Quoting Petri Latvala (2017-06-20 05:41:11) On 04/13/2017 09:46 PM, Dylan Baker wrote: Quoting Brian Paul (2017-04-12 13:04:59) On 04/12/2017 11:55 AM, Dylan Baker wrote: It doesn't makes sense to run if a user has removed all tests from a sel

[Piglit] [PATCH v2 1/1] framework: change one missed core.checkDir call to core.check_dir

2018-03-22 Thread Petri Latvala
Commit 5e699e402a8b ("framework: rename core.checkDir to core.check_dir") missed one call to checkDir in summary/feature. Also convert the exception raised to PiglitFatalError. v2: Added exception changes Signed-off-by: Petri Latvala Cc: Dylan Baker Cc: Jari Tahvanainen ---

[Piglit] [PATCH v3 1/1] framework: change one missed core.checkDir call to core.check_dir

2018-03-23 Thread Petri Latvala
Commit 5e699e402a8b ("framework: rename core.checkDir to core.check_dir") missed one call to checkDir in summary/feature. Also convert the exception raised to PiglitFatalError. v2: Added exception changes v3: Fixed indentation Signed-off-by: Petri Latvala Cc: Dylan Baker Cc: Jari T

Re: [Piglit] [PATCH v3 1/1] framework: change one missed core.checkDir call to core.check_dir

2018-03-26 Thread Petri Latvala
On 03/23/2018 06:11 PM, Dylan Baker wrote: Quoting Petri Latvala (2018-03-23 03:11:10) Commit 5e699e402a8b ("framework: rename core.checkDir to core.check_dir") missed one call to checkDir in summary/feature. Also convert the exception raised to PiglitFatalError. v2: Added excepti

[Piglit] [PATCH 3/3] Add tests for the INTEL_performance_query extension.

2014-03-12 Thread Petri Latvala
. Signed-off-by: Petri Latvala --- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + .../spec/intel_performance_query/CMakeLists.gl.txt | 14 + tests/spec/intel_performance_query/CMakeLists.txt | 1 + tests/spec

[Piglit] [PATCH 0/3] Tests for INTEL_performance_query

2014-03-12 Thread Petri Latvala
This patch series is for testing INTEL_performance_query. The tests are based on the tests for AMD_performance_monitor. Tested with Mesa (patches for implementing this extension in Mesa are sent to mesa-dev). All tests pass. Petri Latvala (3): glapi: Support for INTEL_performance_query. util

[Piglit] [PATCH 1/3] glapi: Support for INTEL_performance_query.

2014-03-12 Thread Petri Latvala
Signed-off-by: Petri Latvala --- glapi/enum.spec | 22 ++ glapi/gl.spec | 132 +++- 2 files changed, 153 insertions(+), 1 deletion(-) diff --git a/glapi/enum.spec b/glapi/enum.spec index c854b91..e0ac933 100644 --- a/glapi/enum.spec

[Piglit] [PATCH 2/3] util: Add INTEL_performance_query support to piglit_get_gl_enum_name().

2014-03-12 Thread Petri Latvala
Signed-off-by: Petri Latvala --- tests/util/piglit-util-gl-enum.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/util/piglit-util-gl-enum.c b/tests/util/piglit-util-gl-enum.c index 8deb58f..43032ad 100644 --- a/tests/util/piglit-util-gl-enum.c +++ b/tests/util/piglit-util-gl-enum.c

Re: [Piglit] [PATCH] ARB_explicit_uniform_location: test inactive uniform interaction

2014-03-24 Thread Petri Latvala
the Nvidia proprietary driver for Linux version 319.32 because the uniform does not get the location. To my reading of the spec, glGetUniformLocation can return -1 for the inactive explicit-located uniform. And even if it's inactive, no _other_ uniform can get that location. -- Petri La

Re: [Piglit] [PATCH] ES spec section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector a

2014-04-09 Thread Petri Latvala
have been previously declared. I'm not sure I understand what this patch fixes. I thought the "precision mediump float;" declaration that is present in all those tests is enough. -- Petri Latvala ___ Piglit mailing list Piglit@l

Re: [Piglit] [PATCH] ES spec section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector a

2014-04-09 Thread Petri Latvala
On 04/09/2014 11:13 AM, Guo, Johney wrote: > > Yes. You are right, either “precision mediump float;" or “highp” will > be OK. > > But you can’t leave it as unknown precision qualifer. > > My point was that it isn't left unknown in these tests. What am

[Piglit] [PATCH] Add basic execution tests for GL_AMD_shader_trinary_minmax.

2014-04-30 Thread Petri Latvala
Signed-off-by: Petri Latvala --- These three tests are very simple tests for GL_AMD_shader_trinary_minmax functions that I used for regression-testing Mesa optimizations when constants are involved in the calls. Tested on Mesa/Haswell, the tests pass. I will need someone to push this if it&#