Re: [Piglit] [PATCH v3 4/4] framework/test/base.py: use subprocess32 for timeouts.

2015-12-01 Thread Thomas Wood
On 30 November 2015 at 18:34, Dylan Baker <baker.dyla...@gmail.com> wrote: > On Fri, Nov 27, 2015 at 12:04:34PM +0000, Thomas Wood wrote: >> On 12 November 2015 at 22:52, <baker.dyla...@gmail.com> wrote: >> > From: Dylan Baker <baker.dyla...@gmail.com> >&g

Re: [Piglit] [PATCH v3 4/4] framework/test/base.py: use subprocess32 for timeouts.

2015-11-27 Thread Thomas Wood
On 12 November 2015 at 22:52, wrote: > From: Dylan Baker > > Subprocess32 provides a backport of (ironically) python 3.3's subprocess > module, which has a timeout parameter. When the timeout runs out then an > exception is raised, and when that

Re: [Piglit] [PATCH] Add support for feature readiness.

2015-10-27 Thread Thomas Wood
On 27 October 2015 at 14:23, Gabriel Feceoru wrote: > This adds a new "feat-summary" command to piglit which creates a HTML table The summary command already has several format options. Couldn't this be added as just an additional option to the existing command? Adding

Re: [Piglit] [PATCH v2 6/6] framework/test/base.py: use subprocess32 for timeouts.

2015-10-26 Thread Thomas Wood
On 24 October 2015 at 02:17, wrote: > From: Dylan Baker > > Subprocess32 provides a backport of (ironically) python 3.3's subprocess > module, which has a timeout parameter. When the timeout runs out then an > exception is raised, and when that

Re: [Piglit] [PATCH 2/2] framework/test/base.py: try to use subprocess32

2015-10-15 Thread Thomas Wood
On 14 October 2015 at 22:35, Dylan Baker <baker.dyla...@gmail.com> wrote: > On Wed, Oct 14, 2015 at 04:27:56PM +0100, Thomas Wood wrote: >> On 9 October 2015 at 20:53, <baker.dyla...@gmail.com> wrote: >> > From: Dylan Baker <baker.dyla...@gmail.com> >> &g

Re: [Piglit] [PATCH 2/2] framework/test/base.py: try to use subprocess32

2015-10-14 Thread Thomas Wood
On 9 October 2015 at 20:53, wrote: > From: Dylan Baker > > This adds subprocess32 as an optional dependency to get timeouts. This > module is a backport of the feature from python 3.2 that adds the > timeout argument to Popen.communicate (among

Re: [Piglit] [PATCH] framework/core: add fallback to PiglitConfig.safe_get

2015-09-23 Thread Thomas Wood
an Baker <dylanx.c.ba...@intel.com> Reviewed-by: Thomas Wood <thomas.w...@intel.com> > --- > > This would actually be pretty useful in a number of cases in piglit > currently, and a few patches on the mailing list. > > framework/core.py | 6 +++--- &

Re: [Piglit] [PATCH 1/2] framework/log: declare the state and state lock together

2015-09-23 Thread Thomas Wood
and **kwargs when overriding __init__, but it does break the dummy logger. I've sent a new version of the patch with this fixed. > > On Tue, Sep 22, 2015 at 05:22:23PM +0100, Thomas Wood wrote: >> Declare the state and state lock variables at the same time so that the >> sam

[Piglit] [PATCH v3 2/2] framework/log: add an HTTP logger

2015-09-23 Thread Thomas Wood
ration option to set the server port v3: Use the new fallback parameter of safe_get Convert the test result status back to string Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- framework/log.py | 72 +++ framework/programs/run.p

[Piglit] [PATCH v3 1/2] framework/log: declare the state and state lock together

2015-09-23 Thread Thomas Wood
Declare the state and state lock variables at the same time so that the same lock can be always used when accessing the state variable. v2: fix dummy logger Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- framework/log.py | 10 ++ 1 file changed, 6 insertions(+), 4 del

Re: [Piglit] [PATCH 2/2] framework/log: add an HTTP logger

2015-09-23 Thread Thomas Wood
d. > > On Tue, Sep 22, 2015 at 05:22:24PM +0100, Thomas Wood wrote: >> Add an HTTP logger so that it is possible to monitor the progress and >> status of piglit remotely through a webserver. The webserver runs on >> port 8080 by default and can be configured to run on

[Piglit] [PATCH 2/2] framework/log: add an HTTP logger

2015-09-22 Thread Thomas Wood
ration option to set the server port Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- framework/log.py | 76 +++ framework/programs/run.py | 2 +- 2 files changed, 77 insertions(+), 1 deletion(-) diff --git a/framework/log.py b/fram

[Piglit] [PATCH 1/2] framework/log: declare the state and state lock together

2015-09-22 Thread Thomas Wood
Declare the state and state lock variables at the same time so that the same lock can be always used when accessing the state variable. Signed-off-by: Thomas Wood <thomas.w...@intel.com> --- framework/log.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fra

Re: [Piglit] [PATCH] framework/log: add an HTTP logger

2015-09-22 Thread Thomas Wood
On 21 September 2015 at 19:13, Dylan Baker <baker.dyla...@gmail.com> wrote: > On Mon, Sep 21, 2015 at 05:06:17PM +0100, Thomas Wood wrote: >> Add an HTTP logger so that it is possible to monitor the progress and status >> of >> piglit remotely through a webserver. The

[Piglit] [PATCH] framework/log: add an HTTP logger

2015-09-21 Thread Thomas Wood
Add an HTTP logger so that it is possible to monitor the progress and status of piglit remotely through a webserver. The webserver runs on port 8080 and responds to requests for /summary and /results, which provide the current summary and results in JSON format. --- Sometimes it is useful to be

Re: [Piglit] [PATCH] framework: add a timeout command line parameter

2015-07-20 Thread Thomas Wood
On 13 July 2015 at 23:09, Dylan Baker baker.dyla...@gmail.com wrote: On Mon, Jul 13, 2015 at 02:09:26PM +0100, Thomas Wood wrote: On 10 July 2015 at 19:24, Dylan Baker baker.dyla...@gmail.com wrote: Hi Thomas, I meant to get back to you earlier on this, but I forgot yesterday when

Re: [Piglit] [PATCH] framework: add a timeout command line parameter

2015-07-13 Thread Thomas Wood
or increased. Dylan On Thu, Jul 09, 2015 at 06:05:56PM +0100, Thomas Wood wrote: Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/core.py | 6 +- framework/programs/run.py | 8 ++-- framework/test/base.py| 7 +++ framework/tests

[Piglit] [PATCH] framework: add a timeout command line parameter

2015-07-09 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/core.py | 6 +- framework/programs/run.py | 8 ++-- framework/test/base.py| 7 +++ framework/tests/base_tests.py | 2 +- tests/igt.py | 3 ++- 5 files changed, 17 insertions(+), 9

[Piglit] [PATCH] summary: fix processing of incomplete results in csv output

2015-06-29 Thread Thomas Wood
Incomplete results do not include a time or return code, so use a blank string as the default value for these keys. Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/programs/summary.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/framework/programs

[Piglit] [PATCH 1/2] json.py: use the existing filename when updating results version

2015-04-23 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/backends/json.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/framework/backends/json.py b/framework/backends/json.py index affd64e..d68dd7d 100644 --- a/framework/backends/json.py +++ b/framework/backends

[Piglit] [PATCH] json.py: don't rename the results file when updating results version

2015-04-21 Thread Thomas Wood
Keep the existing results file name if the results input was a file rather than a directory. Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/backends/json.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/framework/backends/json.py b/framework

[Piglit] [PATCH 2/2] igt.py: don't check the environment when in dry-run mode

2015-03-26 Thread Thomas Wood
Don't exit during the post run hook if the environment check fails and dry-run mode is enabled. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/igt.py b/tests/igt.py index 8c7963b..8ffac8d 100644

[Piglit] [PATCH 1/2] profile.py: pass options to the pre and post run hooks

2015-03-26 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/profile.py | 12 tests/igt.py | 2 +- tests/xts.py | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 603e872..1384bbd 100644

[Piglit] [PATCH] tests/igt.py: read a single combined test list

2015-03-13 Thread Thomas Wood
All tests now respond in a consistent way such that separate lists for tests with and without subtests are no longer necessary. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/igt.py b

Re: [Piglit] [Patch v3 1/8] igt.py: Fix whitepace warnings for pylint

2015-03-09 Thread Thomas Wood
On 6 March 2015 at 18:45, Dylan Baker baker.dyla...@gmail.com wrote: On Fri, Mar 06, 2015 at 05:20:37PM +, Thomas Wood wrote: On 5 March 2015 at 18:19, Dylan Baker baker.dyla...@gmail.com wrote: Hey Thomas, did you have any more comments on this series, or is it good to land? I ask

Re: [Piglit] [Patch v3 1/8] igt.py: Fix whitepace warnings for pylint

2015-03-06 Thread Thomas Wood
On 5 March 2015 at 18:19, Dylan Baker baker.dyla...@gmail.com wrote: Hey Thomas, did you have any more comments on this series, or is it good to land? I ask because I'm working on python3 porting, an landing this will make a lot of that work easier. Apart from a small fix to patch 4, the

Re: [Piglit] [Patch v3 4/8] igt.py: fix invalid name errors

2015-03-06 Thread Thomas Wood
On 28 January 2015 at 19:35, Dylan Baker baker.dyla...@gmail.com wrote: Make constants all caps, per PEP8, make functions all lowercase with underscores, and move some toplevel work into helper functions. v2: - drop one pylint disable line that wasn't needed (Thomas) Signed-off-by: Dylan

Re: [Piglit] [Patch v2 6/8] igt.py: add docstrings.

2015-01-28 Thread Thomas Wood
On 26 January 2015 at 19:28, Dylan Baker baker.dyla...@gmail.com wrote: In some cases this is really just about formatting. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- tests/igt.py | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git

[Piglit] [PATCH] tests/igt.py: don't run tests if the environment check failed

2015-01-27 Thread Thomas Wood
to resumed test runs. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index e65b8a9..bd4c70e 100644 --- a/tests/igt.py +++ b/tests/igt.py @@ -74,9 +74,14

Re: [Piglit] [PATCH 6/6] igt.py: Use __future__ functions, mainly print_function

2015-01-23 Thread Thomas Wood
On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: This makes igt more like the rest of piglit which uses the __future__ version of print, division, and import Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- tests/igt.py | 13 +++-- 1 file changed, 7

Re: [Piglit] [PATCH 4/6] tests/igt.py: fix invalid name errors

2015-01-23 Thread Thomas Wood
On 23 January 2015 at 17:10, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, January 23, 2015 15:02:44 Thomas Wood wrote: On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: Make constants all caps, per PEP8, make functions all lowercase with underscores, and move

Re: [Piglit] [PATCH 3/6] tests/igt.py: simplify setting the root

2015-01-23 Thread Thomas Wood
On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: This uses dict.get() to simplify and streamline the logic. --- tests/igt.py | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index 55b0f4a..f0064fc

Re: [Piglit] [PATCH 1/6] test/igt.py: Fix whitepace warnings for pylint

2015-01-23 Thread Thomas Wood
On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: --- tests/igt.py | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index e65b8a9..4d76636 100644 --- a/tests/igt.py +++ b/tests/igt.py @@ -129,22

Re: [Piglit] [PATCH 4/6] tests/igt.py: fix invalid name errors

2015-01-23 Thread Thomas Wood
On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: Make constants all caps, per PEP8, make functions all lowercase with underscores, and move some toplevel work into helper functions. This lowers the pylint warnings to just missing docstrings. --- tests/igt.py | 28

[Piglit] [PATCH] run.py: add an option to load a test list from a file

2014-11-28 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/programs/run.py | 8 1 file changed, 8 insertions(+) diff --git a/framework/programs/run.py b/framework/programs/run.py index ac96d2e..89ccd11 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py @@ -180,6

[Piglit] [PATCH] summary: add a csv output option

2014-10-01 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/programs/summary.py | 32 +++- piglit| 4 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/framework/programs/summary.py b/framework/programs/summary.py index

Re: [Piglit] [PATCH] framework: add a generic timeout mechanism

2014-09-26 Thread Thomas Wood
to Test._run_command (protected instead of private), which would allow you to modify it in a subclass. Dylan. On Wednesday, September 17, 2014 03:25:53 PM Thomas Wood wrote: The timeout mechanism within igt.py can no longer be used since get_command_result was renamed and made private

[Piglit] [PATCH] framework/tests: add a test for the timeout mechanism

2014-09-25 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/tests/exectest_test.py | 20 1 file changed, 20 insertions(+) diff --git a/framework/tests/exectest_test.py b/framework/tests/exectest_test.py index 935719d..ebe02a4 100644 --- a/framework/tests/exectest_test.py

[Piglit] [PATCH 2/2] run.py: fix typos in resume finished message

2014-09-19 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/programs/run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index dbd4431..da38aca 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py

Re: [Piglit] [PATCH] framework: add a generic timeout mechanism

2014-09-17 Thread Thomas Wood
it if needed and also avoiding code duplication between igt.py and exectest.py. Cc: Dylan Baker baker.dyla...@gmail.com Cc: Chad Versace chad.vers...@linux.intel.com Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/exectest.py | 67 +++-- framework

[Piglit] [PATCH] framework: add a generic timeout mechanism

2014-09-17 Thread Thomas Wood
was abnormally terminated. Cc: Dylan Baker baker.dyla...@gmail.com Cc: Chad Versace chad.vers...@linux.intel.com Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/exectest.py | 78 -- tests/igt.py | 93

[Piglit] [PATCH] framework: add a generic timeout mechanism

2014-09-09 Thread Thomas Wood
and also avoiding code duplication between igt.py and exectest.py. Cc: Dylan Baker baker.dyla...@gmail.com Cc: Chad Versace chad.vers...@linux.intel.com Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/exectest.py | 67 +++-- framework/profile.py | 3

[Piglit] [PATCH 2/2] piglit-print-commands: make sure piglit.conf is read

2014-07-16 Thread Thomas Wood
Some test profiles require configuration values from piglit.conf before they can enumerate the tests. Signed-off-by: Thomas Wood thomas.w...@intel.com --- piglit-print-commands.py | 1 + 1 file changed, 1 insertion(+) diff --git a/piglit-print-commands.py b/piglit-print-commands.py index

[Piglit] [PATCH 1/2] framework: move get_config() to core

2014-07-16 Thread Thomas Wood
Move framework.programs.run._get_config() to framework.core.get_config() so that it can be used elsewhere. Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/core.py| 23 +++ framework/programs/run.py| 27

[Piglit] [PATCH] framework: fix summary totals when multiple results are specified

2014-07-14 Thread Thomas Wood
Ensure the correct totals are displayed for each result summary when multiple results are specified. Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/summary.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/framework/summary.py b/framework

[Piglit] [PATCH] tests/igt.py: fix various pylint warnings

2014-06-19 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index a970413..49ec64f 100644 --- a/tests/igt.py +++ b/tests/igt.py @@ -29,10 +29,10 @@ import

Re: [Piglit] piglit-summary-html.py currently broken

2014-06-17 Thread Thomas Wood
this to the following commit: commit 6755d9195bc05bbee2445eeac6af6b0e0ecf5160 Author: Thomas Wood thomas.w...@intel.com Date: Wed Jun 4 11:07:30 2014 +0100 templates: add the totals to testrun_info Add the totals to the testrun_info template, including the total number of tests evaluated

[Piglit] [PATCH] templates: add the totals to testrun_info

2014-06-04 Thread Thomas Wood
Add the totals to the testrun_info template, including the total number of tests evaluated. Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/summary.py| 3 +++ templates/testrun_info.mako | 11 +++ 2 files changed, 14 insertions(+) diff --git a/framework

[Piglit] [PATCH 1/2] tests/igt.py: read IGT_TEST_ROOT to determine the location of the tests

2014-06-02 Thread Thomas Wood
Allow the IGT_TEST_ROOT environment variable to specify the location of the intel-gpu-tools tests. Check for the presence of the test lists to determine whether the location is correct. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 19 ++- 1 file changed, 14

[Piglit] [PATCH 2/2] tests/igt.py: remove the fallback test enumeration option

2014-06-02 Thread Thomas Wood
The test list files are now required when determining the correct location of the tests, so remove the fallback option of using make to enumerate the tests. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions

[Piglit] [PATCH] tests/igt.py: check for pass or skip before timeout

2014-05-06 Thread Thomas Wood
Don't wait for the timeout thread if the process has already quit with pass or skip status. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/igt.py b/tests/igt.py index 7cfb6ad..7f815fe 100644

[Piglit] [PATCH] framework/dmesg.py: add a filtering mechanism

2014-05-06 Thread Thomas Wood
Only update the test status if at least one of the lines in the dmesg output matches the given regular expression. v2: Style changes suggested by Ilia Mirkin and Dylan Baker Add a framework test for dmesg filtering Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/dmesg.py

[Piglit] [PATCH 2/2] tests/igt.py: discard dmesg output that does not match certain keywords

2014-04-30 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/igt.py b/tests/igt.py index 7cfb6ad..d8dfa15 100644 --- a/tests/igt.py +++ b/tests/igt.py @@ -256,3 +256,6 @@ for test in multiTests: addSubTestCases(test

[Piglit] [PATCH 1/2] framework/dmesg.py: add a filtering mechanism

2014-04-30 Thread Thomas Wood
Only update the test status if at least one of the lines in the dmesg output matches the given regular expression. Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/dmesg.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/framework/dmesg.py b/framework/dmesg.py

[Piglit] [PATCH] framework: use formatted time values in the HTML report

2014-04-28 Thread Thomas Wood
v2: update for the changes to the test result template and check for None in the summary index time value Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/summary.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/framework/summary.py b/framework

Re: [Piglit] [PATCH 1/2] framework: add support for a timeout status

2014-04-24 Thread Thomas Wood
a normal Status class. If placed just above the crash status this would mean most status changes to timeout would be a regression. Lastly, you need to add TIMEOUT to ALL = ... at the very end of framework/status.py On Wed, Apr 23, 2014 at 12:29 PM, Thomas Wood thomas.w...@intel.com wrote: v2

[Piglit] [PATCH] framework: add support for a timeout status

2014-04-24 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com Cc: Daniel Vetter daniel.vet...@ffwll.ch --- framework/log.py | 3 ++- framework/status.py | 12 framework/summary.py | 6 -- framework/tests/status_tests.py | 3 ++- framework/tests

Re: [Piglit] [PATCH 1/2] framework: add support for a timeout status

2014-04-24 Thread Thomas Wood
The following revised patch reverts to using a normal Status class for the timeout status and also adds a few tests to summary_tests.py, as suggested by Ilia Mirkin. Thomas Wood (1): framework: add support for a timeout status framework/log.py | 3 ++- framework/status.py

Re: [Piglit] [PATCH] tests/igt.py: add support for reading the test list from the file system

2014-04-03 Thread Thomas Wood
On 2 April 2014 18:15, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday, April 02, 2014 16:12:23 Thomas Wood wrote: Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff

[Piglit] [PATCH] tests/igt.py: add support for reading the test list from the file system

2014-04-02 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index f80a6c4..4640814 100644 --- a/tests/igt.py +++ b/tests/igt.py @@ -98,21 +98,30

[Piglit] [PATCH v2 1/3] framework/log.py: ensure any previous output is cleared

2014-03-27 Thread Thomas Wood
If the new summary line is shorter than the previous one, clear the remaining characters. v2: remove unused variable and use str.format (Dylan Baker) Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/log.py | 19 ++- 1 file changed, 14 insertions(+), 5 deletions

[Piglit] [PATCH v2 2/3] framework: print a summary line after a run has finished

2014-03-27 Thread Thomas Wood
v2: split output writing into a private method (Dylan Baker) Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/core.py | 2 ++ framework/log.py | 44 +++- 2 files changed, 29 insertions(+), 17 deletions(-) diff --git a/framework/core.py b

[Piglit] [PATCH v2 3/3] Remove extra newline from the end of run message

2014-03-27 Thread Thomas Wood
The extra newline is no longer necessary as the final summary line includes one. Signed-off-by: Thomas Wood thomas.w...@intel.com --- piglit-resume.py | 3 +-- piglit-run.py| 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/piglit-resume.py b/piglit-resume.py index

[Piglit] [PATCH v2 0/3] log output and final summary line

2014-03-27 Thread Thomas Wood
Updated series based on Dylan Baker's review. Thomas Wood (3): framework/log.py: ensure any previous output is cleared framework: print a summary line after a run has finished Remove extra newline from the end of run message framework/core.py | 2 ++ framework/log.py | 37

[Piglit] [PATCH 1/2] framework/log.py: ensure any previous output is cleared

2014-03-21 Thread Thomas Wood
If the new summary line is shorter than the previous one, clear the remaining characters. Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/log.py | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/framework/log.py b/framework/log.py index

[Piglit] [PATCH 0/2] log output and final summary line

2014-03-21 Thread Thomas Wood
The following two patches attempt to address some of the issues with left over characters in the log output and then add a summary line to the end of the test run. Thomas Wood (2): framework/log.py: ensure any previous output is cleared framework: print a summary line after a run has finished

[Piglit] [PATCH 2/2] framework: print a summary line after a run has finished

2014-03-21 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/core.py | 2 ++ framework/log.py | 8 piglit-resume.py | 3 +-- piglit-run.py | 3 +-- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/framework/core.py b/framework/core.py index ef8e7f6..14a832d 100644

[Piglit] [PATCH] framework/log.py: print a final summary line after a run has finished

2014-03-20 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/log.py | 4 1 file changed, 4 insertions(+) diff --git a/framework/log.py b/framework/log.py index c15134b..fc37001 100644 --- a/framework/log.py +++ b/framework/log.py @@ -93,6 +93,10 @@ class Log(object): assert

Re: [Piglit] [PATCH] framework/log.py: print a final summary line after a run has finished

2014-03-20 Thread Thomas Wood
On 20 March 2014 16:33, Dylan Baker baker.dyla...@gmail.com wrote: On Thursday, March 20, 2014 16:04:59 Thomas Wood wrote: IMHO, it would better to add a final call method (or modify Log.post_log to have only keyword arguments) that just prints [x/y] and the summary (ie: [8/8] pass: 7 fail

[Piglit] [PATCH 0/2] Add timeout support

2014-03-19 Thread Thomas Wood
the actual test status is unknown, but a change from timeout to fail is considered a regression. Thomas Wood (2): framework: add support for a timeout status tests/igt.py: stop tests after 10 minutes framework/log.py| 2 +- framework/status.py | 20 + framework

[Piglit] [PATCH 2/2] tests/igt.py: stop tests after 10 minutes

2014-03-19 Thread Thomas Wood
Stop tests if they run for longer than 10 minutes by first sending the terminate signal and if that fails, send the kill signal to all processes in the test's process group. Based on a patch by Tim Gore. Signed-off-by: Thomas Wood thomas.w...@intel.com Cc: Tim Gore tim.g...@intel.com Cc: Daniel

[Piglit] [PATCH 1/2] framework: add support for a timeout status

2014-03-19 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com Cc: Daniel Vetter daniel.vet...@ffwll.ch --- framework/log.py| 2 +- framework/status.py | 20 framework/tests/status_tests.py | 4 ++-- templates/index.css | 5 - 4 files changed

[Piglit] [PATCH 0/2] Updated framework patches

2014-02-24 Thread Thomas Wood
://lists.freedesktop.org/archives/piglit/2013-November/008467.html). Damien Lespiau (1): framework: Dump the result of 'uname -a' in the report Thomas Wood (1): framework: use formatted time values in the HTML report framework/core.py | 3 +++ framework/summary.py| 7

[Piglit] [PATCH 2/2] framework: Dump the result of 'uname -a' in the report

2014-02-24 Thread Thomas Wood
From: Damien Lespiau damien.lesp...@intel.com Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- framework/core.py | 3 +++ framework/summary.py| 1 + templates/testrun_info.mako | 6 ++ 3 files changed, 10 insertions(+) diff --git a/framework/core.py

[Piglit] [PATCH 1/2] framework: use formatted time values in the HTML report

2014-02-24 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/summary.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/framework/summary.py b/framework/summary.py index 2fc16ce..c1104c3 100644 --- a/framework/summary.py +++ b/framework/summary.py @@ -26,6 +26,7