[26446/26446] fail: 485, pass: 330, skip: 25631 Running Test(s):
> 26446
> Thank you for running Piglit!
>
> The glsles shader/glslparser work is based heavily off of work
> originally done by Tom Gall. This work was also never upstreamed to
> piglit, so, again, it gets stale quickl
Hi All,
I'd like to draw your attention the existence of an "new" (1) XML
scheme & database for GL, GLES, WGL, GLX and EGL.
There are a number tools (like the dispatch table in piglit for
instance, header file generation etc) which would quite likely benefit
from this new source of data from Khro
+1
I've had a all_gles2.tests I've been maintaining in my own git repo
which could easily evolve to use this. I'm sure I'm not the only
person that would like to make use of this.
On Thu, May 2, 2013 at 4:03 PM, Brian Paul wrote:
>
> I'd like to rename tests/all.tests (and the others) to somethi
-by: Tom Gall
---
.../array-assign-implicit-size.vert| 28
.../array-attribute.vert | 18 +++
.../array-ctor-mismatched-size.vert| 15 +
.../structure-and-array-operations/array-ctor.vert | 29
Add to tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
glslparser tests for array declarations, array of structures and
redeclarations.
Signed-off-by: Tom Gall
---
.../array-of-any-type.vert | 43
...ay-of-array-function-parameter
Add to tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
glslparser tests for arrays and assignment, multidimensional,
multiply, and not equal.
Signed-off-by: Tom Gall
---
.../array-assign.vert | 27 +++
.../array-multidimensional-new
Add to
tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
a series of array operator tests including logical and
mathimatical tests. These are operators including
+,/,>,<,>=,<=,&&,!,||,^^,+,-,++,--, , ,-
Signed-off-by: Tom Gall
---
.../structure-and-array-opera
Add to
tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
a series of array declaration size tests.
Signed-off-by: Tom Gall
---
.../array-size-bool.vert | 16 ++
.../array-size-bvec2.vert | 16 ++
.../array-size-bvec3.vert
Add to
tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
a series of array tests used as function params and return types.
Signed-off-by: Tom Gall
---
.../array-function-parameter-implicit-size.vert| 36
.../array-function-parameter-unsized.vert
Add to
tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
a series of array constructor tests with implicit conversions
over a variety of types.
Signed-off-by: Tom Gall
---
.../array-ctor-implicit-conversion-bool-float.vert | 19 +++
.../array-ctor-implicit
Add to
tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
a series of array equality tests, with mismatching types,
sizes, implicit sizes etc.
Signed-off-by: Tom Gall
---
.../array-equal-implicit-size.vert | 32
.../array-equal-matrix.vert
Add to
tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
a series of constant index array tests including valid, negative
and outside of the range.
Signed-off-by: Tom Gall
---
.../array-constant-index-implicit-size.vert| 29
.../array-constant-index
Add to
tests/spec/glsl-es-1.00/compiler/structure-and-array-operations
a series of tests that validates for arrays:
Page 18 of the GLSL ES 1.00.17 spec:
"There are no implicit conversions between types."
Signed-off-by: Tom Gall
---
...rray-assign-implicit-conversion-bool-float.v
generated_tests.
Signed-off-by: Tom Gall
---
generated_tests/CMakeLists.txt | 14 +++
generated_tests/outerProduct-invalid-parameters.sh | 91
2 files changed, 105 insertions(+)
create mode 100755 generated_tests/outerProduct-invalid-parameters.sh
diff --git a
outerProduct is available with glsl es 3.00 but not
with glsl es 1.00.
http://www.khronos.org/opengles/sdk/docs/manglsl/xhtml/outerProduct.xml
Signed-off-by: Tom Gall
---
.../compiler/built-in-functions/outerProduct-vec2.vert | 12
1 file changed, 12 insertions(+)
create
In check_platform_extensions, fix a bug where if extentions
was NULL, it'll segv.
Signed-off-by: Tom Gall
---
tests/util/piglit-framework-cl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/util/piglit-framework-cl.c b/tests/util/piglit-framework-cl.c
Adjust shell script so it echos the name of the generated testcase and output
the
generated testcases using the following pattern:
"spec/glsl"${es}-${version}"/execution/varible-index-write"
This uses the convention followed by the other scripts that generate testcases.
Sig
Adjust shell script so it echos the name of the generated testcase and output
the
generated testcases using the following pattern:
"spec/glsl"${es}-${version}"/execution/varible-index-read"
This uses the convention followed by the other scripts that generate testcases.
Sig
In generated_tests/CMakeLists.txt add new fn piglit_make_sh_generated_tests
which
allows for shells scripts to be called to generate tests cases.
Call variable-index-read.sh and variable-index-write.sh to generate tests for
glsl 1.00, 1.10 and 1.20.
Signed-off-by: Tom Gall
---
generated_tests
Signed-off-by: Tom Gall
---
{tests/spec/glsl-1.10 => generated_tests}/variable-index-read.sh |0
{tests/spec/glsl-1.10 => generated_tests}/variable-index-write.sh |0
2 files changed, 0 insertions(+), 0 deletions(-)
rename {tests/spec/glsl-1.10 => generated_tests}/varia
When the glsl_version is 1.00, use the glslparsertest_gles2 binary
Signed-off-by: Tom Gall
---
framework/glsl_parser_test.py |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/framework/glsl_parser_test.py b/framework/glsl_parser_test.py
index 66e6dd3..914904d 100755
ied since ortho during the test portion isn't supported on
OpenGL ES.
For 1.00 tests the fragent shader specifies default precision.
For 1.00 tests emit in the [require] section the correct
GLSL ES and GL ES settings.
Signed-off-by: Tom Gall
---
tests/spec/glsl-1.10/variable-index-write.s
nce ortho during the test portion isn't supported on
OpenGL ES.
For 1.00 tests the fragent shader specifies default precision.
For 1.00 tests emit in the [require] section the correct
GLSL ES and GL ES settings.
Signed-off-by: Tom Gall
---
tests/spec/glsl-1.10/variable-index-read.s
y adjustment to config of
course.
Reviewed-by Tom Gall
On Thu, Apr 18, 2013 at 3:21 PM, Brian Paul wrote:
> When doing a full piglit run it's helpful to have all the OpenGL
> driver version/vendor/extension info. The piglit framework tries
> to run glxinfo/wglinfo and include the outp
On Fri, Apr 19, 2013 at 9:22 AM, Brian Paul wrote:
> On 04/19/2013 04:33 AM, Jose Fonseca wrote:
>>
>> Yes, assuming stderr messages are driver warnings seems a bit pedantic.
>>
>> We could do the other way around -- have a whitelist of warning regular
>> expressions that we do known that are worr
Bah! Ignore. Didn't realize my repo was slightly out of date. Sorry about that!
On Thu, Apr 18, 2013 at 3:39 PM, Tom Gall wrote:
> generated_tests/generate-cl-int-builtins.py in getValue, at the
> very end some logic checks for an instance of an int and returns
> it.
>
> I
int.
Signed-off-by: Tom Gall
---
generated_tests/generate-cl-int-builtins.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generated_tests/generate-cl-int-builtins.py
b/generated_tests/generate-cl-int-builtins.py
index 5b6eaf6..22b0726 100755
--- a/generated_tests/generate
d-off-by: Tom Gall
---
tests/spec/glsl-1.10/variable-index-write.sh | 67 +++---
1 file changed, 61 insertions(+), 6 deletions(-)
diff --git a/tests/spec/glsl-1.10/variable-index-write.sh
b/tests/spec/glsl-1.10/variable-index-write.sh
index 96a4791..06802c4 100755
--- a/te
.00 tests the vertex shader an orthographic projection is
applied since ortho during the test portion isn't supported on
OpenGL ES.
For 1.00 tests the fragent shader specifies default precision.
For 1.00 tests emit in the [require] section the correct
GLSL ES and GL ES settings.
Signed-off
On Wed, Apr 17, 2013 at 4:48 AM, Kenneth Graunke wrote:
> Does anyone object to porting to Python 3.x (and dropping 2.x support)?
I don't have strong objections, but more of a preference that 2.7+ and
3.x be supported. My Ubuntu Raring (the next release of ubuntu)
install for instance has 2.7.4
Hi All,
It's a bit of a challenge to see the status of various patches. As an
observation and not a complaint, I have a number of patches dating a
ways back either with no action or reviews that haven't landed. I'm
sure I'm not the only one.
I wonder if setting up patchwork for tracking patch sta
On Thu, Apr 4, 2013 at 11:11 AM, Eric Anholt wrote:
> Stuart Abercrombie writes:
>
>> It will be added based on the GLSL requirement instead.
>>
>> Same number of passes on Sandy Bridge running all.tests without glean.
>
> I don't like this anti-#version crusade. I'd like to see only patches
> t
Signed-off-by: Tom Gall
---
generated_tests/CMakeLists.txt |4
1 file changed, 4 insertions(+)
diff --git a/generated_tests/CMakeLists.txt b/generated_tests/CMakeLists.txt
index db3734f..a30d9e6 100644
--- a/generated_tests/CMakeLists.txt
+++ b/generated_tests/CMakeLists.txt
@@ -54,6
This adds a series l-value tests for glslparsertest. This new
python code creates glsl es versions of the tests. This "new"
code was directly based on generated_tests/gen_non-lvalue_tests.py.
The new es version outputs to generated_tests/spec/glsl-es-1.00.
Signed-off-by
When the glsl_version is 1.00, use the glslparsertest_gles2 binary
Signed-off-by: Tom Gall
---
framework/glsl_parser_test.py |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/framework/glsl_parser_test.py b/framework/glsl_parser_test.py
index 66e6dd3..914904d 100755
Just about two weeks ago I had posted:
http://lists.freedesktop.org/archives/piglit/2013-March/005231.html
http://lists.freedesktop.org/archives/piglit/2013-March/005232.html
If acceptable can we get these merged? There hasn't been any negative
feedback thus far.
I have the patches ready to go w
When lod_bias was added to shader_runner it broke compilation
on OpenGL ES. GL_TEXTURE_LOD_BIAS isn't defined as part of
OpenGL ES. Added #ifdef PIGLIT_USE_OPENGL to handle_texparameter
when the string_match checks for lod_bias.
Signed-off-by: Tom Gall
---
tests/shaders/shader_runner.c |
x.xx
directories. I think that's a separate patch and also I plan to do
it.
> Stuart
>
>
> On Wed, Mar 20, 2013 at 3:15 PM, Tom Gall wrote:
>>
>> From tests/spec/glsl-1.10 extend variable-index-write.sh so that
>> it can also correctly generates variable index
ied since ortho during the test portion isn't supported on
OpenGL ES.
For 1.00 tests the fragent shader specifies default precision.
For 1.00 tests emit in the [require] section the correct
GLSL ES and GL ES settings.
Signed-off-by: Tom Gall
---
tests/spec/glsl-1.10/variable-index-write.s
nce ortho during the test portion isn't supported on
OpenGL ES.
For 1.00 tests the fragent shader specifies default precision.
For 1.00 tests emit in the [require] section the correct
GLSL ES and GL ES settings.
Signed-off-by: Tom Gall
---
tests/spec/glsl-1.10/variable-index-read.s
he fragment language requires any uses of lowp and mediump to
compile without error. Support for highp is optional."
Signed-off-by: Tom Gall
---
tests/spec/glsl-es-1.00/execution/sanity.shader_test |2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/spec/glsl-es-1.00/execution/sa
of passes on Sandy Bridge running all.tests without glean.
>
> Signed-off-by: Stuart Abercrombie
Reviewed-by: Tom Gall
--
Regards,
Tom
"Where's the kaboom!? There was supposed to be an earth-shattering
kaboom!" Marvin Martian
Tech Lead, Graphics Working Group | Linaro.org │ Op
From tests/spec/glsl-1.10, I've extended variable-index-write.sh and
variable-index-read.sh so the scripts are able to generate tests for
GLSL ES 1.00.
Posting the patches for the scripts is trivial but how do we want to
handle all the tests that it generates?
Seems like a bit of a waste of mail
For the series.
Reviewed-by: Tom Gall
On Wed, Feb 27, 2013 at 12:59 PM, Chad Versace
wrote:
> On 02/27/2013 10:47 AM, Paul Berry wrote:
>> On 27 February 2013 10:44, Eric Anholt > <mailto:e...@anholt.net>> wrote:
>>
>> Paul Berry mailto:ste
12:54 PM, Paul Berry wrote:
> On 27 February 2013 10:46, Tom Gall wrote:
>>
>> Hmm is there some reason this has to be a compile time decision as
>> compared to use of the piglit_is_gles() function?
>
>
> No, I don't really see a reason to prefer one way over the o
Hmm is there some reason this has to be a compile time decision as
compared to use of the piglit_is_gles() function?
Here's a link to the patch that I had posted on the 18th.
http://lists.freedesktop.org/archives/piglit/2013-February/004952.html
On Wed, Feb 27, 2013 at 12:32 PM, Paul Berry wr
Looks good across the set.
Reviewed-by: Tom Gall
On Thu, Feb 21, 2013 at 9:37 AM, Brian Paul wrote:
> ---
> tests/util/piglit-util-gl-common.h | 12 ++
> tests/util/piglit-util-gl-enum.c | 41
>
> 2 files changed, 53 i
gl_MaxVertexUniformVectors.shader_test
These check the built-in constants of the same name from
section 7.4 of the glsl es 1.0.17 spec.
v2: squash patch, address one by one spec reference.
Signed-off-by: Tom Gall
---
.../gl_MaxCombinedTextureImageUnits.shader_test| 30
shader_runner tag. I guess I could see it going either way.
> -Jordan
>
> On Mon, Feb 18, 2013 at 2:02 PM, Tom Gall wrote:
>> Adds tests/spec/glsl-es-1.00/maximums/
>> gl_MaxCombinedTextureImageUnits.shader_test, checks built-in
>> constant gl_MaxCombinedTex
Adds tests/spec/glsl-es-1.00/maximums/
gl_MaxVertexUniformVectors.shader_test, checks built-in
constant gl_MaxVertexUniformVectors
Signed-off-by: Tom Gall
---
.../gl_MaxVertexUniformVectors.shader_test | 29
1 file changed, 29 insertions(+)
create mode 100644
Adds tests/spec/glsl-es-1.00/maximums/
gl_MaxVertexTextureImageUnits.shader_test, checks built-in
constant gl_MaxVertexTextureImageUnits.
Signed-off-by: Tom Gall
---
.../gl_MaxVertexTextureImageUnits.shader_test | 29
1 file changed, 29 insertions(+)
create mode
Adds tests/spec/glsl-es-1.00/maximums/gl_MaxVertexAttribs.shader_test
checks built-in constant gl_MaxVertexAttribs.
Signed-off-by: Tom Gall
---
.../maximums/gl_MaxVertexAttribs.shader_test | 29
1 file changed, 29 insertions(+)
create mode 100644
tests/spec/glsl
Adds tests/spec/glsl-es-1.00/maximums/gl_MaxVaryingVectors.shader_test
checks built-in constant gl_MaxVaryingVectors.
Signed-off-by: Tom Gall
---
.../maximums/gl_MaxVaryingVectors.shader_test | 29
1 file changed, 29 insertions(+)
create mode 100644
tests/spec/glsl
Adds tests/spec/glsl-es-1.00/maximums/gl_MaxTextureImageUnits.shader_test
checks built-in constant gl_MaxTextureImageUnits
Signed-off-by: Tom Gall
---
.../maximums/gl_MaxTextureImageUnits.shader_test | 29
1 file changed, 29 insertions(+)
create mode 100644
tests/spec
Adds tests/spec/glsl-es-1.00/maximums/
gl_MaxFragmentUniformVectors.shader_test, checks built-in
constant gl_MaxFragmentUniformVectors
Signed-off-by: Tom Gall
---
.../gl_MaxFragmentUniformVectors.shader_test | 29
1 file changed, 29 insertions(+)
create mode 100644
Adds tests/spec/glsl-es-1.00/maximums/gl_MaxDrawBuffers.shader_test
checks built-in constant gl_MaxDrawBuffers
Signed-off-by: Tom Gall
---
.../maximums/gl_MaxDrawBuffers.shader_test | 29
1 file changed, 29 insertions(+)
create mode 100644
tests/spec/glsl-es
Adds tests/spec/glsl-es-1.00/maximums/
gl_MaxCombinedTextureImageUnits.shader_test, checks built-in
constant gl_MaxCombinedTextureImageUnits
Signed-off-by: Tom Gall
---
.../gl_MaxCombinedTextureImageUnits.shader_test| 30
1 file changed, 30 insertions(+)
create mode
This patch series was posted on the 5th.
Could I get a Reviewed-by and/or committed ?
In essence they extend tests/glslparsertest/glsl2/gen_builtin_test.py
to include support for glsl version 100.
Thanks!
Tom
-- Forwarded message --
From: Tom Gall
Date: Tue, Feb 5, 2013 at 2
glslparsertest.c has a bug where it assumes that when the
requested glsl version is 1.00 the GL_ARB_ES2_compatibility
extension must be present. For GLES2 this should not be
required. The piglit_is_gles() call
checks the version string from glGetString(GL_VERSION).
Signed-off-by: Tom Gall
--find-renames
Signed-off-by: Tom Gall
---
tests/all.tests | 11 +++
.../compiler/arithmetic-operators/division-by-zero-01.frag |1 -
.../compiler/arithmetic-operators/division-by-zero-02.frag |1 -
.../compiler/arithmetic-operators
Move contents of tests/spec/glsl-1.00/compiler/storage-qualfiers to
tests/spec/glsl-es-1.00/compiler/storage-qualfiers
Signed-off-by: Tom Gall
---
.../static-write-attribute-01.vert | 17 -
.../static-write-attribute-02.vert | 20
Move contents of tests/spec/glsl-1.00/compiler/qualifiers to
tests/spec/glsl-es-1.00/compiler/qualifiers
Signed-off-by: Tom Gall
---
.../qualifiers/fn-inout-array-allowed-cstyle.frag | 28 ---
.../qualifiers/fn-inout-array-allowed-cstyle.vert | 29
Move contents of tests/spec/glsl-1.00/compiler/precision-qualifiers
to tests/spec/glsl-es-1.00/compiler/precision-qualifiers
Signed-off-by: Tom Gall
---
.../default-precision-bool-01.frag | 22 ---
.../default-precision-float-01.frag| 21
Move contents of tests/spec/glsl-1.00/compiler/assignment-operators
to tests/spec/glsl-es-1.00/compiler/assignment-operators
Signed-off-by: Tom Gall
---
.../assign-array-prohibited.frag | 19 ---
.../assign-array-prohibited.vert | 19
end of
tests/spec/glsl-1.00/compiler/assignment-operators/modulus-assign-00.frag
v2: switch to glsl-es-1.00 instead of glsl-1.00 based on list
discussion
Signed-off-by: Tom Gall
---
tests/all.tests | 12
.../arithmetic-operators/division-by-zero
On Thu, Feb 14, 2013 at 12:31 PM, Eric Anholt wrote:
> Tom Gall writes:
>
>> Add glsl-1.00/execution dir to all.tests as a shader test.
>>
>> Move contents of glsl-es-1.00 to glsl-1.00 and remove
>> glsl-es-1.00.
>
> I think we should retain the "ES&qu
Add glsl-1.00/execution dir to all.tests as a shader test.
Move contents of glsl-es-1.00 to glsl-1.00 and remove
glsl-es-1.00.
Signed-off-by: Tom Gall
---
tests/all.tests|4 ++
tests/spec/glsl-1.00/execution/sanity.shader_test | 39
Remove ttexrect.* from glean as the previous patch ports the test
to piglit.
Remove texRect from all.tests.
Signed-off-by: Tom Gall
---
tests/all.tests |1 -
tests/glean/CMakeLists.gl.txt |1 -
tests/glean/ttexrect.cpp | 215
all.tests change.
v3: use piglit_present_results, and piglit_probe_image_rgb
v4: use piglit_draw_rect_tex, piglit_ortho_projection and minor
clean ups.
Signed-off-by: Tom Gall
---
tests/all.tests|1 +
tests/spec/CMakeLists.txt |1
Remove ttexrect.* from glean as the previous patch ports the test
to piglit.
Remove texRect from all.tests.
Signed-off-by: Tom Gall
---
tests/all.tests |1 -
tests/glean/CMakeLists.gl.txt |1 -
tests/glean/ttexrect.cpp | 215
all.tests change.
v3: use piglit_present_results, and piglit_probe_image_rgb
Signed-off-by: Tom Gall
---
tests/all.tests|1 +
tests/spec/CMakeLists.txt |1 +
tests/spec/arb_texture_rectangle/CMakeLists.gl.txt | 13 ++
tests/spec
push it for you?
>
> -Brian
>
>
> On 02/06/2013 03:38 PM, Tom Gall wrote:
>>
>> It was a little over two weeks ago when v2 of these 2 patches to port
>> ttexrect to piglit and remove it from glean were posted.
>>
>> It has a Reviewed-by: Brian Paul
at 4:46 PM
Subject: Re: [Piglit] [PATCH 1/2] port ttexrect.cpp to piglit from glean
To: Tom Gall
Cc: piglit@lists.freedesktop.org, patc...@linaro.org
On 01/21/2013 01:43 PM, Tom Gall wrote:
>
> This ported test goes into tests/spec/arb_texture_rectangle. It
> tests the ARB_texture_recta
On Tue, Feb 5, 2013 at 3:32 PM, Chad Versace
wrote:
> On 02/02/2013 07:33 AM, Tom Gall wrote:
>> On Sat, Feb 2, 2013 at 12:02 AM, Eric Anholt wrote:
>>> Tom Gall writes:
>>>
>>>> This patch series builds piglit within the Android source tree. It's
&g
Nearly two weeks since this was posted. Any reason this shouldn't go it?
Thanks!
-- Forwarded message --
From: Tom Gall
Date: Wed, Jan 23, 2013 at 2:48 PM
Subject: [PATCH 1/1] glsl: add explicit version 100 support
To: piglit@lists.freedesktop.org
Cc: patc...@linaro.org
Adds new output of gen_builtin_test.py creating
builtin-fuctions-100.vert.
Signed-off-by: Tom Gall
---
.../glsl2/builtin-functions-100.vert | 266
1 file changed, 266 insertions(+)
create mode 100644 tests/glslparsertest/glsl2/builtin-functions-100.vert
Adds support to emit builtin-functions-100.vert
largely based on the 110 version.
- Don't use gl_Vertex.
- Create misc_parameter_100 which adds cross.
Signed-off-by: Tom Gall
---
tests/glslparsertest/glsl2/gen_builtin_test.py | 66 +++-
1 file changed, 65 insertions(
On Sat, Feb 2, 2013 at 12:02 AM, Eric Anholt wrote:
> Tom Gall writes:
>
>> This patch series builds piglit within the Android source tree. It's
>> still a bit of a work in progress but the build succeeds and the tests
>> that are built do pass.
>>
>> Th
Adds Android.mk to build invalid-es3-queries & minmax. Test
binaries are installed into /system/xbin/piglit/
Signed-off-by: Tom Gall
---
tests/spec/gles-2.0/Android.mk | 31 +++
1 file changed, 31 insertions(+)
create mode 100644 tests/spec/gles-2.0/Androi
Adds Android.mk to copy the glsl es 1.00 shader test
sanity.shader_test to /data/shader-data/execution/
Signed-off-by: Tom Gall
---
tests/spec/Android.mk|3 +++
tests/spec/glsl-es-1.00/Android.mk |3 +++
tests/spec/glsl-es-1.00/execution/Android.mk
Adds Android.mk to build shader_runner.
Signed-off-by: Tom Gall
---
tests/shaders/Android.mk | 33 +
1 file changed, 33 insertions(+)
create mode 100644 tests/shaders/Android.mk
diff --git a/tests/shaders/Android.mk b/tests/shaders/Android.mk
new file mode
Adds Android.mk to build libpiglitutil_gles2 as well as
autogenerate config.h, and generated_dispatch.ch
Signed-off-by: Tom Gall
---
tests/util/Android.mk | 98 +
1 file changed, 98 insertions(+)
create mode 100644 tests/util/Android.mk
diff
This are Adrian M Negreanu's changes for piglit to support Android.
These are included in this patch series for the purposes of completeness.
Signed-off-by: Tom Gall
---
.../piglit-framework-gl/piglit_android_framework.c | 86
.../piglit-framewo
Signed-off-by: Tom Gall
---
tests/Android.mk |3 +++
1 file changed, 3 insertions(+)
create mode 100644 tests/Android.mk
diff --git a/tests/Android.mk b/tests/Android.mk
new file mode 100644
index 000..c455f97
--- /dev/null
+++ b/tests/Android.mk
@@ -0,0 +1,3 @@
+LOCAL_PATH := $(call
Add top of the tree Android.mk, sets piglit_top
Signed-off-by: Tom Gall
---
Android.mk |5 +
1 file changed, 5 insertions(+)
create mode 100644 Android.mk
diff --git a/Android.mk b/Android.mk
new file mode 100644
index 000..8276ed9
--- /dev/null
+++ b/Android.mk
@@ -0,0 +1,5
This patch series builds piglit within the Android source tree. It's
still a bit of a work in progress but the build succeeds and the tests
that are built do pass.
The 3rd patch is entirely written by Adrian M Negreanu and really is
the heart of the Android implementation for piglit as it adds the
strchrnul is used in shader_runner.c (and no where else in all
of piglit). Unfortunately bionic, Android's c library does not
include this function. I've writen an implementation of
strchrnul which is only used when compiling for Android.
Signed-off-by: Tom Gall
---
tes
On Android -Werror=return-type is set for C code, as such there
are two cases were I've added a return 0 after an assert.
Signed-off-by: Tom Gall
---
tests/shaders/shader_runner.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/sh
n glsl
and glsl es then sure these patches look good.
Reviewed-by: Tom Gall
On Thu, Jan 31, 2013 at 12:17 PM, Stuart Abercrombie
wrote:
> Another step towards removing explicit #version directives.
>
> Signed-off-by: Stuart Abercrombie
> ---
> tests/shaders/shader_runner.c
On Wed, Jan 30, 2013 at 3:25 PM, Eric Anholt wrote:
> Tom Gall writes:
>
>> Why is this is a good patch to add?
>>
>> In the not too distant future piglit tests will be able to be built
>> once and at runtime one cam choose to test against api family, IE GL,
>
structure
of candidates, running based on what the user specified.
On Tue, Jan 29, 2013 at 6:09 PM, Eric Anholt wrote:
> Tom Gall writes:
>
>> No feedback?
>
> I think what's missing is the explanation of "why do we want the tests
> to be able to print what apis the
No feedback?
-- Forwarded message --
From: Tom Gall
Date: Tue, Jan 22, 2013 at 6:51 PM
Subject: [PATCH 1/1] RFC: add ability to report gl api supported by tests
To: piglit@lists.freedesktop.org
Cc: patc...@linaro.org, Tom Gall
This patch adds a new command line parameter
Hi Christoph,
If you look at the bottom of http://www.opengl.org/registry/ you will find:
enum.spec - canonical description of the reserved OpenGL enumerants
and the ranges allocated for different purposes. New allocations are
made here and when extensions using values in allocated ranges are
reg
13 at 7:18 PM, Matt Turner wrote:
> On Mon, Jan 28, 2013 at 5:11 PM, Tom Gall wrote:
>> Sure, but tell that to the compiler.
>>
>> It is bad form to not have a return at the end of a function which is
>> supposed to return something. The other way perhaps is just knock ou
Sure, but tell that to the compiler.
It is bad form to not have a return at the end of a function which is
supposed to return something. The other way perhaps is just knock out
the default case and return that. Either way.
On Mon, Jan 28, 2013 at 7:01 PM, Matt Turner wrote:
> On Mon, Jan 28, 20
I'm using the "android" branch on:
git://git.linaro.org/people/tomgall/piglit.git
It's a WIP however what is there builds as long as you put it into
external/piglit as well as have waffle already built. It uses
Android.mk files as compared to Adrian's earlier patches that he
posted but the piglit
A very minor change to fix build issue for Android. Needed return
statement at end of function which specifies a return type.
Signed-off-by: Tom Gall
---
tests/util/piglit_ktx.c |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/util/piglit_ktx.c b/tests/util/piglit_ktx.c
index
A very minor change to fix build issue for Android. Needed return
statement at end of function which specifies a return type.
Signed-off-by: Tom Gall
---
tests/util/piglit-shader.c |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-shader.c
Android is a bit more strict when it builds. Missing was ctype.h.
It doesn't break Linux.
Signed-off-by: Tom Gall
---
tests/util/piglit-vbo.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/util/piglit-vbo.cpp b/tests/util/piglit-vbo.cpp
index 4900931..b2e2e63 100644
--- a/
don't require the
GL_ARB_ES2_compatibility extension.
In CMakeList.gles2.txt remove ${OPENGL_gles2_LIBRARY} as it's
not needed.
v2: detach patch from proposed python change.
Signed-off-by: Tom Gall
---
tests/glslparsertest/CMakeLists.gles2.txt |5 +
tests/glsl
1 - 100 of 210 matches
Mail list logo
