[Piglit] [PATCH] arb_sample_shading: Add gl_SampleMaskIn subtest with msaa disabled, fix test

From: Roland Scheidegger The spec says with msaa disabled gl_SampleMaskIn is always 1. This is not particularly related to arb_sample_shading, but drivers may do different workarounds depending on the state of sample shading and the presence of bits in the shader which would

[Piglit] [PATCH 2/2] arb_internalformat_query2: don't try glGetTexLevelParameteriv() for tex buffers

From: Roland Scheidegger I believe querying that information for GL_TEXTURE_BUFFFER via internal format query should return the correct values, but it's definitely impossible if just ARB_texture_buffer_object is supported but not GL 3.1. Hence just pretend it succeeded in

[Piglit] [PATCH 1/2] arb_internalformat_query2: avoid bogus error spam about unsupported pnames

From: Roland Scheidegger The test fed the equivalent_pname into the get_unsupported_response() function, which led to nonsense logged errors as this only recognizes the original pnames. Refactor pname/equivalent_pname translation so always the original pnames are fed into

[Piglit] [PATCH] teximage-colors: accept -127 instead of -128 for exact snorm up/download

From: Roland Scheidegger -128 and -127 represent exactly the same value (-1.0) for snorm8 values, as do -32768/-32767 for snorm16. Therefore it seems quite reasonable that an implementation would return the other representation (in particular r600 will do this with a blit,

[Piglit] [PATCH] arb_texture_buffer_object/indexed: test indexed samplers with tbo

From: Roland Scheidegger This just verifies that sampler arrays indexed with a uniform work with TBOs. (Broken on r600 evergreen pending a fix.) v2: fix compiler warnings, directly assign index uniform in shader --- tests/all.py | 1 +

[Piglit] [PATCH] arb_texture_buffer_object/indexed: test indexed samplers with tbo

From: Roland Scheidegger This just verifies that sampler arrays indexed with a uniform work with TBOs. (Broken on r600 evergreen pending a fix.) --- tests/all.py | 1 + .../arb_texture_buffer_object/CMakeLists.gl.txt| 1 +

[Piglit] [PATCH 2/2] arb_texture_buffer_object/max-size: skip if the buffer can't be allocated

From: Roland Scheidegger The max size reported by GL_MAX_TEXTURE_BUFFER_SIZE only guarantees that buffers which contain that many texels can be sampled from. It does not mean it is guaranteed the corresponding huge buffers can be allocated in the first place. (r600 for

[Piglit] [PATCH 1/2] textureSize: add ability to test tess eval stage

From: Roland Scheidegger This is a problem of all texturing tests, they cannot exercise the tesselation stages. (But I'm too lazy to fix the others, and too lazy to hack something up for tcs stage, I only need it to verify a bug/fix with r600 buffer textures.) ---

[Piglit] [PATCH] textureGather: add new options for testing mirror address modes

From: Roland Scheidegger The existing repeat and clamp modes are easy to implement. The mirror_repeat (GL_MIRRORED_REPEAT) and mirror_clamp (GL_MIRROR_CLAMP_TO_EDGE) modes however have some very interesting differences to "gather is just the same as bilinear filtering without

[Piglit] [PATCH] fbo-blending-snorm: new test for testing snorm blend behavior

From: Roland Scheidegger The existing fbo-blending-formats test is mostly useless for anything but unorm formats, since it does not test any values outside [0,1] (neither for src, dst, intermeidate calculations, blend result). I tried to enhance it but it got too complex, in

[Piglit] [PATCH] isinf-and-isnan: add clamp / min / max tests

From: Roland Scheidegger We expect non-nan results for these (according to d3d10 rules, and at least for min/max, also according to ieee rules). The tests will not actually fail with other results (since GL's NaN behavior is all undefined), albeit some apps may rely on this.

[Piglit] [PATCH] arb_texture_query_lod: add tolerance for some comparisons

From: Roland Scheidegger Tolerance was added for the tests a while ago, but it looks like it was forgotten for the nearest_biased test (the nearest one has it). Also, for the linear test, add tolerance too when comparing x and y lodq results - the values should probably be

[Piglit] [PATCH] depth-clamp-range: make sure clamping actually makes a difference

From: Roland Scheidegger The problem with the chosen depth values was that the depth values naturally got viewport-transformed to values below 0.5 (for those quads drawn) or above 0.5 (for those not drawn). This allowed buggy implementations (in particular llvmpipe) to pass

[Piglit] [PATCH] tex-miplevel-selection: only require glsl 1.30 for textureOffset 2DArrayShadow

From: Roland Scheidegger The spec doesn't really say this should work in older versions. It was first added in glsl 4.30, mentioning it was forgotten (initially part of EXT_gpu_shader4, hence should have been added with 1.30), but with the wrong syntax. Finally fixed in glsl

[Piglit] [PATCH] arb_viewport_array: add GL_ARB_gpu_shader5 requirement for render_viewport_2

From: Roland Scheidegger The test cannot work without this (and thus always failed if not present). --- tests/spec/arb_viewport_array/render_viewport_2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_viewport_array/render_viewport_2.c

[Piglit] [PATCH] arb_texture_view-mipgen: add test to verify correct format is used for mipgen

From: Roland Scheidegger At least mesa/st fails this right now (always uses the initial format for mip gen). v2: don't use piglit_display (not actually drawing anything), suggested by Ilia Mirkin. --- tests/all.py | 1 +

[Piglit] [PATCH] arb_texture_view-mipgen: add test to verify correct format is used for mipgen

From: Roland Scheidegger At least mesa/st fails this right now (always uses the initial format for mip gen). --- tests/all.py | 1 + tests/spec/arb_texture_view/CMakeLists.gl.txt | 1 + tests/spec/arb_texture_view/mipgen.c | 102

[Piglit] [PATCH] glsl-1.50-geometry-end-primitive: ensure position data is reasonably aligned

From: Roland Scheidegger The rect halves comparison is in fact not valid in general. The reason is that the same geometry does not have the same precision even if it it just shifted by some fixed amount in one direction. As an example, some calculated x value near 7 will be

[Piglit] [PATCH] glsl-1.50-geometry-end-primitive: ensure position data is reasonably aligned

From: Roland Scheidegger The rect halves comparison is in fact not valid in general. The reason is that the same geometry does not have the same precision even if it it just shifted by some fixed amount in one direction. As an example, some calculated x value near 7 will be

[Piglit] [PATCH] polygon-mode-facing: verify facing information is preserved with unfilled prims

From: Roland Scheidegger This test is quite mean to mesa's draw pipe. llvmpipe/softpipe fail even if front and back fill mode is the same (for points and aa lines as the latter get rendered as tris finally again). Most everything else fails too, before the driver dies in a

[Piglit] [PATCH] texwrap: fix stencil texturing a bit

From: Roland Scheidegger Previously, the test was actually using all-zeros in the end for the image, so unsurprisingly it passed, except when border color was used. Add the special stencil case handling in a couple more cases. This will still not test depth/stencil textures

[Piglit] [PATCH] gl-3.2: add layered rendering test doing clipping

From: Roland Scheidegger This is more of a clip test involving the system-interpreted values (which cannot be interpolated). This exposes some problems in gallium for drivers using draw, where clipping such values was completely broken, thus layered rendering being generally

[Piglit] [PATCH] glsl-1.50/execution: add primitive id tests with tri strip primitives

From: Roland Scheidegger srol...@vmware.com Just using tri strip instead of tri fan. Exposing more bugs in llvmpipe/draw... --- ...imitive-id-no-gs-strip-first-vertex.shader_test | 62 ++ .../execution/primitive-id-no-gs-strip.shader_test | 60 + 2 files

[Piglit] [PATCH] fp-indirections: limit to 1024 indirections

From: Roland Scheidegger srol...@vmware.com The test takes ages (somewhere in the order of an hour) on llvmpipe, because the driver announces support for one million indirections (some drivers actually say billions even). It never gets compiled even, that hour is fully spent on string

[Piglit] [PATCH] tex-miplevel-selection: use GL_CLAMP_TO_EDGE instead of GL_REPEAT

From: Roland Scheidegger srol...@vmware.com GL_REPEAT is not legal for the rectangle targets, and because the test uses sampler objects the default GL_REPEAT value will be used even for rectangle target because unlike texture objects they can't be initialized to the legal CLAMP_TO_EDGE value.

[Piglit] [PATCH] lineloop: add test for checking behavior with many immediate mode verts

From: Roland Scheidegger srol...@vmware.com line loops are difficult to handle because when trying to accumulate vertex data in a buffer the loop must be closed at the end - this is problematic if using any kind of fixed size buffer. With immediate mode api (presumably display lists have similar

[Piglit] [PATCH] triangle-rasterization: increase the precision of the test

From: Zack Rusin za...@vmware.com Increase the subpixel precision to 8 bits. This requires changing some of the code to 64 bits to avoid overflows. v2 (sroland): Query GL for the number of subpixel bits and use that instead of a fixed 8 bits. Note that mesa drivers don't set this yet

[Piglit] [PATCH] glsl-1.30: add test for default in switch not after all case statements

From: Roland Scheidegger srol...@vmware.com By the looks of it default is not required to appear as last statement in a switch expression, and c rules should be followed (which is probably a mess to implement thanks to fallthrough). Seems to fail with mesa glsl compiler (at least with tgsi

[Piglit] [PATCH] arb_shader_texture_lod-texgradcube: Test explicit derivatives for cube maps

From: Roland Scheidegger srol...@vmware.com Similar to arb_shader_texture_lod-texgrad, but using cube maps instead. Given the somewhat undefined behavior of explicit gradients with cube maps, the main purpose of the test is really to test that those work at all, as there doesn't seem to be any

[Piglit] [PATCH] glsl-1.30: add basic test for testing textureOffset functionality.

From: Roland Scheidegger srol...@vmware.com This is pretty rough and doesn't really test all that much (just textureOffsetLod, but there's other texturing functions with offsets), doesn't test different wrap modes, NPOT sizes etc., but there's no other test using ordinary texture opcodes and

[Piglit] [PATCH] glsl-fs-main-return-conditional: Test for using return in main

From: Roland Scheidegger srol...@vmware.com Similar to glsl-fs-main-return (and glsl-vs-main-return), this is testing using return in main. Contrary to the these other tests, this hits both the cases where the return path is and is NOT taken (the gallivm code got it wrong and always did an early

[Piglit] [PATCH] glsl-fs-main-return-conditional: Test for using return in main

From: Roland Scheidegger srol...@vmware.com Similar to glsl-fs-main-return (and glsl-vs-main-return), this is testing using return in main. Contrary to the these other tests, this hits both the cases where the return path is and is NOT taken (the gallivm code got it wrong and always did an early

[Piglit] [PATCH] glsl-1.30: add basic test for testing textureOffset functionality.

From: Roland Scheidegger srol...@vmware.com This is pretty rough and doesn't really test all that much (just textureOffsetLod, but there's other texturing functions with offsets), doesn't test different wrap modes, NPOT sizes etc., but there's no other test using ordinary texture opcodes and

[Piglit] [PATCH] glsl-1.30: add basic test for testing textureOffset functionality.

From: Roland Scheidegger srol...@vmware.com This is pretty rough and doesn't really test all that much (just textureOffsetLod, but there's other texturing functions with offsets), doesn't test different wrap modes, NPOT sizes etc., but there's no other test using ordinary texture opcodes and

[Piglit] [PATCH] fs-texelFetchOffset-2D: don't assume undefined values to be solid black

From: Roland Scheidegger srol...@vmware.com core GL specifies out-of-bound texel fetches return undefined results, except in a robust context with ARB_robust_buffer_access_behavior supported (which is core in 4.3), in which case texel fetch will return 0 (OpenGL 4.3 compatibility profile, page

[Piglit] [PATCH] fs-texelFetchOffset-2D: don't assume undefined values to be solid black

From: Roland Scheidegger srol...@vmware.com core GL specifies out-of-bound texel fetches return undefined results, except in a robust context with ARB_robust_buffer_access_behavior supported (which is core in 4.3), in which case texel fetch will return 0 (OpenGL 4.3 compatibility profile, page

[Piglit] [PATCH] tests/spec/arb_robustness/draw-vbo-bounds.c: add clipping

From: Roland Scheidegger srol...@vmware.com Make sure clipping is needed sometimes, and more often use small index counts, to expose issues and excercise more paths in mesa's draw module. --- tests/spec/arb_robustness/draw-vbo-bounds.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)