Re: [Piglit] [PATCH] Add test for external sampler with 2D tex

2019-02-03 Thread Tapani Pälli
Agree, with Lionel, rendering some test pattern and reading back would be a good addition (piglit_draw_rect_tex + piglit_probe_texel_rect_rgba or similar) .. couple of 'nitpicks' below: On 2/2/19 10:42 AM, Aditya Swarup wrote: Commit 649c149dbb96ac367 removed the test for intel external samp

Re: [Piglit] [PATCH] Add test for external sampler with 2D tex

2019-02-03 Thread Lionel Landwerlin
On 02/02/2019 08:42, Aditya Swarup wrote: Commit 649c149dbb96ac367 removed the test for intel external sampler with dma only because of failure due to commit a5c39ed974402c - ("i965: Lift restriction in external textures for EGLImage support"). Since, there is no test coverage for external sample

Re: [Piglit] [PATCH] Add test for external sampler with 2D tex

2019-02-02 Thread Mark Janes
FWIW, the skqp test is run constantly in mesa ci: https://mesa-ci.01.org/mesa_master/builds/15138/results/174306816 Aditya Swarup writes: > Commit 649c149dbb96ac367 removed the test for intel external sampler > with dma only because of failure due to commit a5c39ed974402c - > ("i965: Lift rest

[Piglit] [PATCH] Add test for external sampler with 2D tex

2019-02-02 Thread Aditya Swarup
Commit 649c149dbb96ac367 removed the test for intel external sampler with dma only because of failure due to commit a5c39ed974402c - ("i965: Lift restriction in external textures for EGLImage support"). Since, there is no test coverage for external sampler with 2D tex, adding the test with modifica