Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-04-17 Thread Chad Versace
The conversion code below looks good to me. If that is added to your original patch, and removed is the comment above `enum piglit_gl_visual` that reads * Each enum has the same value of its corresponding GLUT enum. That is, for * each X, `PIGLIT_GL_VISUAL_X == GLUT_X`. Then the patch has

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-04-12 Thread Marek Olšák
OK, but I would like to commit this conversion code instead of hacking the bits: diff --git a/tests/util/piglit-framework-gl/piglit_glut_framework.c b/tests/util/piglit-framework-gl/piglit_glut_framework.c index ee5ac01..cfadf77 100644 --- a/tests/util/piglit-framework-gl/piglit_glut_framework.c

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-28 Thread Jose Fonseca
Me too FWIW Jose - Original Message - The patch seems to be too large for a mailing list. It's here: http://cgit.freedesktop.org/~mareko/piglit/commit/?id=8fa85790a3e5a3caba3a6eba912e7858c893363b Marek On Wed, Mar 27, 2013 at 11:39 PM, Brian Paul bri...@vmware.com wrote: On

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-28 Thread Chris Forbes
Looks good to me. I've fallen in this trap at least once, so it's great to see it go away. Feel free to add my R-b. -- Chris On Wed, Mar 27, 2013 at 6:13 AM, Marek Olšák mar...@gmail.com wrote: Hi, would anyone like to comment on this? Or is it still stuck in the moderation queue? Marek

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-27 Thread Brian Paul
On 03/26/2013 11:13 AM, Marek Olšák wrote: Hi, would anyone like to comment on this? Or is it still stuck in the moderation queue? I can't find the patch you're referring to. Repost? -Brian ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-27 Thread Marek Olšák
The patch seems to be too large for a mailing list. It's here: http://cgit.freedesktop.org/~mareko/piglit/commit/?id=8fa85790a3e5a3caba3a6eba912e7858c893363b Marek On Wed, Mar 27, 2013 at 11:39 PM, Brian Paul bri...@vmware.com wrote: On 03/26/2013 11:13 AM, Marek Olšák wrote: Hi, would

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-27 Thread Brian Paul
Looks OK to me but you might want to wait for other feedback. Reviewed-by: Brian Paul bri...@vmware.com On 03/27/2013 05:00 PM, Marek Olšák wrote: The patch seems to be too large for a mailing list. It's here:

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-27 Thread Dave Airlie
The patch seems to be too large for a mailing list. It's here: http://cgit.freedesktop.org/~mareko/piglit/commit/?id=8fa85790a3e5a3caba3a6eba912e7858c893363b LGTM as well! Dave. ___ Piglit mailing list Piglit@lists.freedesktop.org