Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-04 Thread Marek Olšák
On Fri, Sep 4, 2015 at 8:56 PM, Brian Paul wrote: > Nice, though, I'd like my first patch of the series which reworks the dd > interface to go in. It also cleans up some questionable/unneeded temporary > texture creating/binding code. Yeah, I've been waiting for that. Marek

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-04 Thread Brian Paul
Nice, though, I'd like my first patch of the series which reworks the dd interface to go in. It also cleans up some questionable/unneeded temporary texture creating/binding code. -Brian On 09/04/2015 12:11 PM, Marek Olšák wrote: Hi Brian, You don't need to spend more time on the swizzling f

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-04 Thread Marek Olšák
Hi Brian, You don't need to spend more time on the swizzling for ARB_copy_image if you don't want to. I have it almost done: http://cgit.freedesktop.org/~mareko/mesa/commit/?h=arb-copy-image Marek On Tue, Sep 1, 2015 at 4:14 PM, Brian Paul wrote: > Check that copies between textures whose form

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 1:14 PM, Fredrik Höglund wrote: > On Tuesday 01 September 2015, Ilia Mirkin wrote: >> On Tue, Sep 1, 2015 at 12:22 PM, Fredrik Höglund wrote: >> > On Tuesday 01 September 2015, Brian Paul wrote: >> >> On 08/31/2015 05:38 PM, Ilia Mirkin wrote: >> >> > On Mon, Aug 31, 2015 a

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Fredrik Höglund
On Tuesday 01 September 2015, Ilia Mirkin wrote: > On Tue, Sep 1, 2015 at 12:22 PM, Fredrik Höglund wrote: > > On Tuesday 01 September 2015, Brian Paul wrote: > >> On 08/31/2015 05:38 PM, Ilia Mirkin wrote: > >> > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin > >> > wrote: > >> >> Reviewed-by: Il

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Ilia Mirkin
On Tue, Sep 1, 2015 at 12:22 PM, Fredrik Höglund wrote: > On Tuesday 01 September 2015, Brian Paul wrote: >> On 08/31/2015 05:38 PM, Ilia Mirkin wrote: >> > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin wrote: >> >> Reviewed-by: Ilia Mirkin >> >> >> >> Thanks a lot for doing this! I assume that i

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Fredrik Höglund
On Tuesday 01 September 2015, Brian Paul wrote: > On 08/31/2015 05:38 PM, Ilia Mirkin wrote: > > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin wrote: > >> Reviewed-by: Ilia Mirkin > >> > >> Thanks a lot for doing this! I assume that it fails with your gallium > >> ARB_copy_image implementation as

[Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Brian Paul
Check that copies between textures whose formats may only differ by swizzling works correctly. v2: move test code into piglit_init() --- tests/all.py| 1 + tests/spec/arb_copy_image/CMakeLists.gl.txt | 1 + tests/spec/arb_copy_image/format-swizzle.c | 232

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-01 Thread Brian Paul
On 08/31/2015 05:38 PM, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin Thanks a lot for doing this! I assume that it fails with your gallium ARB_copy_image implementation as I predicted? Yes. In Mesa, I added some code that checks for swizzl

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-08-31 Thread Ilia Mirkin
On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > Thanks a lot for doing this! I assume that it fails with your gallium > ARB_copy_image implementation as I predicted? Oh, and same comment as on the other test -- this doesn't draw anything so it should probably d

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-08-31 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Thanks a lot for doing this! I assume that it fails with your gallium ARB_copy_image implementation as I predicted? On Mon, Aug 31, 2015 at 7:22 PM, Brian Paul wrote: > Check that copies between textures whose formats may only differ by > swizzling works correctly. > --

[Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-08-31 Thread Brian Paul
Check that copies between textures whose formats may only differ by swizzling works correctly. --- tests/all.py| 1 + tests/spec/arb_copy_image/CMakeLists.gl.txt | 1 + tests/spec/arb_copy_image/format-swizzle.c | 229 3 files chang