Re: [Piglit] [PATCH] arb_program_interface_query: corrected AoA's index variable expectation

2019-03-21 Thread Timothy Arceri
On 22/3/19 1:48 am, Andres Gomez wrote: On Sat, 2019-02-16 at 10:05 +1100, Timothy Arceri wrote: NAK. The problem is this will end up making the test fail on the Nvidia blob. Technically neither is incorrect, but the test does show Mesa's failure to detect the unused element. Again this is not

Re: [Piglit] [PATCH] arb_program_interface_query: corrected AoA's index variable expectation

2019-03-21 Thread Andres Gomez
On Sat, 2019-02-16 at 10:05 +1100, Timothy Arceri wrote: > NAK. > > The problem is this will end up making the test fail on the Nvidia blob. > Technically neither is incorrect, but the test does show Mesa's failure > to detect the unused element. Again this is not technically a failure of > the

Re: [Piglit] [PATCH] arb_program_interface_query: corrected AoA's index variable expectation

2019-02-15 Thread Timothy Arceri
NAK. The problem is this will end up making the test fail on the Nvidia blob. Technically neither is incorrect, but the test does show Mesa's failure to detect the unused element. Again this is not technically a failure of the spec as it's dependent on the implementations ability to detect act

[Piglit] [PATCH] arb_program_interface_query: corrected AoA's index variable expectation

2019-02-08 Thread Andres Gomez
Naming conventions, from the GL_ARB_program_interface_query extension: " * For an active variable declared as an array of an aggregate data type (structures or arrays), a separate entry will be generated for each active array element, unless noted immediately below. The na