Re: [Piglit] [PATCH] arb_separate_shader_objects: test mixed explicit and non-explicit locations

2015-11-19 Thread Timothy Arceri
On Thu, 2015-11-19 at 14:21 +0100, Gregory Hainaut wrote: > Hello Timothy, > > > There seems to be 3 separate issues so I think we should have a separate > > tests > > (or at least cleary labebled subtests) for each of them. > > In this case, I propose that we keep your new test. It has a better

Re: [Piglit] [PATCH] arb_separate_shader_objects: test mixed explicit and non-explicit locations

2015-11-18 Thread Gregory Hainaut
Hello Timothy, Normally the first of the 2 new SSO tests that I sent a couple of weeks ago cover this case. However my test is limited to the first location. Hopefully my Mesa patches take care of the issue. I will check it with this new test (and rebase my patches) Best regards, Gregory On

[Piglit] [PATCH] arb_separate_shader_objects: test mixed explicit and non-explicit locations

2015-11-17 Thread Timothy Arceri
This tests a bug in Mesa where explicit locations are not taken into account when assigning varying locations which results in two inputs/outputs being given the same location. Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass i965 - Mesa 11.1-dev: fail Cc: Ian Romanick