Re: [Piglit] [PATCH] arb_shader_image_load_store: compiler tests for memory qualifiers

2014-12-04 Thread Jordan Justen
On 2014-12-04 02:33:06, Francisco Jerez wrote: > Jordan Justen writes: > > > Signed-off-by: Jordan Justen > > Cc: Francisco Jerez > > --- > > Francisco, > > > > Question for your image-load-store branch: > > > > Should we parse the memory qualifiers separately from > > storage_qualifier? > > >

Re: [Piglit] [PATCH] arb_shader_image_load_store: compiler tests for memory qualifiers

2014-12-04 Thread Francisco Jerez
Jordan Justen writes: > Signed-off-by: Jordan Justen > Cc: Francisco Jerez > --- > Francisco, > > Question for your image-load-store branch: > > Should we parse the memory qualifiers separately from > storage_qualifier? > Yes, I've had something like that lying around in my private branch for

[Piglit] [PATCH] arb_shader_image_load_store: compiler tests for memory qualifiers

2014-12-03 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Francisco Jerez --- Francisco, Question for your image-load-store branch: Should we parse the memory qualifiers separately from storage_qualifier? I did a quick hack to bypass this issue: - if ($2.has_storage()) + if ($1.has_storage() && $2.has_storag