Re: [Piglit] [PATCH] arb_uniform_buffer_object-minmax: divide block size by 4 to get components

2014-06-25 Thread Ian Romanick
On 06/25/2014 12:27 PM, Brian Paul wrote: > GL_MAX_UNIFORM_BLOCK_SIZE is in bytes. A "component" is regarded as being > four bytes in size. So to compute the number of components, divide the > block size by 4. > > With this change, nvidia's driver passes the test. I might be tempted to s/4/size

Re: [Piglit] [PATCH] arb_uniform_buffer_object-minmax: divide block size by 4 to get components

2014-06-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Piglit on behalf of Brian Paul Sent: Wednesday, June 25, 2014 12:27 PM To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH] arb_uniform_buffer_object-minmax: divide block size by 4 to get components

[Piglit] [PATCH] arb_uniform_buffer_object-minmax: divide block size by 4 to get components

2014-06-25 Thread Brian Paul
GL_MAX_UNIFORM_BLOCK_SIZE is in bytes. A "component" is regarded as being four bytes in size. So to compute the number of components, divide the block size by 4. With this change, nvidia's driver passes the test. Found by Kai Ninomiya of VMware. --- tests/spec/arb_uniform_buffer_object/minmax.