Re: [Piglit] [PATCH] draw-vertices-half-float: Add coverage for GL_OES_vertex_half_float

2016-11-09 Thread Kenneth Graunke
On Monday, October 10, 2016 2:25:02 PM PST Kevin Strasser wrote: > Add ES2 implementation to the test to provide coverage for > GL_OES_vertex_half_float extension. The tests will continue to pass on mesa > for desktop GL as well as ES2 once supported is added. > > Signed-off-by: Kevin Strasser P

Re: [Piglit] [PATCH] draw-vertices-half-float: Add coverage for GL_OES_vertex_half_float

2016-11-03 Thread Tapani Pälli
On 11/03/2016 06:01 PM, Ilia Mirkin wrote: The RGB -> RGBA thing is probably because GLES is a lot pickier about formats matching and not having to do conversion. I had to do that all over the place when GLES-ifying piglits. Fixing this at the util level would be nice, but I couldn't think of a

Re: [Piglit] [PATCH] draw-vertices-half-float: Add coverage for GL_OES_vertex_half_float

2016-11-03 Thread Ilia Mirkin
The RGB -> RGBA thing is probably because GLES is a lot pickier about formats matching and not having to do conversion. I had to do that all over the place when GLES-ifying piglits. Fixing this at the util level would be nice, but I couldn't think of a reliable way to do so. On Thu, Nov 3, 2016 at

Re: [Piglit] [PATCH] draw-vertices-half-float: Add coverage for GL_OES_vertex_half_float

2016-11-03 Thread Tapani Pälli
going from RGB ro RGBA (adding of alpha channel) seems like an unnecessary change but harmless ... Reviewed-by: Tapani Pälli On 10/11/2016 12:25 AM, Kevin Strasser wrote: Add ES2 implementation to the test to provide coverage for GL_OES_vertex_half_float extension. The tests will continue to

[Piglit] [PATCH] draw-vertices-half-float: Add coverage for GL_OES_vertex_half_float

2016-10-10 Thread Kevin Strasser
Add ES2 implementation to the test to provide coverage for GL_OES_vertex_half_float extension. The tests will continue to pass on mesa for desktop GL as well as ES2 once supported is added. Signed-off-by: Kevin Strasser --- tests/all.py | 6 ++ tests/general/CMakeLis