Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-27 Thread Timothy Arceri
On 27/06/17 17:58, Samuel Pitoiset wrote: On 06/27/2017 02:19 AM, Timothy Arceri wrote: On 26/06/17 19:04, Samuel Pitoiset wrote: Looks like you forgot to update fbo-storage-formats.c. It's updated. Did you mean something else? I meant, there is a GL_INVALID_ENUM which is not handled

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-27 Thread Samuel Pitoiset
On 06/27/2017 02:19 AM, Timothy Arceri wrote: On 26/06/17 19:04, Samuel Pitoiset wrote: Looks like you forgot to update fbo-storage-formats.c. It's updated. Did you mean something else? I meant, there is a GL_INVALID_ENUM which is not handled correctly, no? With that fixed, patch

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Timothy Arceri
On 26/06/17 19:04, Samuel Pitoiset wrote: Looks like you forgot to update fbo-storage-formats.c. It's updated. Did you mean something else? With that fixed, patch is: Reviewed-by: Samuel Pitoiset Thanks! On 06/26/2017 08:00 AM, Timothy Arceri wrote: ---

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Samuel Pitoiset
Looks like you forgot to update fbo-storage-formats.c. With that fixed, patch is: Reviewed-by: Samuel Pitoiset Thanks! On 06/26/2017 08:00 AM, Timothy Arceri wrote: --- tests/fbo/fbo-1d.c | 1 + tests/fbo/fbo-3d.c

[Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Timothy Arceri
--- tests/fbo/fbo-1d.c | 1 + tests/fbo/fbo-3d.c | 1 + tests/fbo/fbo-alpha.c | 1 + tests/fbo/fbo-alphatest-formats.c | 1 + tests/fbo/fbo-alphatest-nocolor-ff.c | 1 +