Re: [Piglit] [PATCH] fix the fbo bind error check. a GL_INVALID_OPERATION error should be generated, instead of GL_INVALID_VALUE

2013-12-10 Thread Zhou, Jin
Sorry, this patch is incorrect. I have send the correct one. Please ignore it. From: Ken Phillis Jr [mailto:kphilli...@gmail.com] Sent: Wednesday, December 11, 2013 11:36 AM To: Jin Zhou Cc: piglit@lists.freedesktop.org; Zhou, Jin Subject: Re: [Piglit] [PATCH] fix the fbo bind error check. a

Re: [Piglit] [PATCH] fix the fbo bind error check. a GL_INVALID_OPERATION error should be generated, instead of GL_INVALID_VALUE

2013-12-10 Thread Ken Phillis Jr
I think this patch needs to be reworked. I believe there should be more than just adding a blank line. On Mon, Dec 9, 2013 at 4:44 AM, Jin Zhou wrote: > From: Jin Zhou > > diff --git a/tests/fbo/fbo-bind-renderbuffer.c > b/tests/fbo/fbo-bind-renderbuffer.c > index 50c8c7f..3b2b305 100644 > ---

[Piglit] [PATCH] fix the fbo bind error check. a GL_INVALID_OPERATION error should be generated, instead of GL_INVALID_VALUE

2013-12-09 Thread Jin Zhou
From: Jin Zhou diff --git a/tests/fbo/fbo-bind-renderbuffer.c b/tests/fbo/fbo-bind-renderbuffer.c index 50c8c7f..3b2b305 100644 --- a/tests/fbo/fbo-bind-renderbuffer.c +++ b/tests/fbo/fbo-bind-renderbuffer.c @@ -64,6 +64,7 @@ test_binding(GLboolean bindRenderbuffer)