Acked-by: Dave Airlie
On 18 April 2016 at 23:06, Andres Gomez wrote:
> Hi,
>
> this patch is still unreviewed.
>
> We'd welcome some help to get this into piglit with guarantees that the
> tests added are OK :)
>
> Br.
>
> On Mon, 2016-04-04 at 20:05 +0300, Andres Gomez wrote:
>> This patch prov
Hi,
this patch is still unreviewed.
We'd welcome some help to get this into piglit with guarantees that the
tests added are OK :)
Br.
On Mon, 2016-04-04 at 20:05 +0300, Andres Gomez wrote:
> This patch provides additional tests for the patch under review at:
> https://lists.freedesktop.org/arch
Hi Dave,
can I asume an "ack-by" from you for this patch, then?
On Wed, 2016-04-06 at 15:39 +0300, Andres Gomez wrote:
> Dave, continuing with your request at:
> https://lists.freedesktop.org/archives/piglit/2016-April/019350.html
>
> Tested with the needed patch at mesa-dev landed:
> https://l
Dave, continuing with your request at:
https://lists.freedesktop.org/archives/piglit/2016-April/019350.html
Tested with the needed patch at mesa-dev landed:
https://lists.freedesktop.org/archives/mesa-dev/2016-April/111842.html
Tested with llvmpipe
FAIL:
None.
SKIP:
* All
From the python side of things this looks really good (I can also vouch
for the CMake), I have a few small nits, but nothing serious and I don't
have a need to see another version. You should probably have someone
more GL qualified look at that, but for my part:
Reviewed-by: Dylan Baker
Quoting
This patch provides additional tests for the patch under review at:
https://lists.freedesktop.org/archives/mesa-dev/2016-April/111842.html
Also, this generator provides additional tests for the
ARB_gpu_shader_fp64 extension:
https://www.opengl.org/registry/specs/ARB/gpu_shader_fp64.txt
Which has
Generator for error checking on "flat" keyword.
This generator adds, additionally, checks for variables inside structs
and interface blocks, which weren't explicitly mentioned in the GLSL
specs and, partially, in the GLSL ES specs.
For a discussion about this check
https://lists.freedesktop.org/a
