Re: [Piglit] [PATCH] glsl: fix link empty program tests

2016-01-25 Thread Tapani Pälli
On 01/25/2016 01:43 PM, Timothy Arceri wrote: Also move them out of the shaders folder. From Section 7.3 (PROGRAM OBJECTS) of the OpenGL 4.5 spec: "Linking can fail for a variety of reasons as specified in the OpenGL Shading Language Specification, as well as any of the

Re: [Piglit] [PATCH] glsl: fix link empty program tests

2016-01-25 Thread Ian Romanick
On 01/25/2016 06:15 AM, Ilia Mirkin wrote: > It's _really_ difficult to tell what you've changed -- could you > resend with the diff generated with -M? (That flag should be accepted > by format-patch as well.) I like that! I was going to suggest submitting to patches (one that moves the test,

Re: [Piglit] [PATCH] glsl: fix link empty program tests

2016-01-25 Thread Ian Romanick
As Tapani pointed out, this change is not valid for compatibility profile... and both of these tests currently pass on Mesa. Looking at the two tests, I'm not sure what the value is of having both. glsl-link-empty-prog-01.c appears to try to reproduce a bug when linking a program with no shaders

[Piglit] [PATCH] glsl: fix link empty program tests

2016-01-25 Thread Timothy Arceri
Also move them out of the shaders folder. From Section 7.3 (PROGRAM OBJECTS) of the OpenGL 4.5 spec: "Linking can fail for a variety of reasons as specified in the OpenGL Shading Language Specification, as well as any of the following reasons: - No shader objects are attached to