Re: [Piglit] [PATCH] json.py: don't rename the results file when updating results version

2015-04-21 Thread Dylan Baker
On Tue, Apr 21, 2015 at 11:06:16AM -0700, Dylan Baker wrote: > I think you're trying to handle a case that can't (or maybe shouldn't) > happen. > > _update_results is a helper called only by load_results, which always > passes in a filename, so I think that in every case you'd end up hitting > the

Re: [Piglit] [PATCH] json.py: don't rename the results file when updating results version

2015-04-21 Thread Dylan Baker
I think you're trying to handle a case that can't (or maybe shouldn't) happen. _update_results is a helper called only by load_results, which always passes in a filename, so I think that in every case you'd end up hitting the isfile path. In fact, I've added an 'assert os.path.isfile(filepath)' an

[Piglit] [PATCH] json.py: don't rename the results file when updating results version

2015-04-21 Thread Thomas Wood
Keep the existing results file name if the results input was a file rather than a directory. Signed-off-by: Thomas Wood --- framework/backends/json.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/framework/backends/json.py b/framework/backends/json.py index affd