[Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Ilia Mirkin
Old files have duplicated entries for each subtest, in addition to a filled subtest dictionary. Detect that the current test name is also a subtest and treat it as though it were a complete test. This may have false-negatives, but they're unlikely given test/subtest naming convention. Signed-off-b

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Matt Turner
On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin wrote: > Dylan, I'm sure you hate this, but it does seem to work for me. Not sure where > you are with your fix, but this is a tool that lots of people use, so it does > need to be addressed. Does it? What's the purpose of comparing results from diffe

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Michel Dänzer
On 29.05.2014 13:09, Matt Turner wrote: > On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin wrote: >> Dylan, I'm sure you hate this, but it does seem to work for me. Not sure >> where >> you are with your fix, but this is a tool that lots of people use, so it does >> need to be addressed. > > Does it

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Dylan Baker
On Thursday, May 29, 2014 13:15:54 Michel Dänzer wrote: > On 29.05.2014 13:09, Matt Turner wrote: > > On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin wrote: > >> Dylan, I'm sure you hate this, but it does seem to work for me. Not sure > >> where you are with your fix, but this is a tool that lots of

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Dylan Baker
On Wednesday, May 28, 2014 22:17:55 Ilia Mirkin wrote: > Old files have duplicated entries for each subtest, in addition to a > filled subtest dictionary. Detect that the current test name is also a > subtest and treat it as though it were a complete test. This may have > false-negatives, but they'

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Matt Turner
On Wed, May 28, 2014 at 9:15 PM, Michel Dänzer wrote: > On 29.05.2014 13:09, Matt Turner wrote: >> On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin wrote: >>> Dylan, I'm sure you hate this, but it does seem to work for me. Not sure >>> where >>> you are with your fix, but this is a tool that lots of

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Michel Dänzer
On 29.05.2014 13:18, Dylan Baker wrote: > On Thursday, May 29, 2014 13:15:54 Michel Dänzer wrote: >> On 29.05.2014 13:09, Matt Turner wrote: >>> On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin > wrote: Dylan, I'm sure you hate this, but it does seem to work for me. Not > sure where you ar

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Michel Dänzer
On 29.05.2014 13:22, Matt Turner wrote: > On Wed, May 28, 2014 at 9:15 PM, Michel Dänzer wrote: >> On 29.05.2014 13:09, Matt Turner wrote: >>> On Wed, May 28, 2014 at 7:17 PM, Ilia Mirkin wrote: Dylan, I'm sure you hate this, but it does seem to work for me. Not sure where you are

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-28 Thread Kenneth Graunke
On 05/28/2014 07:17 PM, Ilia Mirkin wrote: > Old files have duplicated entries for each subtest, in addition to a > filled subtest dictionary. Detect that the current test name is also a > subtest and treat it as though it were a complete test. This may have > false-negatives, but they're unlikely

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-29 Thread Ilia Mirkin
On Thu, May 29, 2014 at 12:59 AM, Kenneth Graunke wrote: > On 05/28/2014 07:17 PM, Ilia Mirkin wrote: >> Old files have duplicated entries for each subtest, in addition to a >> filled subtest dictionary. Detect that the current test name is also a >> subtest and treat it as though it were a comple

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-29 Thread Ilia Mirkin
On Thu, May 29, 2014 at 8:37 AM, Ilia Mirkin wrote: > On Thu, May 29, 2014 at 12:59 AM, Kenneth Graunke > wrote: >> On 05/28/2014 07:17 PM, Ilia Mirkin wrote: >>> Old files have duplicated entries for each subtest, in addition to a >>> filled subtest dictionary. Detect that the current test name

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-29 Thread Marek Olšák
First, I'm sorry for complaining and not reviewing patches, because I don't know Python very well and I'm also quite busy. I'm grateful for all the work on piglit that's happening. I always keep old piglit results from old Mesa around, that includes R580, RV670, RV730, EG/Redwood, NI/Cayman, SI/Ve

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-29 Thread Michel Dänzer
On 29.05.2014 22:23, Ilia Mirkin wrote: > On Thu, May 29, 2014 at 8:37 AM, Ilia Mirkin wrote: >> On Thu, May 29, 2014 at 12:59 AM, Kenneth Graunke >> wrote: >>> On 05/28/2014 07:17 PM, Ilia Mirkin wrote: Old files have duplicated entries for each subtest, in addition to a filled subtes

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-30 Thread Kenneth Graunke
On Thursday, May 29, 2014 09:23:17 AM Ilia Mirkin wrote: > On Thu, May 29, 2014 at 8:37 AM, Ilia Mirkin wrote: > > On Thu, May 29, 2014 at 12:59 AM, Kenneth Graunke wrote: > >> On 05/28/2014 07:17 PM, Ilia Mirkin wrote: > >>> Old files have duplicated entries for each subtest, in addition to a >