Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-05 Thread Jason Ekstrand
Dylan, There's one more on line 196 that you're missing. Wrapping that one in escape_pathname fixes it up nicely. With that change, Reviewed-by: Jason Ekstrand --Jason On Fri, Sep 5, 2014 at 11:35 AM, Jason Ekstrand wrote: > Yeah, on second thought, not quite working... I'll poke at it a

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-05 Thread Jason Ekstrand
Yeah, on second thought, not quite working... I'll poke at it a bit. On Thu, Sep 4, 2014 at 10:11 PM, Jason Ekstrand wrote: > Thanks a bunch Dylan. It's working great for me. > --Jason > > > On Thu, Sep 4, 2014 at 5:11 PM, Dylan Baker > wrote: > >> On Friday, September 05, 2014 12:22:02 AM E

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Jason Ekstrand
Thanks a bunch Dylan. It's working great for me. --Jason On Thu, Sep 4, 2014 at 5:11 PM, Dylan Baker wrote: > On Friday, September 05, 2014 12:22:02 AM Emil Velikov wrote: > > On 04/09/14 22:55, Dylan Baker wrote: > > > On Thursday, September 04, 2014 10:49:10 PM Emil Velikov wrote: > > >> On

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Dylan Baker
On Friday, September 05, 2014 12:22:02 AM Emil Velikov wrote: > On 04/09/14 22:55, Dylan Baker wrote: > > On Thursday, September 04, 2014 10:49:10 PM Emil Velikov wrote: > >> On 04/09/14 21:54, Dylan Baker wrote: > >>> This solves the bug of running piglit run -n 'wip/foo' which causes a > >>> numb

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Emil Velikov
On 04/09/14 22:55, Dylan Baker wrote: > On Thursday, September 04, 2014 10:49:10 PM Emil Velikov wrote: >> On 04/09/14 21:54, Dylan Baker wrote: >>> This solves the bug of running piglit run -n 'wip/foo' which causes a >>> number of issues in the html summary generation. >>> >> From a quick look it

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Dylan Baker
On Thursday, September 04, 2014 10:49:10 PM Emil Velikov wrote: > On 04/09/14 21:54, Dylan Baker wrote: > > This solves the bug of running piglit run -n 'wip/foo' which causes a > > number of issues in the html summary generation. > > > From a quick look it seems that it might help with a funny is

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Emil Velikov
On 04/09/14 21:54, Dylan Baker wrote: > This solves the bug of running piglit run -n 'wip/foo' which causes a > number of issues in the html summary generation. > >From a quick look it seems that it might help with a funny issue that I'm >seeing: Whenever piglit is ran on Windows the testname us

Re: [Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Ilia Mirkin
On Thu, Sep 4, 2014 at 4:54 PM, Dylan Baker wrote: > This solves the bug of running piglit run -n 'wip/foo' which causes a > number of issues in the html summary generation. > > CC: Jason Ekstrand > Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin > --- > framework/summary.py | 14 +++

[Piglit] [PATCH] summary.py: Replace path separators in testrun names

2014-09-04 Thread Dylan Baker
This solves the bug of running piglit run -n 'wip/foo' which causes a number of issues in the html summary generation. CC: Jason Ekstrand Signed-off-by: Dylan Baker --- framework/summary.py | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/framework/summary.py