Re: [Piglit] [PATCH] util/wfl: unbound the current context before destroying its window

2014-10-02 Thread Emil Velikov
On 02/10/14 06:21, Dylan Baker wrote: > Should the subject say 'unbind' rather than 'unbound'? > Indeed it should. I had the feeling that it does not sounds quite right, thanks for spotting :) Planning to get this an the other leakfix (incl. Ilia's t-b, and the typo/grammar fixed) over the weeken

Re: [Piglit] [PATCH] util/wfl: unbound the current context before destroying its window

2014-10-02 Thread Emil Velikov
On 02/10/14 06:21, Dylan Baker wrote: > Should the subject say 'unbind' rather than 'unbound'? > Indeed it should. I had the feeling that it does not sounds quite right, thanks for spotting :) Planning to get this an the other leakfix (incl. Ilia's t-b, and the typo/grammar fixed) over the weeken

Re: [Piglit] [PATCH] util/wfl: unbound the current context before destroying its window

2014-10-01 Thread Dylan Baker
Should the subject say 'unbind' rather than 'unbound'? On Wednesday, October 01, 2014 02:01:57 AM Emil Velikov wrote: > Otherwise we end up leaking the drawable. Spotted by Valgrind > > Signed-off-by: Emil Velikov > --- > > Perhaps we can simplify the call chain for the following a bit > make_c

Re: [Piglit] [PATCH] util/wfl: unbound the current context before destroying its window

2014-10-01 Thread Ilia Mirkin
I've applied this patch, and your other patch, and can confirm that things are a *lot* better. There appears to be a leak from stuff done by _mesa_glsl_initialize_builtin_functions -- investigating whether that's a mesa thing or piglit still not shutting things down. These are Tested-by: Ilia Mir

[Piglit] [PATCH] util/wfl: unbound the current context before destroying its window

2014-10-01 Thread Emil Velikov
Otherwise we end up leaking the drawable. Spotted by Valgrind Signed-off-by: Emil Velikov --- Perhaps we can simplify the call chain for the following a bit make_current > make_current_singlepass > special_case31 > make_curren_singlepass... But that for another day :P -Emil tests/util/pigli