Re: [Piglit] [PATCH 02/11] glsl-1.50: Actually test row-major vs. column-major

2014-09-17 Thread Ian Romanick
On 09/16/2014 08:06 PM, Chris Forbes wrote: Are you sure? Previously, if the data had been stored in the wrong orientation, you should have got (0.25, 0.75, 0.5, 1) due to the 0.5 and 0.75 being off the diagonal. Looking at the test again, I believe you are correct. I remember I made this

Re: [Piglit] [PATCH 02/11] glsl-1.50: Actually test row-major vs. column-major

2014-09-16 Thread Chris Forbes
Are you sure? Previously, if the data had been stored in the wrong orientation, you should have got (0.25, 0.75, 0.5, 1) due to the 0.5 and 0.75 being off the diagonal. (Or I've completely misunderstood something...) On Tue, Sep 9, 2014 at 9:34 AM, Ian Romanick i...@freedesktop.org wrote:

[Piglit] [PATCH 02/11] glsl-1.50: Actually test row-major vs. column-major

2014-09-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The way the data was previously laid out, both tests would pass even if the driver stored the data in the wrong orientation. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/spec/glsl-1.50/uniform_buffer/gs-mat4-row-major.shader_test | 2