Re: [Piglit] [PATCH 1/2] shader_runner regression with gles

2013-01-21 Thread Chad Versace
On 01/17/2013 03:08 PM, Tom Gall wrote: > Augment the parser that examines the shader_test file passed in > with the test to determine which brand of shader_running to > execute, shader_runner, shader_runner_gles2, etc. > > This fixes a bug where GLSL ES if first in the [required] section > could

Re: [Piglit] [PATCH 1/2] shader_runner regression with gles

2013-01-21 Thread Tom Gall
On Mon, Jan 21, 2013 at 12:39 PM, Paul Berry wrote: > I'd suggest changing to a commit subject that describes precisely what > change you're making in the active voice, e.g. something like "Fix > shader_runner regexps to match new version requirement syntax". The > existing commit subject ("shade

Re: [Piglit] [PATCH 1/2] shader_runner regression with gles

2013-01-21 Thread Paul Berry
I'd suggest changing to a commit subject that describes precisely what change you're making in the active voice, e.g. something like "Fix shader_runner regexps to match new version requirement syntax". The existing commit subject ("shader_runner regression with gles") is too vague. On 17 January

[Piglit] [PATCH 1/2] shader_runner regression with gles

2013-01-17 Thread Tom Gall
Augment the parser that examines the shader_test file passed in with the test to determine which brand of shader_running to execute, shader_runner, shader_runner_gles2, etc. This fixes a bug where GLSL ES if first in the [required] section could match against GL after which the wrong shader_runner