On 28 January 2013 17:18, Matt Turner wrote:
> On Mon, Jan 28, 2013 at 5:11 PM, Tom Gall wrote:
> > Sure, but tell that to the compiler.
> >
> > It is bad form to not have a return at the end of a function which is
> > supposed to return something. The other way perhaps is just knock out
> > th
arm-linux-androideabi-gcc (GCC) 4.6.x-google 20120106 (prerelease)
external/piglit/tests/util/piglit_ktx.c: In function
'target_to_texture_binding':
external/piglit/tests/util/piglit_ktx.c:761:1: error: control reaches
end of non-void function [-Werror=return-type]
On Mon, Jan 28, 2013 at 7:18 PM
On Mon, Jan 28, 2013 at 5:11 PM, Tom Gall wrote:
> Sure, but tell that to the compiler.
>
> It is bad form to not have a return at the end of a function which is
> supposed to return something. The other way perhaps is just knock out
> the default case and return that. Either way.
% cat t.cpp
#i
Sure, but tell that to the compiler.
It is bad form to not have a return at the end of a function which is
supposed to return something. The other way perhaps is just knock out
the default case and return that. Either way.
On Mon, Jan 28, 2013 at 7:01 PM, Matt Turner wrote:
> On Mon, Jan 28, 20
On Mon, Jan 28, 2013 at 2:09 PM, Ian Romanick wrote:
> These changes seem innocuous enough.
>
> Reviewed-by: Ian Romanick
They are... but 2/3 and 3/3 are adding unreachable return statements
after switches with a default case that asserts. Kind of bogus.
_
I'm using the "android" branch on:
git://git.linaro.org/people/tomgall/piglit.git
It's a WIP however what is there builds as long as you put it into
external/piglit as well as have waffle already built. It uses
Android.mk files as compared to Adrian's earlier patches that he
posted but the piglit
Thanks. These are reviewed-by me and now committed.
By the way, which Piglit branch are you using for Android?
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
These changes seem innocuous enough.
Reviewed-by: Ian Romanick
On 01/28/2013 10:30 AM, Tom Gall wrote:
Android is a bit more strict when it builds. Missing was ctype.h.
It doesn't break Linux.
Signed-off-by: Tom Gall
---
tests/util/piglit-vbo.cpp |1 +
1 file changed, 1 insertion(+)
Android is a bit more strict when it builds. Missing was ctype.h.
It doesn't break Linux.
Signed-off-by: Tom Gall
---
tests/util/piglit-vbo.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/util/piglit-vbo.cpp b/tests/util/piglit-vbo.cpp
index 4900931..b2e2e63 100644
--- a/tests/u
