Re: [Piglit] [PATCH 1/4] GS: Test that geometry shader input/output layout qualifiers only compile if valid

2013-10-14 Thread Paul Berry
On 30 September 2013 15:38, Nicholas Mack wrote: > v2: Tests check against list of valid layouts instead of invalid layouts > Last time I reviewed this patch I pointed out that it's not necessary to have vertex and fragment shaders in the test, since the error is supposed to be detected at compi

[Piglit] [PATCH 1/4] GS: Test that geometry shader input/output layout qualifiers only compile if valid

2013-09-30 Thread Nicholas Mack
v2: Tests check against list of valid layouts instead of invalid layouts --- tests/all.tests| 12 ++ .../glsl-1.50/execution/geometry/CMakeLists.gl.txt | 2 + .../geometry/gs-input-layout-qualifiers.c | 128 + .../geometry/gs-outp

Re: [Piglit] [PATCH 1/4] GS: Test that geometry shader input/output layout qualifiers only compile if valid

2013-09-30 Thread Paul Berry
Sorry for the slow responses, Nick. I got behind in patch review in the last two weeks and I'm only just now catching up. On 16 September 2013 09:35, Nicholas Mack wrote: > --- > tests/all.tests| 12 ++ > .../glsl-1.50/execution/geometry/CMakeLists.gl.txt |

[Piglit] [PATCH 1/4] GS: Test that geometry shader input/output layout qualifiers only compile if valid

2013-09-16 Thread Nicholas Mack
--- tests/all.tests| 12 ++ .../glsl-1.50/execution/geometry/CMakeLists.gl.txt | 2 + .../geometry/gs-input-layout-qualifiers.c | 137 .../geometry/gs-output-layout-qualifiers.c | 139 + 4 files change